Coder Social home page Coder Social logo

Comments (10)

yaslena avatar yaslena commented on June 24, 2024

This a duplicate of #116

from marugoto.

martindusinberre avatar martindusinberre commented on June 24, 2024

@Helena-LiT It's not quite a duplicate because the radioButtonExercise transition, which was also part of #116 , is fixed.

from marugoto.

nemtish avatar nemtish commented on June 24, 2024

should be fixed with 4ab23d1

from marugoto.

martindusinberre avatar martindusinberre commented on June 24, 2024

Thanks so much, @nemtish we'll test it tomorrow. Best, Martin

from marugoto.

yaslena avatar yaslena commented on June 24, 2024

@Helena-LiT It's not quite a duplicate because the radioButtonExercise transition, which was also part of #116 , is fixed.

@martindusinberre The changes that presumably caused all these bugs were made at the same time and in the same instance (the trailer bug is not newer than the other transition bugs), so these two issues should be linked when people are looking for the cause of the problem. Adding a duplicate marker is just one way in GitHub to link two related issues, which makes sense when all of #120 is contained in #116.

from marugoto.

yaslena avatar yaslena commented on June 24, 2024

I would like to add some of my observations on the transition bug (autotransition + page criteria: visited) based on the Madness (Managing Lunacy storyline):

  • presence of autotransition on a page (in page.json) causes the game to disregard any "page criteria" : "visted" objects (in pageTransition.json) displaying pageTransitions (button text) that should not be available
  • presence of autotransition on a page (in page.json) causes the game to disregard any "page criteria" : "visted" objects (in pageTransition.json) automatically triggering pageTransitions that should not be available
  • presence of autotransition on a page does not cause the game to disregard other page criteria like "exerciseCriteria": "correctInput"
  • autotransition can currently only trigger Transition1 but will never automatically trigger Transition2, Transition3 and so on even when transition criteria for these other page transitions are met.

from marugoto.

martindusinberre avatar martindusinberre commented on June 24, 2024

Setting aside these other transition issues for a moment: the original bug, which appears with a combination of "visited"/"notVisited" criteria in pageTransition.json files and the timer/autoTransitionOnTimerExpiration being "true" in page.json files is still there (on the test system, not on the live system).
Whereas previously (as described above) two buttonTexts appeared where they shouldn't, the problem tonight was different: the buttonTexts worked fine (i.e. only one appeared), but the timer counted me down from 12 minutes, even though it was set to 300 in the page.json file. See the two screenshots (top screenshot taken when there were 10 minutes left on the timer).

Screenshot 2020-06-05 at 20 04 16

Screenshot 2020-06-05 at 20 10 29

from marugoto.

yaslena avatar yaslena commented on June 24, 2024

I don't have the same problem with the timer in the trailer. I have tested this page in firefox and edge browsers and I always get the correct 5min displayed. Maybe it's a browser problem (chrome?) or the problem is already solved.

from marugoto.

yaslena avatar yaslena commented on June 24, 2024

I would like to add some of my observations on the transition bug (autotransition + page criteria: visited) based on the Madness (Managing Lunacy storyline):

* presence of **autotransition** on a page (in page.json) causes the game to **disregard** any **"page criteria" : "visted"** objects (in pageTransition.json) **displaying** pageTransitions (button text) that should not be available

* presence of **autotransition** on a page (in page.json) causes the game to **disregard** any **"page criteria" : "visted"** objects (in pageTransition.json) automatically **triggering** pageTransitions that should not be available

* presence of **autotransition** on a page **does not** cause the game to disregard other page criteria like **"exerciseCriteria": "correctInput"**

* **autotransition** can currently **only trigger Transition1** but will never automatically trigger Transition2, Transition3 and so on even when transition criteria for these other page transitions are met.

I think all of the above was already solved.

from marugoto.

martindusinberre avatar martindusinberre commented on June 24, 2024

I don't have the same problem with the timer in the trailer. I have tested this page in firefox and edge browsers and I always get the correct 5min displayed. Maybe it's a browser problem (chrome?) or the problem is already solved.

OK, many thanks for pointing this out: has just worked for me fine in Firefox, too. What I experienced may be connected to #126 (I was testing many games consecutively) so for the time being, I'll close this assuming that this particular issue (combination of criteria + timer) is fixed.

from marugoto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.