Coder Social home page Coder Social logo

marugoto's People

Contributors

christian-bernet avatar fossabot avatar interrogator avatar ledutomic avatar lfeine avatar rbeeli avatar witlox avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

marugoto's Issues

Notebook problem with "add new note"

The players are confused by the fact that when they "add new note" to a particular notebook page, and then return to the main page, and then open the notebook again and try to "add new note", they cannot do so.
I think there are two solutions to this:

  • either the button "add new note" should no longer display when the student opens a new note, so that it's clear that they have to return to the input field they were previously using
  • or we should add the button "Save Notebook Input", which the player will close before they leave the notebook; and then, when they return to the notebook (still on the same page), the "add new note" button actually opens an entirely new text field, with its own time stamp.

Add a Home button, in place of Back functionality

Back functionality is being disabled, to stop the user exiting the game by mistake.

Instead, we should add some kind of link to the mainpage from within the game, either saying Marugoto or Home. Seems like this can just be done in pure HTML.

Finish content for download pdf

The content of the notebook pdf is not finished. we need to talk about how should the content should looks like.
Estimate 8 hours

Fix error for coverage reporting

Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project parent: Execution default-cli of goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report failed: A required class was missing while executing org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report: javax/xml/bind/DatatypeConverter

In the backend....

Dealing with changes to game model/JSON scheme

Today we found out that isAbsolute key is unused, so it was removed from JSON. That's good. Because of this, the time key format became redundant. Time is now specified like this:

{"time": {"time": int}}

Ideally, the nested object is simply replaced by an int. @christian-bernet however says that such a change is difficult to make. So, this issue is both the specific (i.e. making it simply "time": int) and the general (i.e. making it as simple as possible to update the model.

Game creators need the JSON format to be as concise and unambiguous as possible. It is already a lot of work building a game. Eventually, there will need to be a document explaining how to write your own game, and that document is going to have to explain that time is written in this redundant way. If even small changes like this can't be easily updated now (when we have few games and no users), I worry that maintenance will be super difficult later.

Can we get, at least, a few written instructions about How to update the model --- which files need to be touched, etc.. I can't imagine this part of the codebase was developed without considering the fact that the format may undergo revision in the future??

Use of backspace in Notebook

Several players noted that when they are inputting in notebook, and then use the backspace button, they lose their entire notebook entry input; and in two cases, using the backspace button also sent them back to the very frontpage of the game. Can we fix this?

Session management when internet dies

During our testing, we had some internet connectivity issues. I found that basically any disruption in internet would send me back to the login screen, while other websites I have logins for remember me without issue. So I guess some session data storage with good timeouts could solve this.

Open notebook while in Inbox?

Several players asked if it would be possible to open the notebook while they are in Inbox. This is because they wanted to see their notes while they were writing an email reply (e.g. to Professor Moira).
Is it possible?

Some browsers prevent page transitions

Pim/Danny/Ramun will be able to explain this better than me, but some players had problems transitioning when they were playing in particular browsers (e.g. Firefox).

Page transition blocked on 2.1.9

This has just occurred as I was trying to play through to test #28.
I'm on 2.1.9 (having come via 2.1.7--it's important to know this as usually I come via 2.1.6).
I now can't transition to 2.2.1 (which is where I will go if I've come via 2.1.7) because when I click on "Continue", nothing happens.

imageComponent files with multiple jpg images

This remains a problem (as of Monday 5th August), although my comment on Rocketchat was on July 22nd: Last week, when I played, I came into 2.4.3.2 from 2.4.3.1.1.5, and instead of showing the correct image at 2.4.3.2, the game gave me an image from 2.4.3.1.1.5 which stayed with me for the rest of my game play to the end of ch4.
Similarly, today, I came into 2.4.3.2 from 2.4.3.1.5.4 (HPV) and for the rest of the game (end of ch4) I had the 2.4.3.1.5.4 image.

Remove gender choice in first sign-in

For avoidance of difficult gender issue debates, I think we should remove the gender choice (male/female) from the player's first sign-in. Once this is done, I'll remove the user.gender references in the json files, and just use the first+last name combination instead.

Downloading notebook as PDF does not work

I tried to download the PDF contents of my Notebook. A download does start, for marugoto-notebook.pdf, but the content is not PDF:

<!DOCTYPE html><html lang=en><head><meta charset=utf-8><meta http
equiv=X-UA-Compatible content="IE=edge"><meta name=viewport
content="width=device-width,initial-scale=1"><link rel=icon href=
favicon.ico><title>Marugoto</title><link href="https://fonts.googleapis.com/css
family=Libre+Baskerville:400,400i,700&amp;subset=latin-ext" rel=stylesheet><link
href="https://fonts.googleapis.com/css?family=Kalam
300,400&display=swap&subset=latin-ext" rel=stylesheet><link href="https:/
fonts.googleapis.com/css?family=DM+Sans:400,500,700&display=swap"
rel=stylesheet><link href=/css/app.b3f83eb2.css rel=preload as=style><link href=
css/chunk-vendors.d4504d4a.css rel=preload as=style><link href=/js/app
8bd54bd3.js rel=preload as=script><link href=/js/chunk-vendors.959f57b0.js
rel=preload as=script><link href=/css/chunk-vendors.d4504d4a.css
rel=stylesheet><link href=/css/app.b3f83eb2.css rel=stylesheet><
head><body><noscript><strong>We're sorry but hello-world doesn't work properly
without JavaScript enabled. Please enable it to continue.</strong></noscript><div
id=app></div><script src=/js/chunk-vendors.959f57b0.js></script><script src=/js
app.8bd54bd3.js></script></body></html

Standardize existing json files once a change has been made

This is a question that directly arises from #39, but which I've wondered now for a long time: once a change has been made, is it possible to update all the json files so that the implementers (me, Lena, Leyla) are always dealing with the most up-to-date json file? At the moment, because of similar content, I have created json files (say, for HSA on day 4) based on previous json files (say, HSA day 1). But if we change a function in the day 1 json files, is there any way to cascade the changes so that day 4 only shows the new elements we have developed? (see, for one example, the different versions of notebookEntry1 which now exist, e.g. between 2.4.5.1.2.3 and 2.4.5.1.3.2).

Money calculator mistake

(again, from July 22:) I was just playing 2.4.3.1.1.5, where I had 301EUR. When I transitioned into 2.4.3.2, the game should have reduced my 301 EUR by 25 EUR (-25.0). But now I'm on 2.4.3.2, my money amount is simply shown as -25 EUR. So the calculator isn't quite working as planned.

Map visible at end of topic

This is one feature which many testers and stakeholders insist we shouldn't lose. How can we make it work within the time/budget constraints?

Email inbox small feature change

When a player receives an email, the email display on the right-hand side of the page includes the button "Respond to E-mail". (This button is also at the end of the displayed email.) In both cases, can we change this simply to "Reply"?

Page transition not working 2.4.5.1.7xx

The page transition from 2.4.5.1.7.1 to 2.4.5.1.7.2 is slow. Then the page transition from 2.4.5.1.7.2 to 2.4.5.1.7.3. doesn't work at all--it just crashed out and took me to the log-in page again. When I logged in again, however, and went to "Continue" my game, I got back to 2.4.5.1.7.3 just fine.

Remove notebookVisible on page

If we do not need that, then we should remove it in backend.
Because in frontend thats not working.
Estimate for removing in backend: 1 hour.

Ability to input textExercise *and* see zoomed image simultaneously

This is a high-priority request from the players: at the moment, when they have a textExercise (e.g. 2.4.1.3.1.2, or when it repeats as 2.4.3.1.1.2, 2.4.4.1.1.2 and 2.4.5.1.1.2), they are unable to read the handwriting in the unzoomed image. So they use the image zoom functionality. But then they are unable to input the textExercise without first closing the image zoom. One player responded by taking a photo of the zoomed image and then using the photo (on her phone) to complete the textExercise.
Is there any way we can have zoomed image and some kind of text input (textExercise, dateExercise etc) on the same page?

GitHub and Twitter links on main page

Users need to be able to give feedback. It makes sense that they can either Tweet at us, or make GitHub issues. So, two buttons in the HTML, plus adding a Contributing section to this README.

Asynchronous processing v.s. state update

While having a 'slow' connection between the front-end and back-end, a user can for example click on 'send email' multiple times before receiving a state update on the front end. This can result in receiving a mail 10 times. This may also be related to 'not being able to transition' to a new page, if the state update is very slow.

Can we throttle the connection between the backend and frontend to check when this actually occurs? is it due to a backend processing delay, or an actual connection lag?

Page transitions in HMCS storylines not working

On 2.4.3.1.2.2 (and presumably also 2.4.4.1.2.2 and 2.4.5.1.2.2), I am unable to transition to the next page (2.4.3.1.2.3 etc). This seems to be a problem with the button text not appearing even though I have entered the correct numbers in the dateExercises. Can you check what the problem is?

textExercise "My Answer" input

Previously, I asked if the "My Answer" line could be removed from the Notebook, as I would never write such a thing in a research notebook. Christian made the good point that we need some indicator of player-generated input (as distinguished from automatic input). Can we therefore change the line from "My Answer" to "My Input"? (This makes the notebook less like an exercise book, with questions and answers, and more like a place where the player is thinking and writing.)

swiping back / using back button in browser

The players were frustrated that when they swiped back a page on their touchpad, or used the browser back button, they were take to the front page of the game. Is there any kind of pop-up functionality we can add to warn the player that they are effectively about to exit the game?

Split Screen bug

Previously, the bug has occurred on the transition 2.4.1.3.3.3 into 2.4.2.1 transition. Also 2.4.3.1.5.1HPV into 2.4.3.1.5.2. When I played again on Thursday morning, it occurred elsewhere.

visitedAny criteria: please check again

Lena are not sure the visitedAny criteria is working for pageTransition files. So far as Christian explained it (Rocketchat 11 July), if I have "visitedAny" followed by a, b, or c, the player will only see the pageTransition button if they were on a, b or c. But that isn't the way it's working in chapter4 at the moment: in the key page transitions (2.4.2.2, 2.4.3.2, 2.4.4.3), page transition buttons are visible even if the player was not on a, b, or c. This also seems to be a problem for "visited". Can you check again? (The functionality of notVisited is working just fine, so far as we can see.)

notVisited: work around solution for notVisited *or* notVisited

But there's now still a problem in terms of notVisited when there are more than one inputs.
For example, I played chapter 4 visiting the Edersons first (2.4.1.3.4.1Ed).
When I got to 2.4.2.2, I was no longer offered the Edersons because the visitedAny functionality now works fine. Thanks!
But then, having played through HSA (2.4.3.1.1.1HSA) and come to 2.4.3.2, I was mistakenly offered the option of "Emi and Al Ederson". I had set this as follows:
notVisited 2.4.1.3.4.1Ed and notVisited 2.4.3.1.4.1Ed
In other words, I thought that players would only be offered the Ederson option if they had not visited the two previous Ederson pages.
Have I set this up wrongly? Perhaps I mean they should not be offered the Ederson option if they have notVisited either 2.4.1.3.4.1Ed or 2.4.3.1.4.1Ed.
I think we don't have the notVisitedAny functionality, so is there a workaround to this?

The combination of notVisited is also a problem at 2.4.4.1.3.3, for example, when the player sees two "Continue" buttons (they should only see one).

Notebook inputs and notebook page titles not matching

I don't know whether I have inputted the json files wrongly for some of the notebook entries. Can you tell me how the email I am required to send on 2.2.8 (in order to pageTransition into 2.2.9) is saved to the notebook? I thought I had set it up so that the email content would be saved to notebook under the entry "Notes on Hall (email to Moira)" (see 2.2.8/notebookEntry1). Instead, the imageComponent from 2.3.1.1 has been saved under the notebook entry "Notes on Hall". The email to Moira from 2.2.8, meanwhile, has been saved in two places: in the "Race and Face" Exercise entry, and also in the "Notes while locked up" entry. Have I inputted json wrongly or is there a bug here? (Some of the time, e.g. on 2.3.6, the functionality is working fine, ie the textComponent saves to Notebook in the right notebookEntry; the problem may just therefore be with email text inputs to the Notebook.)

Page transition not possible on 2.4.5.1.1.2

This happened to me in my testing on Friday at 2.4.5.1.1.2, and it happened to a player on Monday also on the same page (2.4.5.1.1.2): the "continue" button becomes invisible on this page, and there's no way to continue the game (going back to ".../games" and then clicking on "Continue" for existing games doesn't work).

Different font in Notebook for email response inputs

A question from the testers: is it possible for them to see in the notebook that an input they have generated by replying to an email is different to an input they have generated through a textExercise or "add new note"?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.