Comments (4)
@Blackbaud-BobbyEarl Yeah, I'm open to being convinced otherwise (perhaps there's some use case I hadn't considered), but the rationale for the current behavior is that
(a) it avoids the possibility of accidentally revealing private org memberships
(b) if the bot responds to your command, then it's going to be pretty obvious that you're a member of the relevant organization anyway, so what's the point of trying to keep your membership private.
Also, if you end up using Savage, I'd love to add your project to the users list in the README 😄
from savage.
Thanks for the quick reply and merge @cvrebert. I agree with your use-cases and think the current behavior is the way to go. We're using Savage and would be happy to have you add us to the users list.
https://github.com/blackbaud/skyux
The only change to implementation from the default is our use of BrowserStack instead of Sauce Labs. I've edited the source to change the comment that's added to a pull request to reflect that, but perhaps it would make sense to make that configurable.
Thanks for releasing Savage!
from savage.
I agree with your use-cases and think the current behavior is the way to go.
I'll close out this issue then.
I've edited the source to change the comment that's added to a pull request to reflect that, but perhaps it would make sense to make that configurable.
I would happily accept a pull request that added such a setting and used some lightweight templating system to generate the comment. Only reason I haven't done it myself is that it's pretty low on my priorities list.
Thanks for releasing Savage!
You're welcome. I hope it serves you well.
from savage.
We're using Savage and would be happy to have you add us to the users list.
Super! Added in 41cab0c.
from savage.
Related Issues (20)
- Have Savage also set GitHub build status HOT 10
- Add relevant CONTRIBUTING link to GitHub comments
- Add option to serve robots.txt
- Upgrade egit-github version HOT 1
- Temp branches should be deleted after some max timeout has elapsed
- Include SHA in branch name to avoid failures when user force pushes
- Eclipse egit-github => jcabi-github HOT 6
- Document health check endpoint
- jcabi-github inefficiency HOT 4
- Timeout GitHub API requests
- Local conflicts causing tests to hang HOT 2
- Add setting for list of trusted base branches instead of hardcoding `master`
- Ignore exception when deleting nonexistent .git/refs/remotes
- Allow members to bypass whitelist HOT 1
- Stop making closed-world assumption for pull request actions HOT 1
- Investigate possibility of using a bare git repo
- Switch to Travis's new authentication/integrity check scheme HOT 10
- Migrate from Spray to Akka HTTP
- Update to Scala 2.12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from savage.