Coder Social home page Coder Social logo

Comments (4)

cvrebert avatar cvrebert commented on May 3, 2024

@Blackbaud-BobbyEarl Yeah, I'm open to being convinced otherwise (perhaps there's some use case I hadn't considered), but the rationale for the current behavior is that
(a) it avoids the possibility of accidentally revealing private org memberships
(b) if the bot responds to your command, then it's going to be pretty obvious that you're a member of the relevant organization anyway, so what's the point of trying to keep your membership private.

Also, if you end up using Savage, I'd love to add your project to the users list in the README 😄

from savage.

Blackbaud-BobbyEarl avatar Blackbaud-BobbyEarl commented on May 3, 2024

Thanks for the quick reply and merge @cvrebert. I agree with your use-cases and think the current behavior is the way to go. We're using Savage and would be happy to have you add us to the users list.

https://github.com/blackbaud/skyux

The only change to implementation from the default is our use of BrowserStack instead of Sauce Labs. I've edited the source to change the comment that's added to a pull request to reflect that, but perhaps it would make sense to make that configurable.

Thanks for releasing Savage!

from savage.

cvrebert avatar cvrebert commented on May 3, 2024

I agree with your use-cases and think the current behavior is the way to go.

I'll close out this issue then.

I've edited the source to change the comment that's added to a pull request to reflect that, but perhaps it would make sense to make that configurable.

I would happily accept a pull request that added such a setting and used some lightweight templating system to generate the comment. Only reason I haven't done it myself is that it's pretty low on my priorities list.

Thanks for releasing Savage!

You're welcome. I hope it serves you well.

from savage.

cvrebert avatar cvrebert commented on May 3, 2024

We're using Savage and would be happy to have you add us to the users list.

Super! Added in 41cab0c.

from savage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.