Comments (10)
I haven't worked with Scala before, would you be interested in having me give this a shot though? It seems similar to Java which isn't bad. based on twbs/rorschach 's code
from savage.
If you want to, I won't stop you. Should basically involve calling this method: https://github.com/eclipse/egit-github/blob/master/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java#L403
from savage.
OK. Thanks @cvrebert. I just wanted to check as I've had some people / projects who aren't interested and were rather mean when someone new to a language attempted a PR. Just want to help not be a bother
Just for notes for myself, the function requires:
IRepositoryIdProvider repository = 'twbs/bootstrap';
String sha = 'pull request\'s SHA value'
CommitStatus status = ['Pending', 'Failed', 'Success']
from savage.
This is currently soft-blocked on https://git.eclipse.org/r/#/c/43131/ https://git.eclipse.org/r/#/c/35771/
i.e. I will still accept PRs, but redeployment of @twbs-savage will be blocked on Savage being able to set a proper context
on the commit status.
from savage.
With much thanks to Matthias Sohn, the blocker has now shifted to https://bugs.eclipse.org/bugs/show_bug.cgi?id=454237
from savage.
@kkirsche I landed an implementation of this on master
. Thanks as always for your enthusiasm though; gave me the kick in the butt to actually get around to doing this
from savage.
Thanks to http://dev.eclipse.org/mhonarc/lists/egit-dev/msg03810.html / ddbf069, this should now be unblocked.
We can just use a 4.0.0-SNAPSHOT
version of egit-github from Eclipse's Maven repo.
from savage.
Haha no worries. You were probably going to make a better quality version than my first pass simply due to familiarity with the codebase. I'm always happy to help though and I always appreciate the twbs's kindness during reviews.
from savage.
Currently in final phase of production testing: twbs/bootstrap#16352
from savage.
Test was successful!
from savage.
Related Issues (20)
- Add relevant CONTRIBUTING link to GitHub comments
- Add option to serve robots.txt
- Upgrade egit-github version HOT 1
- Temp branches should be deleted after some max timeout has elapsed
- Include SHA in branch name to avoid failures when user force pushes
- Eclipse egit-github => jcabi-github HOT 6
- Document health check endpoint
- jcabi-github inefficiency HOT 4
- Timeout GitHub API requests
- Local conflicts causing tests to hang HOT 2
- Add setting for list of trusted base branches instead of hardcoding `master`
- Ignore exception when deleting nonexistent .git/refs/remotes
- Retry requires user to be public member of trusted organization HOT 4
- Allow members to bypass whitelist HOT 1
- Stop making closed-world assumption for pull request actions HOT 1
- Investigate possibility of using a bare git repo
- Switch to Travis's new authentication/integrity check scheme HOT 10
- Migrate from Spray to Akka HTTP
- Update to Scala 2.12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from savage.