turagalab / malis Goto Github PK

After 'pip install malis', see:
malis/malis_cpp.cpp(4): fatal error C1083: Cannot open include file: 'boost/pending/disjoint_sets.hpp': No such file or directory

Numpy 1.12 dropped support for indexing with floats: https://docs.scipy.org/doc/numpy-1.12.0/release.html#deprecationwarning-to-error

I think malis does this in seg_to_affgraph... I'll provide more details later

So the build process goes ok. I'm sure you will work on this more. I just wanted to point out that as you are assuming numpy is installed, which seem reasonable, you could add include_dirs = [np.get_include()] to setup and this will make sure it picks up numpy from the right location.

The latest release is from 2016 and new commits were added since then. Are there plans for a release (both git tag and PyPI) anytime soon?

SciPy had breaking changes (without increasing the major version!!!) and previously deprecated aliases from scipy.misc were removed:

>>> import malis
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hanslovskyp/my-experiment/0/conda-env/lib/python3.6/site-packages/malis/__init__.py", line 1, in <module>
    from .malis import *
  File "malis/malis.pyx", line 3, in init malis.malis
ImportError: cannot import name comb

Two possible solutions:

1. Update all affected import statements and set minimum version requirement for scipy dependency
2. Set upper bound for scipy dependency

I think (1) is a better solution. I currently do not have the time for a PR (maybe in three weeks), but this could be helpful for others who observe the same issue.

It would be nice for getting this into conda if we could have an official release of this package on PyPI. I would be happy to walk you through what needs to be done for this. Will probably need to do some more cleanup of the setup.py file first.