tradingticket / tradeitiosticketsdk2

TradeIt iOS SDK to integrate trading and portfolio management.

TradeIt iOS Ticket SDK

Read the docs to get started!

tradeitiosticketsdk2's Issues

Need a completion handler for API TradeItLauncher.launchTrading

Or how would I know the result after calling TradeItLauncher.launchTrading?
Previously, I was getting a completion handler with TradeItTicketControllerResult.
This is super important to know if the trade is being placed or not so I can communicate with the user.

Popup needs to be centered

Please make sure that all the popups are centered and not covering the original button text.
Low priority.

API needs to be objective C compatible

For example, the API in TradeItOrder

public func preview(onSuccess: @escaping (TradeItPreviewTradeResult, @escaping TradeItPlaceOrderHandlers) -> Void,
                       onFailure: @escaping (TradeItErrorResult) -> Void

Give this error while writing ObjC code:-

Also, for this API

[TradeItSDK configureWithApiKey:PUBLISHER_NAME environment:TradeItEmsProductionEnv];

Please make sure NOT to set a default value for the parameter, otherwise, I am getting this error:-

"SymbolClass" type in Position Service

symbolClass : BUY_WRITES, CASH, COMBO, EQUITY_OR_ETF, FIXED_INCOME, FUTURE, FX, MULTILEG, MUTUAL_FUNDS, OPTION, SPREADS, UNKNOWN.

Is it possible to know the exact value as Equity or ETF. But, its combined value.

Bundle contains large size images

By inspecting an IPA of our product the TradItIosSDK has the largest size from all frameworks we link you our project. I found that the bundle contains few PNG that has over 100KB (one of them even 0.5MB). I believe it is not necessary to have them that large.

Objective-C compatibility...

The public APIs needs to be Obj-C ready, for example:-
open func launchTrading(fromViewController viewController: UIViewController, withOrder order: TradeItOrder = TradeItOrder())

Dummy broker not working

When attempting to connect a Dummy account, I get this error message:

Trading and Account Information with Dummy has been momentarily paused as we upgrade our connection. Please check back soon.

Updating the pod spec for SDK 1.1?

I can't get the latest using pod update.
Thanks,

Options formatting is wrong while syncing

Options ticker shouldn't have any spaces in them, please remove the spaces so we can parse them properly.
This is ASAP please.

TradeItPortfolioPosition architecture

It doesn't look good to have two objects inside this position, one for forex and one for equity! Why not have one base portfolio position (TradeItPortfolioPosition) and then have forex (TradeItPortfolioFXPosition) and equity (TradeItPortfolioEquityPosition) derived from it. The caller will then check the type if needed and it will be simpler code.

Please upgrade GoogleMobileAds framework to latest

There is a copy of this framework inside TradeItIosAdAdapterSDK.
Thanks,

A big jerky jump when you tap on an account in the Trade view

After launchTradingFromViewController and if you tap on an account to change the current account, you will see the accounts in a table view then there is a jump to accommodate for the header of the table. It seems something happened inside viewDidAppear() but it should be inside viewWillAppear. Please make the transition smooth.

Need API to select an account given a viewcontroller

Not iPad friendly and can cause apps to be rejected

Dummy broker name same for "Dummy and DummyMultiple" account

Broker name for the Dummy and DummyMultiple account is same as "Dummy". Will be helpful, If the name is different. So, that we can use it as different broker account.

Cant run the example project.

Tried to run the given example app project, but not able. Facing multiple error regarding missing framework like promiseKit, MBProgressHUD, SwiftyUserDefaults . Can you guide me, what are the setup need to do?
Thanks

In TradeItAccountOverview, missing margin cash

Many brokers, like TD and Robinhood, have margin cash, it is an important field to give the overall view of the account total value.
I remember this field was added but I can't see it in the new SDK.
Thanks,

disclose icon is beyond ugly!

Properties need review

Most properties are written as @property (nullable) Type *thing. This means that the default atomic keyword is implied. So, every property has a thread synchronization lock included. That’s a lot of unneeded overhead for a UI Framework where everything is expected to be used by a single thread.

Atomic properties are a farce anyway. If you are setting one property on thread A and another property on thread B, it’s almost guaranteed to create bugs as the property values can get out of sync. IMO is vastly preferable to state that the classes are explicitly not thread safe, unless you actually intend for them to be (which is a lot of work to do correctly).

Continuous Integration

• Add some CI to this repo like TravisCI or CircleCI to validate specs are passing on each PR
• Currently, specs aren't passing on the swift4 branch

Margins need some love

Add a CHANGELOG file

It would be quite nice to have a single place to look at general changes for each version.

What is the equivalent new API to the old one [[TTSDKUtils sharedUtils] isOnboarding]

Thanks,

Select Your Broker text size...

If the size is big, it looks like this. We need to make sure to test all the UI with extreme font settings.
Thanks,

When changing the text size of the device, things are messed up

If you change the text side under Settings app > Accessibility > Text Font, you will see this artifact in the layout. We need to have a consistent layout even if the text size changes by the user.

iPad rotation can cause the app to be rejected

When displaying launchAccountSelectionFromViewController buying power is N/A

Sometimes it display something but other times it doesn't

UIWebView is deprecated, need to be replaced soon

Hi, Apple has announced that new apps using UIWebView will no longer be accepted to the App Store in April 2020, and existing apps using UIWebView will no longer be allowed to update starting December 2020. Apple Announcement

Can you please work on this issue as it is urgent.
Thank you,

Need API to get the positions of a certain portfolio using the sessions

This is needed for clients who integrated the SDK UI. Before, there was a call like this:-

- [TradeItTicketController getSessions: self withApiKey:@"tradeit-test-api-key"
    onCompletion:^(NSArray *sessions) {
    NSDictionary \* firstSession = [sessions objectAtIndex: 0];
    NSString \* sessionToken = [firstSession valueForKey:@"token"];
    NSString \* accountNumber = [firstSession valueForKey:@"accountNumber"];

//use sessionToken with anything here:  https://www.trade.it/documentation/api
//or to use with the existing services in the library

TradeItConnector * myConnector = [[TradeItConnector alloc] initWithApiKey: @"tradeit-test-api-key"];

TradeItSession * mySession = [[TradeItSession alloc] initWithConnector: myConnector];
mySession.token = sessionToken;

TradeItGetPositionsRequest * positionRequest = [[TradeItGetPositionsRequest alloc] initWithAccountNumber:accountNumber];

TradeItPositionService * positionRequester = [[TradeItPositionService alloc] initWithSession: mySession];

[positionRequester getAccountPositions: positionRequest withCompletionBlock:^(TradeItResult * result) {
     //update UI with position data
}]; 
}];

Title of TD broker is wrong

Please make sure that it is TD, also check all the other brokers.
Low priority.

Thanks,

Missing nullability specifiers all over the place

These generate compiler warnings for the framework, and since the public headers are included client apps, the warnings cascade to the clients. It’s very very annoying if your team (responsibly) uses “Treat warnings as errors”.

API TradeItSDK.launcher.launchAccountSelection needs prepopulated account

In order to allow users to change what they sync (from one account to another), we need to display the selection controller with an already selected account if any.
I identify the accounts by accountNumber in my data model.

Also, the cells need to have a checkmark accessory UITableViewCellAccessoryCheckmark, not the current UITableViewCellAccessoryDisclosureIndicator.

Title of the Select account to sync is not visible...

Xcode 9 Archive Error

Builds and runs with Xcode 9, but when attempting to archive, I get the error “command failed due to signal: abort trap: 6”.

XCode 9 compilation

Seems there are many errors while compiling using Xcode 9.
When do you think we can have those issues fixed?
Thanks,