thiaudiott / hoi4-presence

Hearts of Iron IV presence for Discord!

> My name's Thiago

「 A fullstack developer 」

“Specialization is for insects.”

λ

hoi4-presence's Issues

Refactor issue template of bugs

Adds more information to the end user.

Is 'in menus' a good title, when starting the game? I think not

hoi4-presence/src/discordRPC/hoi4RPC.py

Line 21 in bd92a27

details="In menus...",

I think it should be "Playing hoi4" or something.

Maybe a good idea is to add some intelligence and display other things as well.

It doesn't need to be "autosave.hoi4"

In: https://github.com/ThiaudioTT/hoi4-presence/blob/main/src/discordRPC/main.py#L32

Does not need to be autosave.hoi4, it can be whatever the name is, just search for a recent file in that Dir.

[FEATURE] Implement auto-update

Discuss and implement how to automatically update the script.

Issue on launch

Game launches fine, however error messages appear and appears to be accessing wrong file-path, user profile is not called User? (e.g. "Users/User/etc." should be "Users/actualusername/etc."

[BUG] - No module named psutil

Describe the bug
When executing hoi4rpc it says it

To Reproduce
Steps to reproduce the behavior:
Execute hoi4rpc.exe

Solution:

Adds psutil to requirements.txt

https://stackoverflow.com/questions/50316358/error-no-module-named-psutil

The github actions doesnt have it, so it is building wrong.

Create an "all in one" file

This will help with the release packages. Make a CMAKE/Makefile using batch, or something, to compile all the files in one folder.

Adds more time when getting errors

When I get some error, the program exit it without any warning in some cases.

We need to find when and where this occurs and adds a time.sleep(10) (or other thing) to let the user know that we get an error.

Improve documentation

Create an /docs folder and add documentations there OR

Elaborate repository Wiki.

Bug: checkupdate not working when started by batch

It gives an error and then, exit.

Change checkupdate and add exceptions with time.sleep.

Check if the paths in installer are all valid

Add checking if paths in installer are all valids.

If it isn't valid, ask the user to enter the path again.

Obs:
Checking if the path is valid isn't enough, we already do it. Check if the path contains the game and the others resources that the presence uses (if any) and asks the user until we find a real valid path.

Check update

Write a program to check if updates are available.

This could help:

https://pypi.org/project/update-check/

https://stackoverflow.com/questions/12842693/python-check-for-updates-for-a-program

https://stackoverflow.com/questions/72191474/how-to-update-software-made-with-python

version.json

{
    "version": "0.1.0",
    "auto-update": false
}

You can auto-update using HTTP or requesting the user to do it.

[BUG] - Can't change launcher-settings.json | 'charmap' codec can't decode byte 0x90 in position 792: character maps to <undefined>

We are having trouble when installing the presence with the new update 1.14.4.3.

We can't change the launcher-settings.json, this causes the presence to not update.
Error:

'charmap' codec can't decode byte 0x90 in position 792: character maps to <undefined>

Possibly related: #36

Line in code:

hoi4-presence/src/setup.py

Line 193 in bd92a27

print("Changing launcher-settings.json...")

Temporary solution

Change exePath in launcher-settings.json to:

"exePath": "./runRPC.bat",

Add more countries

Currently, the presence works perfectly only with the "main" countries.

Add all the others countries, as well their flags, use discord developer portal to see if the images are good.

Complete "how the presence works"

Finish the documentation...

[BUG] - Checkupdate isn't working

Describe the bug

I think checkupdate isn't working somehow

Refactor issue template of feature request

Adds more information to the end user.

[MOD] - Add support for Old World Blues (Fallout Mod)

It's one of the best mods in HOI4 and also one of the most played.

And also we have a wiki:

https://oldworldblues.wiki.gg/wiki/Nations

Uninstaller

Create an uninstaller to bring back the vanilla game.

See #2

Change file location in batchFile if setup.py installs in another folder

start "hoi4RPC.exe" "C:\Users\%USERNAME%\Documents\Paradox Interactive\Hearts of Iron IV\hoi4Presence\checkupdate.exe"

This drive name is fixed and needs to change like setup.py changes the installation.

We fix this issue making setup.py rewrite this line and making it point to the exact location.

Both for presence path and checkupdate path

CI/CD for the repo

We can create, somehow, a github workflow to build the exe files and release the packages. This would create a CI/CD and make the release more easier.

Solving this issue first would be better-> #9

Rename documents path

This text doesn't provide which documents path. The objective of this issue is to provide a way to better show what the documents path is.

It is something like:

C:\Users\$USER\OneDrive\Documentos\Paradox Interactive\Hearts of Iron IV

Set the large_image via web

We can set any image to large_image:

https://stackoverflow.com/questions/64417184/how-does-pypresence-work-where-do-i-get-the-image-key

Maybe we can upload the images on GitHub and use it as a source of flags instead of modifying in discord developer portal.

Create an installer

Create an setup.py that install all the files (batch and .exe and all with the dependencies) and configure the initialization automatically.