themekraft / _tk Goto Github PK

How I can transfer right side bar to the left?

Hi, when a page has second level pages underneath the top level page does not have an active link. The top level page is still accessible directly (if you know the url), but it is not an active link.

One or more errors were found for _tk.

REQUIRED:.sticky css class is needed in your theme css.
REQUIRED:.gallery-caption css class is needed in your theme css.
REQUIRED:.bypostauthor css class is needed in your theme css.
WARNING: Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme's correct slug and text-domain is _tk.
WARNING: Found wrong tag, remove nightshift from your style.css header.
WARNING: Found wrong tag, remove coffee from your style.css header.
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'You may use these HTML tags and attributes:'
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'Post Comment'
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'Leave a Reply'
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'Leave a Reply to %s'
WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'Cancel Reply'
WARNING: .project Hidden Files or Folders found.
RECOMMENDED: Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
RECOMMENDED: No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above.
INFO: Possible hard-coded links were found in the file footer.php.
Line 24: Underscores.me' ); ?>
INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is _tk

Hi @Ixiter,

I have found some wired behave in the bootstrap pagination you have implemented.
Please see the test site and play around. https://themekraft.com/tk-wordpress-bootstrap-starter-theme/

Click the pagination and the pagination comes two times...

Would be super great if you can look into this. Its your code and you will figure it out quite fast as I know you ;)

Cheers and Thanks,
Sven

I got this error when running PHP Code Sniffer on the theme code:

7 | ERROR | [ ] Package name "_tk" is not valid; consider "Tk" instead

"The default coding standard used by PHP_CodeSniffer is the PEAR coding standard."

Wondering if you could update your package name to follow the recommendations, also in use in phpDocumentor:
http://docs.phpdoc.org/references/phpdoc/tags/package.html

It was released on June 16, 2015.

From: Paul Solomon Subject: _tk theme bug report

Message Body:
Hi Guys,

I’m a huge fan of your _tk starter theme; thank you so much for making it available!

I recently found two issues with the theme’s bootstrap-wp-navwalker.php file.

When I edit WordPress menus from the admin area, I found that the “title” attribute value of links in the menu was always output as the “navigation label” value, rather than the “title attribute” value.

I also found that the glyphicon that wraps the tag anchor text was created with a separate class value for each word in the “title attribute” value, rather than a a single class with hyphen-separated “title attribute” value.

I made two changes to the bootstrap-wp-navwalker.php file which fixed this.

At around line 79, I removed this:
$atts['title'] = ! empty( $item->title ) ? strip_tags($item->title) : '';

and substituted this:
$atts['title'] = ! empty( $item->attr_title ) ? strip_tags($item->attr_title) : '';

That results in the correct title attribute being generated.

At around line 113, I removed this:
$item_output .= ' ';

And replaced it with this:
$item_output .= ' ';

That results in the proper class value being generated.

Hope that’s helpful!

• Paul

I'm building a new theme utilizing _tk starter and ran into a snag. I can't seem to get any glyphicons or font-awesome icons working. If I try glyphicons, say on a menu item in WP, it puts the span tag in and it look fine in code, however nothing actually shows up on the page. No errors or anything in Firefox console either.

However in looking at the style panel in Firefox I am NOT seeing any glyphicon::before showing up at all. I see .glyphicon, but not the psuedo element.

If I then try to use font-awesome I get some weird block character where the icon should be on the page, but not the actual icon. AND what's stranger is that when I try to use font-awesome I actually get console errors pointing to glyphicons files! Makes no sense to me.

When using FA, this is part of what I see in the error console (also see attached screenshots):

/wp-content/themes/renew-life-theme-2015_tk/includes/resources/bootstrap/fonts/bootstrap/glyphicons-halflings-regular.woff2

I'm doing this build locally (apache) so there's nothing you can see online. Any ideas on why this isn't working? I've used both of these before with no issues, but this is my first time using _tk.

I should also add that this is so far an untouched _tk theme so the issue isn't from my messing with the code.

You provide files for the French translation but there's a small error on the filenames :
fr-FR.mo & fr-FR.po instead of fr_FR

I'm having problem creating full width page template, since there's
<div id="content" class="main-content-inner col-sm-12 col-md-8"> in the header.php
Can you help me?

Issue:
Since a comment box uses the .media-body class, this class uses a width of 10000px in an attempt to size the panel-default. However, when a comment has a really long string (for example, a long URL), it causes the panel to break and the viewer can't see what is written past the container.

Suggested Correction:
v3.3.0 bootstrap has moved away from using .pull-left on a media object (such as a comment avatar) and now employs a .media-left and .media-right class (see: http://getbootstrap.com/components/#media). Please update the _tk_comment function to employ this new structure.

Hi,
I watched the php file and i removed the sidebar code but it still there.
How i can remove the sidebar?

I easly find it on single.php and page.php but not on the main page and category.

Thank you

I presume that the single post pages' "next" and "previous" links are supposed to float right and left, respectively, but in my version of _tk (v. 0.1) they do not. I have found a fix, however (I don't yet know how to do a pull request so I'll post it here). It involves the addition of bootstrap's "pull" classes, and some CSS to clear the floats.

on file template-tags.php change lines 43-49 to read as follows:

        <?php if ( get_next_posts_link() ) : ?>
        <div class="nav-previous pull-left"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', '_tk' ) ); ?></div>
        <?php endif; ?>

        <?php if ( get_previous_posts_link() ) : ?>
        <div class="nav-next pull-right"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', '_tk' ) ); ?></div>
        <?php endif; ?>

and then add some css:

div#comments {clear:both; padding-top:2em;}

Greetings

I'm a new user of this great theme and as a designer I'm interested in trying to customize every aspect of interface. I notices that pagination code is been included inside the "includes" folder that can't be overwritten in a child theme. Can you please remove pagination code from that folder so I can overwrite it in a simple child theme?
Thanks a lot

This is just a question and not an issue.

I want to customize bootstrap for use in a _tk child theme. Is it as simple as copying bootstrap files over the existing files I have already downloaded in _tk-master? Or have changes been made that would affect the theme?

Copy conversation from WordPress.org https://wordpress.org/support/topic/w3c-validator-errors-3?replies=3

I installed _TK on this website: http://bentovillage.me and it's subsite documentation: http://bentovillage.me/documentation and a few days later it came to me to check the W3C CSS validator, which finds 40 errors.
http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fbentovillage.me

I have visited your github, seen a pull request, some bug reports and I contributed to the translations to French (I could even finish them next… ).

My question are the following: do you still have interest in improving your _tk theme? If so, do you intend to fix the errors and provide an update in a near future?

Seems that you updated your theme or something. In wordpress I can see that is available a new theme update, but in the theme I can't find where it checks for updates...

How can I disable it?

Thank you.

I wasn't sure if this was the proper place to put this, so please correct me if it wasn't.

I love this theme, but every time I've used it, I've had to open the functions.php file and move the wp_enqueue_style( '_tk-style', get_stylesheet_uri() ); to a space below the bootstrap css inclusion.

Otherwise, if I want to override any boot strap styles I have to either be extra specific, or include !important after each change.

Including the theme css file after the bootstrap css file would make overriding the bootstrap styles easy and intuitive.

Hi Guys,

I may be blind but some time ago there was instruction how to customize theme name.

Something like "Search for: _tk and replace with: Megatherium" etc.

I cannot find it in _tk doc on GitHub.

Is it bug or feature?

Thanks
Krzysztof

This is not a issue but a suggestion.

Since WP allow this, the post pagination for me should be this way.
http://getbootstrap.com/components/#pagination

I saw that with version 1.2, the less files have been removed for bootstrap. Can we have them back please?
Thanks!

When you have a blog with a image aligned to the center, this works fine.
Text appears either above or below the image. And the'Posted in' and 'Tagged' appears under the image.

When you align the picture to the left or right, the next blog below it will start to wrap around the image, as well as the posted in and tags.

I simply put this into the css file.

.entry-meta {
clear: both;
}

Just might be something to consider for a future release.

I noticed when I put a caption on an image, the image is shrunk a bit. I compared with and without caption. The caption padding (between the outline and the image) is what's causing the shrink. Is there a way to make the whole image+caption grow wider whenever there is a caption so the image can stay the same size as without a caption? I like the padding the way it is, but it shouldn't shrink the image because of course that makes images lose sharpness.

Here is the source when I have a caption.

<div id="attachment_1197" style="width: 480px" class="wp-caption aligncenter"><img class="wp-image-1197 size-full" src="http://www.hikingmike.com/wp-content/uploads/2015/12/sawyer-mini-filling-bag-at-high-lake.jpg" alt="sawyer-mini-filling-bag-at-high-lake" width="470" height="332" /><p class="wp-caption-text">Preparing to squeeze the life-giving water out of High Lake</p></div>

I did poke around. I see that wp-caption has a padding of 10px. I reduced it to 0, and then image stayed the full size but the caption outline was goofy because it pressed against the left side of it but with padding on the right somehow. Argh.

If that outer div didn't have a width, then this probably wouldn't be a problem. But I guess that's what they use to make the actual outline around the image and caption.

Hi,
The theme look good but i find it miss a simple 4 columns widget enable footer to make it perfect.
oh, and may be a fixed top navigation header like most modern themes.

Hi,

I watch your theme in IE8 and it gives a default mobile view.
I know that IE8 had it's last days, but I experience that some customers still use it.

Is there a way to make it not default mobile view?

Reg.

Just a small question. Im quite new to bootstrap...and git :/ To be able to override bootstrap I made the style.css to be loaded last in functions.php so I can make the overrides there. It seems to work fine at a glance. Could this generate problems with bootstrap-wp.css and is there an easier way to make overrides to bootstrap without tempering with the compiled files? (btw _tk looks really good so far...)

function _tk_scripts() {

// load bootstrap css
wp_enqueue_style( '_tk-bootstrap', get_template_directory_uri() . '/includes/resources/bootstrap/css/bootstrap.min.css' );

// load bootstrap js
wp_enqueue_script('_tk-bootstrapjs', get_template_directory_uri().'/includes/resources/bootstrap/js/bootstrap.min.js', array('jquery') );

// load the glyphicons
wp_enqueue_style( '_tk-glyphicons', get_template_directory_uri() . '/includes/resources/glyphicons/css/bootstrap-glyphicons.css' );


//load theme style.css after Bootstrap to be able to make overrides without the measly !important ...
wp_enqueue_style( '_tk-style', get_stylesheet_uri() );

https://themes.trac.wordpress.org/ticket/21629#comment:25

1. Headings: Headings should be clearly hierarchical, so that no level of heading is skipped. In this case, the widget headings are H3 with no parent-level heading, and the post headings are at the same hierarchy level as the site title. I'd recommend moving post titles down to H2 and move widget titles up to H2 as the simplest change; but the important thing is that the hierarchy is clear. I suggest using the Firefox Add-on "HeadingsMap" to view the headings hierarchy of your page. Use the standard headings mode in the add-on, not the experimental HTML5 mode.
2. ARIA Landmark Roles: Fails. All areas of the page need to be wrapped in ARIA landmark roles if any roles are used.
   Add: navigation role to main menu.
   Add: main role to main content area
   Add: complementary role to sidebar
3. Link Text: the "Continue Reading" link needs to include the text of the post title. It can be hidden using a screen-reader-text class, but must be available for screen readers to use.
4. Controls: All forms should have submit buttons; these don't need to be visible, but must be available for screen reader users to activate. You're using display: none to hide the search form submit button; you should use a screen-reader-text class to hide this.
5. Keyboard Navigation: Good to go. Visible focus appears to be effective in all cases.
6. Color Contrast: Almost all good - the link color in comment author meta boxes gives a contrast ratio of 4.18:1, which is only valid for large text. Large text is defined as anything 18pt equivalent or larger or 14pt bold or larger; the text in question is 14px, but not bold. You can either darken the text slightly, lighten the background, or change the font size.
7. Skip links: There is no skip link. You must have a skip link at the very beginning of the body that grants a user quick access via keyboard to the main content of the page. The skip link must become visible when it receives keyboard focus.
8. Forms: All forms must have explicit labels. Your comment textarea does not have a label, and the widget search element has a label but no labeling text, which is the same as having no label.
9. Images: No image or icon fonts found; looks fine. Featured images include alt attributes.
10. Media. Not present by default.
11. Not allowed: You may not open links in new windows without warning the user. Your credit link must either not use target="_blank" or it must notify the user that it will open in a new window.

I was updating my local modified copy of your theme (need to make a fork soon) to include some common changes that I make, and remembered this one:

The document.write("<style>body{display:none;}</style>"); in include/js/bootstrap-wp.js is hiding elements on the page, which had been causing jQuery calls to get element height / width to fail when the page doesn't load quickly enough. Even wrapping the calls in jQuery( document ).ready( function( $ ) {}); didn't work consistently for me.

It was especially apparent when I started using backstretch (http://srobbin.com/jquery-plugins/backstretch/) for a project a few months ago. Occasionally the page would load fast enough for backstretch to be able to get the proper height and width, other times not and the image would be squished or not visible at all.

After a good long trial / error search, I found the above line causing the issue.

I'm sure this is an edge case, so I'm not sure it needs to be changed, but thought I'd mention it here in hopes that it could save others a little time.

I think you copied the "Getting Started" section from the _s repository but just changed it to say _tk. underscores.me can't generate the _tk theme.

The only option is to perform all the find/replace actions in the _tk theme itself.

Readme says: “head over to http://underscores.me and generate your _tk based theme from there. You just input the name of the theme you want to create, click the "Generate" button, and you get your ready-to-awesomize starter theme.”

But underscores.me generates nothing with bootstrap. What's wrong?

There are 2 echos in _tk/includes/custom-header.php on line 76 -
color: #;
This gives parse error while activating the theme. Please correct it

Hier noch einmal aufgelistet:

1. "Leave a Reply"
2. "Leave a Reply to %s"
3. "Cancel Reply"
4. "Post Comment"
5. "You may use these <abbr title="HyperText Markup Language">HTML tags and attributes:"

I went to update a site I built in _tk to wp 4.6 the other day and saw _tk had an "update " available.

When I set that site up I foolishly bought your idea that I didn't need a child theme (now slapping myself awake). So no there is no way I can go from _tk version "0" to any other number without blowing the entire site away.

So here's my question: Do you have a _tk child theme that calls all the css files - in arrays perhaps?

I tried to enable Infinite Scrolling, by uncommenting the appropriate lines in style.css, but then with the Jetpack feature enabled, the infinite scrolling never occurred. I'm using _tk version 1.1.1 on Wordpress 3.8 with Jetpack version 2.7

Can anyone else confirm this?

One thing that was unclear in the comments was "You can enable this cool feature by simply decommenting the lines below and make sure you use the same classes on the right place in your html."

What are those classes, and shouldn't they be in use by the theme already?

I like this starter theme very much but I think there are some issues that developer should update immediately .

1. add_theme_support( 'title-tag' ) still not added in functions.php . Still _tk theme follow the old strategy, means in header.php title tag function .
2. A standard theme should have a fullpage template but unfortunately _tk theme hasn't this expected structure . As I saw a topic related full page structure at #16 but there was no proper solution .
3. Screenshot size should be 1200x900, as preferred by WordPress new rule .
4. Comment form input fields under comment box, it should be style in bootstrap . Check the screenshot.

Is there any chance you'll be updating this for the latest underscores release? If not... maybe some advice on how I can do it?

I'm wanting to work from LESS files, but I'm only seeing the CSS files. Is there any plan to provide the LESS files for the additional styles used in the theme? Recompiling using Bootstrap's LESS files results in the navbar disappearing.

Released today: http://blog.getbootstrap.com/2015/11/24/bootstrap-3-3-6-released/

I did set up everything properly, but not sure why themes dropdown not working. I didn't get any error in console. Tested browser was Google Chrome 31.0.1650.63 Ubuntu 12.04 (31.0.1650.63-0ubuntu0.12.04.1~20131204.1)

Correct me if I'm wrong, but one of the main points of underscores is that it is "a theme meant for hacking so don't use me as a Parent Theme."

_tk turning into a Parent Theme greatly changes the entire concept of what _tk was for orginanlly, at least as I thought. I thought this was a starter theme for building our own theme on top of.

Now it says that you want us to build a child and that you will send theme updates... : (

Did you know that the link on https://themekraft.com/tk-wordpress-bootstrap-starter-theme/ to this GitHub repo doesn't work well? It wants to go to https://themekraft.com/tk-wordpress-bootstrap-starter-theme/goto/https://github.com/Themekraft/_tk and then just returns to https://themekraft.com/tk-wordpress-bootstrap-starter-theme/

Thought you should know.

Hi, all!
Please pardon me if this is a silly question - I, like the last poster, am also relatively new to Bootstrap and Git.

So far, I'm really enjoying your theme, as it's really affording me a lot of mobile flexibility while retaining the WP CMS we rely on here. The main issue I'm battling with is my menu. It's too big. I read a bunch of posts about editing breakpoints in Bootstrap 3.0, but they all refer to .less files that don't seem to be in my version of _tk. Should they be? If not, how can I go about making sure my menu collapses at a wider breakpoint than it does right now? It's currently set to collapse at 768px, and I really can't go any less than 1200px without ending up with my menu on two rows :/

Any suggestions you can give me will be greatly appreciated! Thanks again for such a great theme :)

Tom.

Hi,

header.php is missing a comma on line 76, 'container_id' => 'navbar-collapse'

Cheers, Mark

https://themes.trac.wordpress.org/ticket/23280#comment:3

Hi,
I see that page are called differently that i use to see usually.

How can i create a custom page?

I tryed to create a page starting this way and i can see it in my select option in a new page but the render is broken.

`
/**

• @Package _tk
• Template Name: Fullwidth
  */
  `

The most important one-and-only big "download me at github" button haz wrong url:
https://themekraft.com/tk-wordpress-bootstrap-starter-theme/goto/https://github.com/Themekraft/_tk

well, as you see, i still found it, however, might be worth to change that.

style.css, Line 81 - duplicate border declaration.

.wp-caption {
border: 1px solid #ccc;
margin-bottom: 10px;
max-width: 100%;
border: 1px solid #ccc;
border-radius: 4px;
padding: 0 10px;
}

Line 76 in header.php is missing a comma, which breaks the theme.

Many of the organizational options in wp-bootstrap-navwalker are available until a manual update is performed. Current version enforces BS3's 2 level limit on navigation, but adds options to better organize dropdowns.