Coder Social home page Coder Social logo

Navwalker Fix about _tk HOT 3 OPEN

themekraft avatar themekraft commented on August 15, 2024
Navwalker Fix

from _tk.

Comments (3)

hommealone avatar hommealone commented on August 15, 2024

Thanks for opening this bug report for me. Some of the code never made it into this issue.

At around line 113, I removed this:
$item_output .= '<a'. $attributes .'><span class="glyphicon ' . str_replace(" ","-",strtolower(esc_attr( $item->title ))) . '"></span>&nbsp;';

Replace that with this:
$item_output .= '<a'. $attributes .'><span class="glyphicon ' . strtolower( str_replace( ' ', '-', esc_attr($item->attr_title) ) ) . '"></span>&nbsp;';

from _tk.

hommealone avatar hommealone commented on August 15, 2024

Without these changes, I find that every menu item gets a title tag, and the title tag is always equal to the anchor text. This is pointless (right?) and the resulting tooltips often obscure the menu or make navigation more confusing. With these changes, the "title" field in the menu editor GUI is actual usable, and the editor has the option to leave it blank if they do not want a link title tooltip.

from _tk.

konradsroka avatar konradsroka commented on August 15, 2024

thanks mate, we'll check this for the next update, sorry we do not have an ETA for this right now though

from _tk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.