Comments (6)
Yeah ill have to rework this
I just commented it out for now
from tximport.
Moving forward I may be able to help simplify this. The reason for the (somewhat tortured) structure of the output (e.g. effective lengths being in a separate file) was to maintain backward compatibility with prior versions of Sailfish & Salmon. However, if it would be helpful here (and / or in other contexts), starting in the next release I'd be willing to break backward compatibility of the output format and put the effective length (and any other useful information) directly into the quant.sf
file. Also, I think it might be useful to remove the comment character #
in front of the line that names the columns so that they can be read in more easily with the typical tools (e.g. read.table
and pandas.read_table
). The default could then be to read the effective lengths directly from the quant.sf
file and fallback to this strategy if e.g. the input is from an older version of Sailfish or Salmon. Thoughts?
from tximport.
+1 for both of those suggestions.
from tximport.
+1 for both as well.
Simplifying here will help me with something else i want to do, which is make it easy for users to swap in readr::read_table which is 50x faster
from tximport.
I was also going to suggest readr. Faster, no stringsAsFactors, tbl_df goodness, etc.
from tximport.
I think we're set here. Rather than go looking for stats.tsv, the effective length will be in the quant.sf file for future versions of Sailfish/Salmon, and tximport will now autodetect if its a old or new version.
from tximport.
Related Issues (20)
- Outdated vignette? HOT 1
- Move Alevin import code to C++ HOT 3
- Missing release tags HOT 1
- Add option to import only whitelisted barcodes from alevin HOT 2
- ignoreAfterBar does not apply with txOut=T and countsFromAbundance != "no" HOT 1
- lose transcript names for salmon inferential replicates
- `ignoreAfterBar` not used if `txOut=TRUE` HOT 5
- cann't import kallisto abundance.h5/.tsv HOT 4
- Import processed data HOT 3
- Recomended count scaling method for DTU analysis HOT 2
- Returns TPM when abundanceCol is set to any value for type='rsem' HOT 1
- Read in files in parallel HOT 4
- Tximport issue with new R version HOT 2
- Which measure to use for gene Fold change analysis between pre- and post-treatment samples and for gene comparison within a sample HOT 1
- error in 1:nrow(m): argument of length 0 HOT 1
- import using tximport for the rsem count table to get integers? HOT 3
- Dealing with multispecies using tximport HOT 4
- Different length and counts depending on the number of loaded samples HOT 1
- tximport of feature counts? HOT 1
- tximport of kallisto h5s generated with multiple threads is not deterministic HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tximport.