tgstation / terragov-marine-corps

TGMC: TerraGov Marine Corps, a SS13 mod

TerraGov Marine Corps 

Licensing

This fork is based on the July 2018 version of ColonialMarines .

Contributions, if not otherwise specified,
are licensed under the AGPL license.

Asset Type	Source	License
Artwork	Everything After #92ee94d
Sprites	#367 ( #36b8db4 )
Sprites	#d407e97
Sounds	#5261 #5861
Icons	#6010
Rouny Sprites	#6938
Sounds	#5604 from FreeSound.org
TGS DMAPI

terragov-marine-corps's Issues

You cannot break limbs because config file is wrong

organ_health_multiplier is equal to 100; delimb is calculated as
if(CONFIG_GET(flag/limbs_can_break) && brute_dam >= max_damage * CONFIG_GET(number/organ_health_multiplier))
This means you need to deal about 3000 damage to the legs for a chance to break it

Pulled larva can't get up

When pulled larva cant stand up Rest state to normal state

mini railscope sets an accuracy malus when unscoping which it doesn't have before scoping

before scoping in accuracy_mod is 0; after scoping in it's +0.05; after unscoping it becomes -0.05

SERIOUS IMBALANCE with re-nesting Deifler abulity "Defile"

It was a 3+ year ago problem
When aliens re-nest marines then use Defile ability, then put infected marines back to nest.
MAKING "Ashamed, you reconsider bullying the poor, nested host with your stinger." USELESS

Must have to remove a way to defile nested hosts.

Hide under ARES computer using Rest.

Drone sprite.

help fling doesn't work properly

admongs did some thunderdome testing, the help/disarm/grab fling only flings the target if there is a wall directly behind you, which throws them into/through the wall. It doesn't work if you're flinging them into an empty area.

Unable to save Character changes

Testmerges:

Commander TGMCBOT Today at 7:45 PM (01-29-2019) CST/GMT-6
#283 #214 #277 #123

Reproduction:

I've luckily had my character look all set, but some things keep reverting between rounds. Namely: Marine role preferences, Occupation Choices: Xenomorph, and UI Customization Alpha.

Pressing the Save slot button doesn't save, and having the round end normally doesn't save either.

Ammo boxes can't be refilled with the new extended SMG mags

Yet another thing I coded poorly and will have to fix. FeelsBadMan.

When distress fails to iterate through the list of valid calls with prob() it picks from ALL calls

Tank fabricator lists both fixed and broken parts to be printed.

@spookydonut

smg sprite invisible

both weilded and unwielded
(one handed and two handed)

Crushers / Tanks cant crush Operating Table cant crush crates

And many other crushable items.

RPG fires when trying to point to something

Reproduction:

try to point to someone or something and watch it shoot the RPG (shift middlemousebutton)

If a queen dies, new larvas cannot evolve into a drone.

Geothermal Generator on Ice Colony in T-Comms

The T-comm generator (topmost one) does not have wires under it to distribute the power it makes.

Water makes objects impossible to click

Dual wield Laser + smg 2-handed (with any weapon, claymores etc)

1

2

Improperly uncommented chem reaction

e19d5e6 left some dirty code:
https://github.com/tgstation/TerraGov-Marine-Corps/blob/master/code/modules/reagents/chemistry_reactions/other.dm#L84

Xeno distress spawns empty ones

TRENCH WARFARE.

Hitting Unique-action while carrying a deployed Entrenching Tool or just a simple shovel lets you dig a hole in that tile.

The benefits from that tiny hole are :

• Dodge general ground explosions if you rest (we're talking CAS, OB, Mortar, HEDP grenades), but only if they don't hit your dugout tile directly (nade) or cover your dugout tile in their radius (OB, CAS, Mortar)
• Be able to dodge normal ground level shots unless the shooter is clicking directly at your sprite.
• Climb up to normal ground level with a 1-second windup (like you would climb on a table). And just like tables, if you're on ground level, you can just walk over to the trench tile to plop down
• Dodge abilities if they're not clicking directly on your sprite
• Throw a primed nade into the hole to pretty much remove its explosion radius, and it'll only hurt whoever is at the center then.
• Shoot people normally without any restriction, if there aren't barricades blocking
• You can reinforce your trench with sandbags to prevent it from collapsing from explosion/burrower tunneling

The bad sides of that tiny hole are :

• Xeno will still able to use most of their abilities on you normally, with slashes having more RNG chance to hit your head
• Gas on ground level will still be able to spread into your dugout hole and do the big hurt
• You can't shoot through barricades while in the dugout hole
• Objects in the dugout hole will have a windup to be dragged onto a ground level tile (like moving a human onto a window frame with aggressive hold, but without the grab upgrading shtick)
• Explosions in the trench will make the tiles in the blast radius collapse (trapping the marine inside and dealing oxygen damage until the tile is dug out again), and Burrower can tunnel into a dugout tile to also make it collapse. To prevent this, reinforce your trench tile with 5 sandbags.

You can connect multiple holes with each other, and make a real trench if you wish. Just keep diggin' soldier.

Cant pick up ship weapons whit the riply and the ship doesnt recognise installed stuff

i cant pick up ship weapons whit the riply but i can pick up modules and the sentry turrets but the ship doesnt recognise the turrets

Pyro spec can get set on fire.

Reproduction:

Make a fully armored pyro spec walk into a fire.

Scan Report Shows in lobby

pretty much what the title says

Repairing window frames deletes the frame

Repairing broken window frames with Reinforced glass deletes the frames, likely failing to spawn a repaired one.

Ice Cups are hilariously lethal and not logged

Want to kill someone silently without any admins knowing? just use ice cups, available from any hot drink vendor after pulsing the contraband wire, and watch as after only a few sips marines start dying from drinking LITERAL FUCKING ICE. This silent kill method is completely unlogged and will allow you to grief afk people as you see fit.

Fix this pretty please.

*mirror'd from old repo

Teleported buckled people (such as with the admin verb or to the EORD arena) will keep them buckled.

As per title.

running into a corgi as a xeno moves you two tiles

🤔

Having about 10 or more rage will always make second wind have no cooldown

equation
second_wind_delay = world.time + (RAV_SECOND_WIND_COOLDOWN * round(1 - current_rage * 0.015) )

Im assuming that the round(1 - current_rage * 0.015) is making the 1 into a negative number then multiplying it, making it a massively less cooldown or refreshed instantly
would be fixed by making it
second_wind_delay = world.time + (RAV_SECOND_WIND_COOLDOWN * round(1 - (current_rage * 0.015)) )

Detailed Bioscan Information shows tile name instead of area name.

https://puu.sh/Cee4Y/4c793acd4c.png

Medevac stretchers copy themselves instead of folding when dragged into you

Instead of folding up like someone would expect from a stretcher, you get a neat new folded stretcher in your hand, without any penalties, issues or cooldowns except for not being able to remove the original stretcher. You can basically cover the map in stretchers from a single one.

Follow-predator word [predator talk sound effect]

Big Red round of 31 december
Follow predator word .
A result on screenshot:
Joselyn Heckendora (follow) says, "It was one time fucking thing, it was to remove his 150 burn damage"
[predator talk sound effect]

Ravager's rage gain on attacking a target and taking damage is uncapped.

This leads to scenarios where ravagers have well above 50 rage, this is probably bad because the thing isn't intended to get above fifty rage.

MTs can open CO's door

Working as intended, if you dont have a MT observing the CO sleep, you did something wrong.

Hivelord CANT evolve to defiler.

T2 evolution score always 0/200
Evolve level stays at"Finished"
You must wait before evolving. Currently at: 0 / 200.

Name stencil out of date

Still uses DMCA as the root.

Taking off your uniform doesn't drop your armor.

Yes, I introduced this bug, I'll fix it in the near future hopefully. Such is the coder life.

Xenos can't facepie huggers on nested monkeys.

Reproduction:

Haven't tested it, was merely reported as being an old bug about which I've learned only now.

Invo sprites seem fucked.

https://cdn.discordapp.com/attachments/493366161463967744/516355472907960329/unknown.png

image of it, it's only large bags it seems.

spitters can spray acid through fog

Surgery NEVER causes infection

Yes, another bug I introduced. Oh well, writing shit here helps me keep track of it.

Smartguns refuse to be reloaded once their ammo reaches 0, fine before that.

Most likely related to my Ammo HUD PR.

Rail gun / CO consoles

Edit: Railgun ammo is normal not bug. CO cannot use consoles is a bug.

Merc unable to use hands

as a merc, attempt to use the marine vendors. Then lose all ability to interact with objects in you inventory, aside from click dragging bags belts and pouches

Span Classes are showing up where they shouldn't.

code/modules/admin/verbs/randomverbs.dm#L574
command_announcement.Announce("<span class='warning'> New update available at all communication consoles.</span>", customname, new_sound = 'sound/AI/commandreport.ogg')
Announce does not support HTML, It was changed from /red in PR #296

How to increase picking of Alien role. [Ancients get ULTIMATE ABILITY(Dota-style)]

Younglings can do only basics.
Every mature alien learns new ability and minor buffs.
Elite aged aliens learn moderate skills and buffs.
Ancients should have the ULTIMATE ABILITY
More time required to grow = more stronger ability.
Example. Ancient crusher learns how to crush walls, girders or overthrow corpses over window frames by throwing people.
Now crusher "throw corpse" ability is too weak. Cant even overthrow corpse over window frames

OOC > View Admin Remarks + Player Panel Notes ignores spaces in ckeys.

Posting it here so I can fix it tomorrow and won't forget.

Double explosive pouch

Grenadier spec vendor

Freelancer Standards start with an empty ammo belt.

Smartgun will not reload

when you have fired all the ammo in the clip, reloading does not function.

Human/New() fucks with preferences

Yep, this one's also mine