tf / pr_log Goto Github PK

Those would otherwise be missing from the Changelog. Octokit search API should make this easy via no:milestone. Could maybe be separate task that is executed along with fetch as the default task (see #2)

As titled.
https://github.com/tf/pr_log/blob/master/lib/pr_log/formatter.rb#L32

Hi,

First of all, thanks and kudos for this tool, which is the closest I've found so far to the way we'd like to manage the Changelog of our project! 🙏

Now, when trying to customize the entry_template I ran into the following issue: there is apparently no way to use data from nested fields returned by the Github API, in particular the user field.

For instance, there is no way to use a template like this: "- %{title} (#%{number}) by %{user.login}\n".

I'm not sure if this should qualify as a bug or an enhancement request, but it's definitely something we'd find useful, and which would make the following sentence (from the Readme) even truer:

All fields from the
issue search response
can be used as interpolations.

Now, I am by no means a ruby developer, but since we had this need on our project I tried to implement this feature on a forked repository.

I am not sure if my implementation is acceptable or not, since it involves overriding the % interpolation operator of the String class.
But in case you are interested, you can find it here: slax57#1

I'd be happy to open a PR against your repository if you believe my implementation can be kept.

Cheers,

Simply running prlog should be enough.