Comments (4)
Great. If things do not work out, feel free to open a draft PR and we can have a look together.
from pr_log.
Hi Jean-Baptiste,
thank you for the kind words! Great to hear you find the tool useful.
I'd be happy to accept a PR to make these types of interpolations work. Just to limit the scope of the change, I'd prefer to have the new interpolation method as a private method of Formatter
instead of modifying String
. Other than that your implementation looks fine. Great to see that you also already added a test!
All the best
Tim
from pr_log.
Thanks for your reply!
As I said I'm not a ruby developer, but I can give it a try anyway.
I'll try to do that in the days to come, and if I succeed, I will open a PR here. 🙂
from pr_log.
I've opened a new PR against your repo 🙂
I kept the same implementation so it should be good, however I have a warning about the way I handle the rescue
case, and I must admit I'm not sure what the best practice would be here.
Any advice or commit is welcome 🙂
from pr_log.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pr_log.