Coder Social home page Coder Social logo

Comments (6)

tcbrindle avatar tcbrindle commented on June 11, 2024 1

@DeveloperPaul123 Not only is it reasonable, it's essential: a memcmp optimisation of equal must require that both sequences have the same type, among other conditions.

from flux.

tcbrindle avatar tcbrindle commented on June 11, 2024 1

@DeveloperPaul123 Thinking about it some more, I think it's probably better to not use memmem for now and stick with portable standard library facilities... we can look at platform/vendor-specific optimisations later if/when they're needed.

from flux.

tcbrindle avatar tcbrindle commented on June 11, 2024 1

Added in #103, thanks @DeveloperPaul123!

from flux.

DeveloperPaul123 avatar DeveloperPaul123 commented on June 11, 2024

I've started work on this in #103

from flux.

DeveloperPaul123 avatar DeveloperPaul123 commented on June 11, 2024

@tcbrindle I have a question while working on equal()

There is this test case:

 // Different but comparable element types
{
    int arr1[] = {1, 2, 3, 4, 5};
    float arr2[] = {1.f, 2.f, 3.f, 4.f, 5.f};

    STATIC_CHECK(flux::equal(arr1, arr2));
}

It seems that the intension is to compare values and accept them as equal. If we want to optimize with std::memcmp, does it seem reasonable to require the the values of the 2 sequences be of the same type? Currently, using the std::memcmp optimization causes the above test to fail (where it previously passed).

from flux.

DeveloperPaul123 avatar DeveloperPaul123 commented on June 11, 2024

@tcbrindle Currently, std::memmem is a GNU extension. Is it desirable to use this on platforms that's it's available on? Currently C++ extensions are explicitly turned off via CMake

from flux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.