Comments (6)
@DeveloperPaul123 Not only is it reasonable, it's essential: a memcmp
optimisation of equal
must require that both sequences have the same type, among other conditions.
from flux.
@DeveloperPaul123 Thinking about it some more, I think it's probably better to not use memmem
for now and stick with portable standard library facilities... we can look at platform/vendor-specific optimisations later if/when they're needed.
from flux.
Added in #103, thanks @DeveloperPaul123!
from flux.
I've started work on this in #103
from flux.
@tcbrindle I have a question while working on equal()
There is this test case:
// Different but comparable element types
{
int arr1[] = {1, 2, 3, 4, 5};
float arr2[] = {1.f, 2.f, 3.f, 4.f, 5.f};
STATIC_CHECK(flux::equal(arr1, arr2));
}
It seems that the intension is to compare values and accept them as equal. If we want to optimize with std::memcmp
, does it seem reasonable to require the the values of the 2 sequences be of the same type? Currently, using the std::memcmp
optimization causes the above test to fail (where it previously passed).
from flux.
@tcbrindle Currently, std::memmem
is a GNU extension. Is it desirable to use this on platforms that's it's available on? Currently C++ extensions are explicitly turned off via CMake
from flux.
Related Issues (20)
- Dropping from an empty sequence asserts HOT 3
- Using Flux to adapt a circular buffer : bug HOT 7
- Add product/permutations/combinations from Python itertools HOT 14
- Suggestion: add a header containing preprocessor macros. HOT 2
- Non const-iterable reversed sequences hard error when used as a range
- Attempted out-of-bounds read in flatten() HOT 1
- BUG: `flux::scan` broken HOT 3
- take_while should not be random-access HOT 1
- Consistent comparisons
- Internal `std::variant` access optimizations HOT 3
- cartesian_product size() can overflow
- Add zip_map adaptor
- flux::iota prevents auto-vectorization. HOT 4
- Clang Compilation failure HOT 4
- move of `loc` in assert.hpp causes clang-tidy error HOT 2
- cartesian_product::last() sometimes returns wrongly-initialised cursor if one of the source sequences is empty
- Clang crash HOT 2
- strange output, [[2]] instead of [] HOT 2
- Visual studio\code intellisense experience HOT 1
- Blog post shows perf gaps between flux and other approaches HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux.