Comments (2)
Hi Marvin,
Thanks for your interest in Flux!
You're right that macros don't work with modules, so we can't use the FLUX_FWD
macro with just import flux;
. It should possible however to just #include
the file include/flux/core/macros.hpp
to get FLUX_FWD
back.
(Although having quickly looked at it, I think the usage in word-count.cpp
is actually unnecessary, as it's perfectly fine to pass an lvalue sequence to for_each
.)
FWIW, to my surprise, I found this worked using clang++-17:
namespace flux {
inline auto forward(auto x) { return static_cast<decltype(x)&&>(x); }
} // flux
Unfortunately this is going to result in an attempted copy whenever it's passed an lvalue. The "proper" macro-less way to do forwarding is to say
std::forward<decltype(seq)>(seq)
but this is very longwinded, hence the macro! (And unless you're using a very recent compiler, heavy use of it can be bad for compile times too.)
I think for the foreseeable future we'll continue using FLUX_FWD internally within the library itself, but recommend that external users prefer std::forward
for module compatibility. One day I'd like to convert the examples to using modules, so I should probably go through them and change/remove uses of the FWD macro.
from flux.
@marvin-littlewood I'm going to close this issue as we do already do what's suggested in the title -- the include/core/macros.hpp
header. If you have any more questions or suggestions then please let me know.
from flux.
Related Issues (20)
- Dropping from an empty sequence asserts HOT 3
- Using Flux to adapt a circular buffer : bug HOT 7
- Add product/permutations/combinations from Python itertools HOT 14
- Non const-iterable reversed sequences hard error when used as a range
- Attempted out-of-bounds read in flatten() HOT 1
- BUG: `flux::scan` broken HOT 3
- take_while should not be random-access HOT 1
- Consistent comparisons
- Internal `std::variant` access optimizations HOT 3
- cartesian_product size() can overflow
- Add zip_map adaptor
- flux::iota prevents auto-vectorization. HOT 4
- Clang Compilation failure HOT 4
- move of `loc` in assert.hpp causes clang-tidy error HOT 2
- cartesian_product::last() sometimes returns wrongly-initialised cursor if one of the source sequences is empty
- Clang crash HOT 2
- strange output, [[2]] instead of [] HOT 2
- Visual studio\code intellisense experience HOT 1
- Blog post shows perf gaps between flux and other approaches HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux.