Comments (1)
In the multipass version of flatten_adaptor
, we stop iterating when the outer cursor reaches the end of the outer sequence. However, when we get there, we don't reset the inner cursor, which is left pointing to wherever it previously pointed to. This means that a cursor which has iterated through to the end winds up not equal to the cursor returned from last()
(which contains a default-constructed inner cursor).
This showed up when using to()
because it uses (adapted) iterators which, of course, want to stop iterating when iter == last
. Since that equality never happened, we end up trying to read past the end. The good news is we got a bounds violation runtime error rather than UB -- the system works!
Anyway, the solution is to make sure we reset the inner cursor when we reach the end in multipass flatten_adaptor
. PR incoming...
from flux.
Related Issues (20)
- Dropping from an empty sequence asserts HOT 3
- Using Flux to adapt a circular buffer : bug HOT 7
- Add product/permutations/combinations from Python itertools HOT 14
- Suggestion: add a header containing preprocessor macros. HOT 2
- Non const-iterable reversed sequences hard error when used as a range
- BUG: `flux::scan` broken HOT 3
- take_while should not be random-access HOT 1
- Consistent comparisons
- Internal `std::variant` access optimizations HOT 3
- cartesian_product size() can overflow
- Add zip_map adaptor
- flux::iota prevents auto-vectorization. HOT 4
- Clang Compilation failure HOT 4
- move of `loc` in assert.hpp causes clang-tidy error HOT 2
- cartesian_product::last() sometimes returns wrongly-initialised cursor if one of the source sequences is empty
- Clang crash HOT 2
- strange output, [[2]] instead of [] HOT 2
- Visual studio\code intellisense experience HOT 1
- Blog post shows perf gaps between flux and other approaches HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux.