Coder Social home page Coder Social logo

simplyswords's People

Contributors

avirtual777 avatar chronosacaria avatar gyular avatar halosense avatar kododenka avatar krelox avatar murolem avatar rad586 avatar saga23456 avatar sweenus avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

simplyswords's Issues

Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'simplyswords'!

the game keeps crashing every time I try to load with simplyswords specifically, I have tried getting rid of mods and nothing will fix the error.

---- Minecraft Crash Report ----
// Who set us up the TNT?

Time: 8/25/22, 9:00 PM
Description: Initializing game

java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'simplyswords'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
at net.minecraft.class_310.(class_310.java:452)
at net.minecraft.client.main.Main.main(Main.java:197)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.NoClassDefFoundError: net/fabricmc/fabric/api/loot/v2/LootTableEvents
at net.sweenus.simplyswords.util.ModLootTableModifiers.modifyLootTables(ModLootTableModifiers.java:30)
at net.sweenus.simplyswords.SimplySwords.onInitialize(SimplySwords.java:38)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 7 more
Caused by: java.lang.ClassNotFoundException: net.fabricmc.fabric.api.loot.v2.LootTableEvents
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
... 10 more

[SUGGESTION] Disabling weapons, runic effects and additional config options

I really love this mod and I'm planning on using it as a main mod on my server's modpack. But, I think for the sake of configurability, it would help if specific weapons could be entirely removed from loot tables. Essentially, you could add a boonlean for every single weapon and putting it false would keep the weapon in game but available only from commands or the creative menu. Grants the player/server owner the ability to disable weapons they do not want for balancing or other reasons. Same here for the runic effects.

Player/Chunk corruption

If on the Frozen Scythe Mending gets added in an anvil it corrupts/crashes the game. If the items stay in there because of a mod and it's an auto anvil, every restart won't help and the chunk gets corrupted.

Storm's Edge multiplayer right click bug

When playing on a server with this mod me and my friend found a bug with the storm's edge's right click. The first player to join the server will be referred to as player 1 and the second person is player 2.

Player 2 has a Storm's Edge, using right click should give player 2 forward momentum with a speed boost and haste. Instead, the momentum and boosts are applied to player 1 and player 2 only gets haste. Also the the cooldown is not applied for player 2, meaning he can send player 1 dashing though the whole map.

1.19.4

This mod works on 1.19.4 without any problems and I use it on the server. But not most of the effects of legendary weapons crash the game. Is an update expected?

[Suggestion] Better config system for 1.19.2

Many, many mods are able to release updates and add its changes into the current config that someone has.

Having to delete, regenerate, and reconfigure config files is very time consuming, especially if you are a modpack creator like myself and have a lot of customization.

Please create a new system, or use a already available config API that allows concatenating new additions/changes to the config file that already exists.

Mod breaks mipmap

When version 1.34 for fabric 1.19.2 is installed, Minecraft's mipmapping setting seems to be broken and not functioning properly

Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'simplyswords'!

Someone had an error similar to this but I've checked my fabric api and loader and tried it with just the mod and the required mod and it still won't work, is there something I can do other than just get rid of it?

`---- Minecraft Crash Report ----
// Who set us up the TNT?

Time: 2023-01-08 20:57:51
Description: Initializing game

java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'simplyswords'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
at net.minecraft.class_310.(class_310.java:465)
at net.minecraft.client.main.Main.method_44604(Main.java:205)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.NoSuchFieldError: field_25108
at net.sweenus.simplyswords.registry.ItemsRegistry.(ItemsRegistry.java:112)
at net.sweenus.simplyswords.SimplySwords.init(SimplySwords.java:69)
at net.sweenus.simplyswords.fabric.SimplySwordsFabric.onInitialize(SimplySwordsFabric.java:12)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 8 more

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
at net.minecraft.class_310.(class_310.java:465)

-- Initialization --
Details:
Modules:
ADVAPI32.dll:Advanced Windows 32 Base API:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
COMCTL32.dll:User Experience Controls Library:6.10 (WinBuild.160101.0800):Microsoft Corporation
CRYPT32.dll:Crypto API32:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
CRYPTBASE.dll:Base cryptographic API DLL:10.0.19041.546 (WinBuild.160101.0800):Microsoft Corporation
CRYPTSP.dll:Cryptographic Service Provider API:10.0.19041.546 (WinBuild.160101.0800):Microsoft Corporation
DBGHELP.DLL:Windows Image Helper:10.0.19041.867 (WinBuild.160101.0800):Microsoft Corporation
DNSAPI.dll:DNS Client API DLL:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
GDI32.dll:GDI Client DLL:10.0.19041.1202 (WinBuild.160101.0800):Microsoft Corporation
IMM32.DLL:Multi-User Windows IMM32 API Client DLL:10.0.19041.546 (WinBuild.160101.0800):Microsoft Corporation
IPHLPAPI.DLL:IP Helper API:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
KERNEL32.DLL:Windows NT BASE API Client DLL:10.0.19041.1566 (WinBuild.160101.0800):Microsoft Corporation
KERNELBASE.dll:Windows NT BASE API Client DLL:10.0.19041.1566 (WinBuild.160101.0800):Microsoft Corporation
NLAapi.dll:Network Location Awareness 2:10.0.19041.1151 (WinBuild.160101.0800):Microsoft Corporation
NSI.dll:NSI User-mode interface DLL:10.0.19041.610 (WinBuild.160101.0800):Microsoft Corporation
NTASN1.dll:Microsoft ASN.1 API:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
Ole32.dll:Microsoft OLE for Windows:10.0.19041.1320 (WinBuild.160101.0800):Microsoft Corporation
OleAut32.dll:OLEAUT32.DLL:10.0.19041.985 (WinBuild.160101.0800):Microsoft Corporation
PSAPI.DLL:Process Status Helper:10.0.19041.546 (WinBuild.160101.0800):Microsoft Corporation
Pdh.dll:Windows Performance Data Helper DLL:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
RPCRT4.dll:Remote Procedure Call Runtime:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
SHCORE.dll:SHCORE:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
SHELL32.dll:Windows Shell Common Dll:10.0.19041.964 (WinBuild.160101.0800):Microsoft Corporation
USER32.dll:Multi-User Windows USER API Client DLL:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
USERENV.dll:Userenv:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
VCRUNTIME140.dll:Microsoft® C Runtime Library:14.29.30139.0 built by: vcwrkspc:Microsoft Corporation
VERSION.dll:Version Checking and File Installation Libraries:10.0.19041.546 (WinBuild.160101.0800):Microsoft Corporation
WINHTTP.dll:Windows HTTP Services:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
WINMM.dll:MCI API DLL:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
WS2_32.dll:Windows Socket 2.0 32-Bit DLL:10.0.19041.1081 (WinBuild.160101.0800):Microsoft Corporation
WSOCK32.dll:Windows Socket 32-Bit DLL:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
Wldp.dll:Windows Lockdown Policy:10.0.19041.1 (WinBuild.160101.0800):Microsoft Corporation
amsi.dll:Anti-Malware Scan Interface:10.0.19041.746 (WinBuild.160101.0800):Microsoft Corporation
antimalware_provider64.dll:AMSI provider :`

Recipe issue

The war axe has the same recipe as the gobber hammer I cant craft the gobber hammer

Soulrender

ok so i got Soulrender in a chest all fine, i dont know if its supposed to but every first strike deals 4 damage and the second strike deals the correct 10 damage, when using for example a torch on the second hand the weapon only does the first strikeso it ends up dealing almost no damage compared

Identification problem

I use Simply swords on my server as a addon for variation. Imedietly players started asking how you identify runic weapons that has been crafted or just gained. Ive been trying to search around to find answers as well as testing different methods in game but cant seem to figure out how to identify the runic power. It does have a power when using it you just cant see which power it has if you dont know the powers and how they look before hand. I might have missed something but at the moment i cant seem to figure out what to do.

Feature Request: Add a config for sounds

Heya! The sounds of hitting something with the weapons is really loud, even when lowering the volume by a good amount. Do you think you can add a config to change the volume of the weapons?

Inaccessible Modrinth description

Hi, I am one of Modrinth's administrators and the lead moderator.

The current description is very inaccessible to screen readers and to those who don't have images loaded. I would like to ask you to provide a transcription of the images in the description.

This is a requirement per section 2.1 of Modrinth's content rules:

Project descriptions must also be accessible. For the most part, this means that descriptions cannot mostly consist of text within images, and necessary information cannot be obscured.

As such, if the changes are not made soon, restrictions may be put on the mod's page.

[QUILT 1.19.2] Can't run game with Mythic Metals, SimplySwords and Gobber2

I commented on the Curseforge page but I probably should put it here.

Error:

java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'simplyswords'!

at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$2(EntrypointUtils.java:66)

at org.quiltmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:34)

at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:64)

at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invokeContainer(EntrypointUtils.java:49)

at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:36)

at org.quiltmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:55)

at net.minecraft.class_310.<init>(class_310.java:459)

at net.minecraft.client.main.Main.method_44604(Main.java:205)

at net.minecraft.client.main.Main.main(Main.java:51)

at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)

at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.base/java.lang.reflect.Method.invoke(Method.java:568)

at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:529)

at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:82)

at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)

at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)

at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)

at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

Caused by: java.lang.ExceptionInInitializerError

at net.sweenus.simplyswords.fabric.SimplySwordsFabric.onInitialize(SimplySwordsFabric.java:28)

at org.quiltmc.loader.impl.game.minecraft.Hooks.lambda$startClient$0(Hooks.java:55)

at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke$0(EntrypointUtils.java:36)

at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:62)

... 16 more

Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.Float.floatValue()" because the return value of "java.util.HashMap.get(Object)" is null

at net.sweenus.simplyswords.config.SimplySwordsConfig.getWeaponAttributes(SimplySwordsConfig.java:42)

at net.sweenus.simplyswords.compat.GobberCompat.<clinit>(GobberCompat.java:16)

... 20 more

Checking code, managed to make it work with the following changes:

SimplySwordsFabric.java

    @Override
    public void onInitialize() {

        //Only run our init if Mythic Metals is not installed
        if (!FabricLoader.getInstance().isModLoaded("mythicmetals")) {
            SimplySwords.init();

            if (FabricLoader.getInstance().isModLoaded("gobber2")) {
                GobberCompat.registerModItems();
            }
        }

MythicMetalsInitMixin.java

    public void init(CallbackInfo info) {

        System.out.println("SimplySwords: Detected Mythic Metals - injecting compatibility init");
        SimplySwords.init();
        MythicMetalsCompat.registerModItems();

        if (FabricLoader.getInstance().isModLoaded("gobber2")) {
            GobberCompat.registerModItems();
        }
    }

Albeit this is kinda ugly and I'm not proficient enough in Java/Minecraft modding to contribute a better code fix

Unmet mod

Error message below.


Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
- Install architectury, version 5.12.42 or later.
Unmet dependency listing:
- Mod 'Simply Swords' (simplyswords) 1.37-1.19.2 requires version 5.12.42 or later of architectury, which is missing!
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:190)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)


So I asked the architechtury mod and the verson that I got didn't work nor the version it's asking for.


Desktop Screenshot 2023 01 22 - 16 13 59 04

Wildfire effect can brick worlds if applied to exploding creepers

Creepers cause lingering potion effects after they explode and have an effect applied to them, so weapons that apply effects (like the wildfire effect) will functionally permaban a player from servers when it tries to spawn the lingering effect cloud in with them. It saves the info in the player's NBT data when they get kicked, so it can only be fixed if an admin edits the NBT data to remove any applied effects.

An error log would include something like this:
Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.player.Player.m####()" because "p36169" is null

[Suggestion] Mod compat

Expert weapons and tools mod makes it so that progression is slowed down.
-Gobber - which has compat with simply swords - already has compat with.
-Advanced netherite also has compat.

Better Netherite -which adds in higher levels of weapons/tools/armor above netherite, some with their own abilities- Support.

Feedback from a modpack dev

Hi, i'm the creator of AQM2. Though your mod is wonderful, it lacks a lot of information surrounding the effects and config values which are highly important to us modpack developers.

I'm not sure what half of these statuses do as well as the configs. What is watcher for example? what does the restore amount do? what about soulmeld, or soulrend? especially omen, no idea how the instakill mechanic works. as well as ferocity. It would be wonderful if you can create a wiki to explain the effects / config values or at least add comments in the config.

Also is the duration in seconds or ticks?

Thanks!

More unique base stats

IDK if it's any different with better combat installed, but without it weapons that should have extra stats like extra reach or better sweeping do not, and I think it'd be a huge improvment if you could implement that. Alterntively it might just be that these extra stats don't display on the weapon and I just haven't notied them, if this is the case I think adding a bit too the tooltip that displays extra range or sweeping for weapons where it is applicable would be a huge improvement

[SUGGESTION] Add a blacklist or toggle in the configs for loot tables.

Currently the mod allows for runic and unique weapons to spawn in a lot of low tier structures by default. While the ability to restrict all weapons from the mod from appearing in village chests is nice, it would be better if the user could configure what particular structures would spawn certain tiers of weapon, especially within modpacks.

For example, if the player wants to disable unique and runic weapons from appearing in villages, ruined portals, and a modded structure that appear very frequently in their world (and therefore, have a better chance of giving an OP weapon early), they would add the namespaced IDs of these structures to a JSON file that specifies to remove these types of weapon from those loot pools.

I've had this issue myself while developing a pack, and it becomes a pain to manually re-create loot tables or blacklist these items one-by-one or with an external scripting mod, so the ability to choose before the loot tables are registered would be ideal.

Wildfire effect causing players to crash

Heya! A friend playing on my server crashed because of the Wildfire effect and couldn't rejoin until I disabled the effect on the config.

Fabric 1.19.2, mod version 1.40.0

I'll send logs soon!

Netherite Weapons Burn in Lava

Netherite weapons get destroyed in lava unlike vanilla netherite items.

I believe it'd also be fair to make runic weapns lava-proof, given that they're upgraded from netherite items.
Possibly even special weapons, since they're so rare.
However, rare vanilla items such at tridents and totems are also not lava proof so I'm not 100% sure lol.
Possibly have special weapons being lava-proof as a toggle in the config.

Forge: 43.2.0
Minecraft Version: 1.19.2

I've attached my latest log file in case it's needed.
latest.log

[Suggestion] Option to configure (or disable) Brimstone explosion radius

I would like to be able to use the Brimstone Claymore without causing creeper explosions constantly! An option to disable brimstone griefing or at least adjust the radius of it would be much appreciated, thanks!

P.S. In the 1.18.2 effects_config.json5 file, the brimstone settings appear to be a mismatch with some bramble effect:

// -- Unique Effect: Brimstone -- 
// ------------------------------ 
  "brimstone_chance": 15.0,
  "bramble_chance": 45.0,
  "bramble_radius": 10.0

Longsword Attack Range (Gobber Mod)

Longswords from the Gobber mod has an attack range of 2.5 while all the other longswords have a range of 2.9. I am not sure if it is because I configured these attributes (I changed durability, minespeed, attackdamage, and enchantability),

//GOBBER
GOBBER(5, 1796, 8.5F, 5.5F, 13, () -> Ingredient.ofItems(Items.DIAMOND)),
GOBBER_NETHER(6, 2562, 11.0F, 5.5F, 16, () -> Ingredient.ofItems(Items.DIAMOND)),
GOBBER_END(7, 3916, 12.5F, 6.0F, 24, () -> Ingredient.ofItems(Items.DIAMOND));,

but the thing is all the other Gobber weapons have same attack range as the other weapons'. It's just the longswords that has the same attack range as normal sword.

Iron Longsword
Gobber Longsword
Diamond Twinblade
End Twinblade

Promethium weapons do not regain durability

When Mythic Metals is installed, weapons made from Promethium do not regain durability. I tested on a fresh install with just Mythic Metals, Simply Swords, a mod to show numeric durability numbers, and all the dependencies. Vanilla tools made from Promethium regained a durability every few seconds, but after minutes the modded weapons did not. It's possible Carmot weapons don't function properly with the extra looting level as well, but that's a bit harder to objectively prove.

Config files use JSON5 extension but do not accept valid JSON5

The config files use the .json5 extension which corresponds to the JSON5 format. One feature of this file format is object keys don't have to be quoted if they are valid identifiers. Example:

// JSON5 only
{ some_key: true }

// JSON, or JSON5
{ "some_key": true }

You can confirm this in an online validator.

If you use this syntax in your config files, the game crashes on startup. I believe you are parsing these files as though they are regular JSON. Shockingly this works even though comments are invalid in regular JSON!

If you want just JSON with comments, use the .jsonc file extension. If you want to keep the .json5 file extension, I recommend finding a proper JSON5 parser for Java. Otherwise when a user edits your config files with a code editor, it may auto-format the files in the conventional JSON5 style, which your current parser does not handle - that's how I found this error!

Another option would be to use .toml files, which are the most common format for Minecraft mod configs. They support JSON-serializable values as well as comments, and have much wider support than .json5 or .jsonc.

bugged weapons with better combat mod

So, all of my weapons are bugged except a iron claymore im using, they dont do the animation that pulls them out and charges their critical bar thingy, this is only bugged in multiplayer and not on singleplayer for some reason and its very annoying, even vanilla minecraft weapons such as axes are bugged and just dont work

Config for Gobber attributes

Would it be possible to add in the configs to have the option to configure weapon attributes from the Gobber mod? I customized the configs from the original mod, and I was hoping I could have similar attributes of that in the Gobber weapons from this mod.

Incompatability with Corails Tombstone that causes Corrupted playerdata

I am not sure if this is caused by simply swords or better combat, but when hitting a boss with the Corails Tombstone enchantment "Plague Bringer" on a sword, it crashes the player side and corrupts their playerdata serverside. This has happened multiple times, and some trial and error (my friend who was experiencing the crashes), it seems that some of the invisible effects of either better combat or simply swords like simplyswords.effect.gravity in combination of the Corails Tombstone enchantment crashes the game and prevents the player from rejoining unless the playerdata is deleted.

If there are any files, that you need to help figure out this problem, please let me know so i can provide them! It also happened with another player using the iron katana with plague bringer on it, same results where I needed to wipe the playerdata.

Thank you!

Suggestion [ Spear Weapons ]

Hey ! was just wondering if there is a way to make the Spears throwable ? since they have the same attack pattern, sounds, and holding position as a trident, ( its just longer ) I was a little saddened that I couldn't throw it. I also feel that it could open a cool door of maybe having Homing thrown attack, maybe a blast on impact, fire, ice, withering, etc ! Let me know what you think !

Thanks !

[BUG/CONFLICT] White (anti-aliasing-like) artifacts with Rubidium

Steps to reproduce (versions used noted below)

  1. Enable Rubidium.
  2. Enable Simply Sword.
  3. Enter a new world.
  4. Place multiple oak leaves to easily visualize the problem (see screenshots below).
  5. White "anti-aliasing" artifacts appears.
  6. Disable either Rubidium or Simply Sword and the visual glitches does not appear anymore.
  7. Downgrade Simply Sword to any version < 1.33 to fix the visual glitch.

Other remarks

This bug is not present in any 1.19.2 versions of Simply Sword prior to 1.33

This bug has likely been introduced in version 1.33 of Simply Sword, as prior versions do not exhibit the visual glitches.

Versions

Minecraft: 1.19.2
Forge: 43.2.1
Architectury: 6.4.62
Rubidium: 0.6.2
Simply Sword: 1.34-1.19.x
Nvidia drivers: 527.56

Example

While the artifacts are very noticeable in game when any motion is involved, they do not survive any video compression. Here are screenshots demonstrating the glitches:

2022-12-27 000134

2022-12-27 000332

Simply Swords has failed to load correctly

I was testing if a custom modpack i was working on, would run well on Mac and when i tried to start Minecraft the following error appeared:

(Already tried it with every modversion of 1.19.2)

-- Head --
Thread: Render thread
Stacktrace:
at net.sweenus.simplyswords.SimplySwords.init(SimplySwords.java:44) ~[simplyswords-forge-1.43.0-1.19.2.jar%23351!/:?] {re:classloading}
-- MOD simplyswords --
Details:
Caused by 0: java.lang.reflect.InvocationTargetException
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}
at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}
at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {re:mixin}
at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {re:mixin}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:68) ~[javafmllanguage-1.19.2-43.2.4.jar%23382!/:?] {}
at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$10(ModContainer.java:121) ~[fmlcore-1.19.2-43.2.4.jar%23381!/:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {re:mixin,re:computing_frames}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {re:mixin,re:computing_frames}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {re:mixin}

Mod File: /Users/kilianforberg/Desktop/AT Launcher/ATLauncher.app/Contents/Java/instances/Minecraft1192withForge/mods/simplyswords-forge-1.43.0-1.19.2.jar
Failure message: Simply Swords (simplyswords) has failed to load correctly
	java.lang.reflect.InvocationTargetException: null
Mod Version: 1.43.0-1.19.2
Mod Issue URL: https://github.com/Sweenus/SimplySwords/issues
Exception message: java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonObject.has(String)" because "json" is null

Stacktrace:
at net.sweenus.simplyswords.SimplySwords.init(SimplySwords.java:44) ~[simplyswords-forge-1.43.0-1.19.2.jar%23351!/:?] {re:classloading}
at net.sweenus.simplyswords.forge.SimplySwordsForge.(SimplySwordsForge.java:18) ~[simplyswords-forge-1.43.0-1.19.2.jar%23351!/:?] {re:classloading}
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] {}
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?] {}
at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] {}
at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?] {re:mixin}
at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?] {re:mixin}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:68) ~[javafmllanguage-1.19.2-43.2.4.jar%23382!/:?] {}
at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$10(ModContainer.java:121) ~[fmlcore-1.19.2-43.2.4.jar%23381!/:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {re:mixin,re:computing_frames}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {re:mixin,re:computing_frames}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {re:mixin}

Modify weapon damage according to proportion instead of adding a fixed modification value&&Add options to modify weapon attack speed

Different types of weapons have different damage
If you increase the basic damage of the corresponding weapon, you will find that the damage difference between sword and hammer is not big

The basic damage of weapons of different materials is different, so the damage should be allocated proportionally. For example, the damage of the hammer is twice that of the long sword, which will not cause this problem

Zoglin Wildfire crash

java.lang.ClassCastException: class net.minecraft.world.entity.monster.Zoglin cannot be cast to class net.minecraft.world.entity.player.Player (net.minecraft.world.entity.monster.Zoglin and net.minecraft.world.entity.player.Player are in module [email protected] of loader 'TRANSFORMER' @342723a3)
at net.sweenus.simplyswords.effect.WildfireEffect.m_6742_(WildfireEffect.java:35) ~[simplyswords-forge-1.43.1-1.19.2.jar%23537!/:?] {re:classloading}

Looks like there's a weird interaction with whatever causes the WildfireEffect class to be used and Zoglins. Might need to put in a check for entities which can't be cast to Players.

This bug will crash whichever world it happens in and effectively corrupt it, since the code will immediately be executed upon reloading the world and crash the world again.

swords are too common in dungeon chests | 1.19 fabric V.1.04

like i was having chest that was contaning 6 swords, and that is too mutch, but in my opinion this weapons are too powerful to be common. I don't want to start game with ultimate dimond godslaying fireslasher sword, that will kill all enemys on 1-2 hits, like men this is survival.
And this is not joke this swords are like in every chest.
I like this mod, cuz of this models and compatibility with better combat, that make fights look so cool.
Or mayby add some config to change rarity of swords in chests.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.