Comments (13)
With #923 applied, this looks much better now, thanks!
from libblockdev.
I knew I wanted to check one more thing before doing a release... I fixed some of the issues in #920, the remaining problematic functions should be the _get_type
functions and the NVMe plugin functions.
NVMe plugin: I am not sure what's happening here -- are you compiling the library --without-nvme
? The nvme.h
header file is placed in a subdirectory so maybe this doesn't work on Debian. I'll wait for @tbzatek to look at this.
_get_type
functions: We need these just for GObject Introspection so I don't want to add them to our header files, I am not sure if we can hide these, I'll check how other GI projects deal with this.
from libblockdev.
Atm I don't enable nvme, correct
from libblockdev.
Atm I don't enable nvme, correct
Yeah, that explains, the header file is not installed if not configured yet the library contains stub funcs.
from libblockdev.
The _get_type()
functions might be worth having in public header files for the sake of compleness and to follow GObject rules. There might be scenarios where somebody would want to extend the type, although we use it primarily for structs.
I don't think this is a pressing issue at the moment, thanks for reporting this anyway.
from libblockdev.
Nod, certainly not pressing.
Thanks for the clarification regarding the nvme plugin.
I had disabled it for the time being waiting for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039858 to be fixed.
But maybe I'll just add those dependencies manually to libblockdev for now.
from libblockdev.
I guess we're the first independent consumers of libnvme as nvme-cli may require these deps themselves :-)
from libblockdev.
I guess we're the first independent consumers of libnvme as nvme-cli may require these deps themselves :-)
Do you consider libnvme stable enough for the plugin to be enabled by default?
from libblockdev.
Do you consider libnvme stable enough for the plugin to be enabled by default?
libnvme
has been stable for some time (and is well tested by nvme-cli
). The libblockdev nvme plugin + udisks interfaces have been around for some time too, used in blivet and Anaconda. We intentionally left NVMe discovery out of these releases as that's where API stability was questionable, for the rest we need first adopters that were waiting for a release. Still, the APIs are fairly minimal and I don't expect any need for a change.
FYI, libblockdev-nvme is a hard dep for udisks-2.10.0
from libblockdev.
I ran my script on git master with nvme enabled:
bd_btrfs_device_info_get_type
bd_btrfs_filesystem_info_get_type
bd_btrfs_subvolume_info_get_type
bd_crypto_bitlk_info_get_type
bd_crypto_integrity_extra_get_type
bd_crypto_integrity_info_get_type
bd_crypto_keyslot_context_get_type
bd_crypto_luks_extra_get_type
bd_crypto_luks_info_get_type
bd_crypto_luks_pbkdf_get_type
bd_crypto_luks_token_info_get_type
bd_fs_btrfs_info_get_type
bd_fs_exfat_info_get_type
bd_fs_ext2_info_get_type
bd_fs_ext3_info_get_type
bd_fs_ext4_info_get_type
bd_fs_f2fs_info_get_type
bd_fs_features_get_type
bd_fs_mkfs_options_get_type
bd_fs_nilfs2_info_get_type
bd_fs_ntfs_info_get_type
bd_fs_udf_info_get_type
bd_fs_vfat_info_get_type
bd_fs_xfs_info_get_type
bd_loop_info_get_type
bd_lvm_cache_stats_get_type
bd_lvm_lvdata_get_type
bd_lvm_pvdata_get_type
bd_lvm_segdata_get_type
bd_lvm_vdopooldata_get_type
bd_lvm_vdo_stats_get_type
bd_lvm_vgdata_get_type
bd_md_detail_data_get_type
bd_md_examine_data_get_type
bd_nvdimm_namespace_info_get_type
bd_nvme_controller_info_get_type
bd_nvme_error_log_entry_get_type
bd_nvme_lba_format_get_type
bd_nvme_namespace_info_get_type
bd_nvme_sanitize_log_get_type
bd_nvme_self_test_log_entry_get_type
bd_nvme_self_test_log_get_type
bd_nvme_smart_log_get_type
bd_part_disk_spec_get_type
bd_part_spec_get_type
_nvme_fabrics_errno_to_gerror
_nvme_status_to_error
_open_dev
from libblockdev.
Should we close this or do you want to keep it open as a reminder how to deal with the remaining _get_type symbols?
from libblockdev.
Btw, are these errors to be expected on s390(x)
https://buildd.debian.org/status/fetch.php?pkg=libblockdev&arch=s390x&ver=3.0-1&stamp=1688370506&raw=0
The Debian package is built using --without-s390
.
Why are those symbols exported in this case?
from libblockdev.
The symbol fs_info
slipped into the 3.0.1 release.
It's a side-effect of 0d97224 (dropping the static)
from libblockdev.
Related Issues (20)
- [packit] Propose downstream failed for release 3.1.1-1
- create MD failed if don't set bitmap HOT 1
- tools: Link failure when using LLD HOT 1
- Compilation error due to warnings in ext2fs headers
- Remove the configuration files for plugin loading HOT 2
- TODO: Add clang in the CI
- slow bd_fs_ntfs_get_info causing timeouts to udisks2 clients and hanging KDE HOT 4
- test suite requires package to be built with tools enabled HOT 1
- Assertion error in tests/library_test.py HOT 4
- PyGIWarning: BlockDev was imported without specifying a version first. HOT 4
- libblockdev3 leaks empty directories in bd_fs_get_free_space on btrfs partition
- gen_bitmap64.c:(.text+0x6ef): undefined reference to `com_err' HOT 3
- udev event storm - s390x HOT 3
- ntfsresize disable progress bar HOT 1
- btrfs: setting a label is only supported on a mount point HOT 3
- [packit] Propose downstream failed for release 3.0.4-1 HOT 1
- RFE: Add support for DASD partitioning HOT 1
- test suite failure: FAIL: test_create_delete_subvolume (btrfs_test.BtrfsTestCreateDeleteSubvolume.test_create_delete_subvolume) HOT 2
- expected enumeration type void, but got PyBlockDevPlugin instead HOT 4
- [packit] Propose downstream failed for release 3.1.0-1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libblockdev.