udev event storm - s390x about libblockdev

[tbzatek]

Short term, do you believe that disabling this code block is safe? Some info would be lost - part_type potentially for the non-ID_PART_TABLE_TYPE case if that part_type is gpt or msdos, but I think it would cut off the loop for now.

It was added recently for this UDF+VFAT corner case: storaged-project/udisks#1110. It was expected that the udev attributes are present in most cases. You can remove temporarily on your side without any significant impact. We'll fix the libblockdev side anyway.

[tbzatek]

Good catch! Seems like we should differentiate readonly scenarios for fdisk_assign_device() in case of public getter functions.

[dbungert]

Good catch! Seems like we should differentiate readonly scenarios for fdisk_assign_device() in case of public getter functions.

Thanks! I do think it would be healthy for libblockdev to differentiate the read-only and read-write use cases, to reduce spurious watch events.

Short term, do you believe that disabling this code block is safe? Some info would be lost - part_type potentially for the non-ID_PART_TABLE_TYPE case if that part_type is gpt or msdos, but I think it would cut off the loop for now.
https://github.com/storaged-project/udisks/blob/c7027d888c00381851d918f33a13102e7b86e188/src/udiskslinuxpartitiontable.c#L151-L170