stjerneidioten / adjustablemirrors Goto Github PK

Create a new translation/rotation system for moving the camera around. Instead of the current rotation-only based system. With the current system the mirror essentially stays in the same spot, but a proper mirror should be able to change its translation as well, which is analogous to extending/subtracting the mirror arm.

It would be awesome if it was possible to move the entire mirror arm. Also in 3 person.

Allow the use of mouse to adjust the mirrors. The key controls should remain and it should be toggle-able, whether to use one control scheme or the other.

https://www.yesmods.com/fs19-mods/trucks/european-trucks/volvo-fh16-trucks-lmrm

It seems that the truck registers its own vehicletype and my theory is that this happens after that adjustable mirrors has injected itself into the vehicle types. A possible solution could be to register AM in the postload method or something like that.

Big bud mod from official modhub or something else without mirrors, like Ponsse ScorpionKing, throw errors in the log when ctrl + 0 (kp) is being clicked.
Action event are activated but mirrors don't exist.

Multiplayer support on dedicated servers

#20
If you start a fresh savegame on a dedi server and you try to buy something, a LUA error will appear in the log and you can't enter the tractor.

log.txt

When you try to enter the vehicle an error will appear
logServer.txt

Currently the mod does not work properly on player to player servers.

Hi, thanks for bringing this mod to FS22, this is super useful for realistic playstyles!
The mod works with most machines; I got weird behavior with the Deutz Fahr harvester of the DF M2680 mod, though: If I adjust the mirrors in any direction, I end up having a fixed green image which doesn't reflect.
I guess there's a high chance that the harvester mod itself would have to be fixed for this, but I wanted to let you know anyway just in case there's an easy workaround or something:

Mod Link: https://www.farming-simulator.com/mod.php?lang=en&country=gb&mod_id=267177

Video:
https://github.com/StjerneIdioten/AdjustableMirrors/assets/10223149/0bac886e-df33-403f-9e26-e58cdd7a7bd5

The mirrors refuse to be saved, when there are multiple people on the server. It works flawlessly with only one player present and the other player will get the correct values upon joining.

I noticed in the log that the value received by the server is just the old value, when there are multiple people.

Fx. the code in the OnLeave() function is a mess in its current state.

Hi, have you any plans to convert the mod for FS22?
Tanks

Tested this today and found that it conflicts with Courseplay https://github.com/Courseplay/courseplay in a way that prevent Courseplay vehicles from starting their course

Hope you come up with a solution as this is a great little mod you are reviving for FS19

thanks

The values don't match up server and client side.

So when the parent mirror is adjusted the child follows. The child should be added as a seperate mirror.

The John Deere 5M from the JohnDeereSerie5M cannot adjust it's mirrors.

Be able to adjust the field of view of the camera, since some cameras are insanely zoomed in.

Perhaps a crosshair that shows up on screen to help with the aiming. Or maybe some highlight boxes on the mirrors that changes color when you are aiming well enough at the mirror.

The mirror rotations are stored as signed float, but transfered as signed int.

Hi! There are errors in the log (MP dedi server session) like this:

Error: Vehicle type 'xxx' has unknown specialization 'AdjustableMirrors'!

Is it OK?

Thank you

The mod has never been tested with low settings, where mirrors are not present. So I just always assumed that mirrors are present on clients in MP, but that is not the case. And this causes errors and issues. And in some cases crashes.

#20
If the savegame is already saved (this mod was never used before) you can't join dedi game because screen is freezed on sync page.

(Tested only on dedi)

log.txt
logServer.txt

Make it so the mod is able to be integrated directly into a vehicle mod, where the mirror arms have been created as individual objects and map it in the vehicle specialization tags in the vehicles xml-file.

In relation to issue #9

Make it so you can setup different configurations than you can switch between fx "no implement" or "manure spreader"

What happens if the server has fx. 7 mirrors stored but the client only has 2 mirrors enabled? Does this cause de-synchronization?

This have not been tested. But sometimes a player will get a (1) appended to their name even if they are the only one with that name on the server. To fix that I have implemented a little fix in the code. The problem is that this will mess with the mirror update if two players with the same name actually plays on the server and one legitimatly gets a (1) appended.

The code is already using the log() function for all logging instead of print directly. But maybe create a debug flag for easier toggling of log outputs.

Sometimes a player connects which has (1) in their nickname on server join. The problem is that this is their name in the user database, but the name that is used in controllerName variable is without the one and this makes the check weird.