v1.6 FilenameMissingException error? about laravel-zipstream

[jszobody]

Ok the issue was the saveTo, I had been focusing on the source files.

It's fixed, with a test case specifically setup for your scenario:

laravel-zipstream/tests/ZipTest.php

Lines 25 to 36 in 61d0482

	public function testSaveZipOutput()
	{
	file_put_contents("/tmp/test1.txt", "this is the first test file for test run: " . microtime());
	file_put_contents("/tmp/test2.txt", "this is the second test file for test run:" . microtime());
	/** @var ZipStream $zip */
	$zip = Zip::create("my.zip", ["/tmp/test1.txt", "/tmp/test2.txt"]);
	$zip->saveTo("/tmp");
	$this->assertTrue(file_exists("/tmp/my.zip"));
	$this->assertEquals($zip->predictedZipSize(), filesize("/tmp/my.zip"));
	}

'

Version 1.7 is released with this fix.

[jszobody]

That means those files don't exist on disk, or aren't readable. Double check that /tmp/test.pdf and /tmp/test2.pdf are present with proper permissions?

In v1.6 we introduced the ability to create a zip entry from raw data. At the moment you can see the logic used to determine whether a filepath on disk was provided, and if it's not a valid path we assume it's raw data instead:

laravel-zipstream/src/Models/File.php

Lines 55 to 59 in 030a943

	if(file_exists($source)) {
	return new LocalFile($source, $zipPath);
	}
	return new TempFile($source, $zipPath);

The exception you're getting means the above check did not find a valid file on disk, assumed it was raw file data, and passing raw data absolutely requires providing an explicit filename with extension.

Hope that helps, let me know if that doesn't solve the issue.

[it-can]

Files are in place (1.5 works normally)

[it-can]

I double checked, all files exist and still getting this error.

also is this function correct? it returns the filename of the file not a path?

/**
     * @return string
     */
    protected function getDefaultZipPath()
    {
        return basename($this->getSource());
    }

[it-can]

Mmm seems that the code wants to "add" the zipfile to the archive?

$files = [
'/tmp/test.pdf',
'/tmp/test2.pdf',
];

// Zip it
        Zip::create('file.zip', $files)
            ->saveTo(storage_path('app/tmp'));

This will add, test.pdf, test2.pdf and file.zip to the archive. So file.zip does not exists and it tries to add it as a TempFile... Thats producing the error...

I think it has to do with this line

laravel-zipstream/src/ZipStream.php

Line 253 in 030a943

$output = File::make(Str::finish($output, "/") . $this->getName());

[it-can]

@jszobody

[it-can]

Thanks!!