Coder Social home page Coder Social logo

Filename sanitization about laravel-zipstream HOT 2 CLOSED

kw-pr avatar kw-pr commented on July 21, 2024
Filename sanitization

from laravel-zipstream.

Comments (2)

jszobody avatar jszobody commented on July 21, 2024

I often generate zips from dynamic user-provided input, like projects names. I've personally had a lot of issues where zips break because of a character that isn't allowed in a Windows filepath, or even strange zerowidth unicode characters, stuff like that. I decided I wanted to just convert everything to ascii to eliminate any issues with invalid characters.

You can absolutely turn off the ascii sanitization, it's definitely a sledgehammer approach that wouldn't work if you want to allow other character sets. Just consider what you're allowing through in your zip file name, and zip paths.

from laravel-zipstream.

kw-pr avatar kw-pr commented on July 21, 2024

Thanks I finally disabled your escaping and added my own:

$filename = preg_replace('/[^[:alnum:] ._~-]+/u', '_', $filename);

I checked this with the 44k filenames I have in my database.

from laravel-zipstream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.