Comments (7)
I can't reproduce. That code you pasted just gave me a OpI4O73yLqV92K4I5PRU.zip
download file.
Is that download
method in your Controller? Not sure where $this->files
is coming from, but I'm not thinking this is a controller method.
Something else is getting in the way, and I would need to see the controller itself to help you further.
from laravel-zipstream.
What was the solution for this? I'm having the same issue, This is my code:
public function downloadDocumentsV2(int $year, string $type, Collection $documents = null)
{
if (is_null($documents)) {
$documents = $this->getDocumentsForTypeGroupWithYear($year, $type)->get();
}
$zip = Zip::create('package.zip');
foreach ($documents as $document) {
$document = $document->files->first();
$zip->add("s3://". config('filesystems.disks.s3.bucket') . '/' . $document->path, $document->name);
}
return $zip;
}
from laravel-zipstream.
or @jszobody if you have a solution for this 🙂
from laravel-zipstream.
@lucdaalmeijer Is downloadDocumentsV2
a controller method? Any chance it's being returned instead from a Livewire component?
from laravel-zipstream.
yes downloadDocumentsV2
is a controller method and is being returned from an livewire component like this:
return $this->entity->downloadDocumentsV2($this->year, $this->type);
from laravel-zipstream.
That's your issue, you can't return a zip stream from a LiveWire component. LW wants to grab the entire response payload and serialize it inside its own JSON response, you lose all the benefits of streaming out the response (it doesn't start instantly) and LW gets in the way of the filename header.
More explanation:
#34 (comment)
Alternate approach:
#34 (comment)
from laravel-zipstream.
ohw i will look into that, thank you for the insight, response and the alternate approach!
from laravel-zipstream.
Related Issues (20)
- saveTo method has permission denied error on manjaro without webserver HOT 1
- Grant public-read access HOT 1
- Update maennchen/zipstream-php package HOT 2
- Space & Specials Character are being replaced by "%" sign HOT 1
- Compatibility with PHP 8.2 HOT 2
- Always downloading as a html file with incorrect name HOT 4
- Unable to install package. HOT 9
- maennchen/ZipStream-PHP v3 HOT 17
- ZipStream v3 Beta HOT 9
- Unexpected end of Archive HOT 1
- S3File memory leak on calculateFilesize HOT 11
- Cache file size HOT 6
- ErrorException: fopen(): s3:// wrapper is disabled HOT 1
- Filename sanitization HOT 2
- Laravel 10 Support HOT 1
- The package gets http file headers anyway even when filesize prediction is disabled
- Feature request: Check if file exists and/or append $var to filename HOT 3
- Unable to use Zip HOT 1
- Merge zip - source from s3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-zipstream.