Comments (9)
Dear @jszobody,
It works like a charm. Thanks for your great work on this package!
from laravel-zipstream.
Hmm I wanted the AWS credentials to be handled by the underlying aws-sdk-php
package. It looks like I should be creating the S3Client from the pre-wired SDK there.
Can you trying this in S3File real quick:
public function getS3Client(): S3Client
{
if (!$this->client) {
$this->client = resolve('aws')->createClient('s3', [
'region' => $this->getRegion(),
'version' => '2006-03-01'
]);
}
return $this->client;
}
That should use the already configured AWS credentials, and merge the specific S3 region for this file (which may or may not match the default region configured).
I'd prefer to use these default configured credentials rather than storing separate ones just for this package, if possible.
from laravel-zipstream.
If you relied on https://github.com/aws/aws-sdk-php-laravel then you could simply
$s3 = App::make('aws')->createClient('s3');
or
$s3 = AWS::createClient('s3');
Push handling it even further down the chain of command.
from laravel-zipstream.
I should really be using S3MultiRegionClient
for S3, would simplify this a lot.
from laravel-zipstream.
Thanks for your answers. I appreciate it.
Just a note
All suggestions work once aws/aws-sdk-php-laravel
is installed.
Before I had only aws/aws-sdk-php
.
from laravel-zipstream.
Excellent!
from laravel-zipstream.
Hi there!
Still having config issues. it works locally, but not on my Laravel Forge managed server. I've goy aws-sdk-php-laravel installed and configured.
Why not just add the key and secret to the config and use it to instantiate the client if it exists? It would simplify setup a lot.
from laravel-zipstream.
@ianrothmann I just pushed this change, can you try it out? I'm not in a position to test it at the moment. Update your composer.json to use dev-master
to get this un-released change, I want to verify it's all working before I release it.
from laravel-zipstream.
@ambdisp and @ianrothmann This is now done. Version 1.5 caches AWS credentials in the package config file, and will work without the aws/aws-sdk-php-laravel
specific package. (You still need aws/aws-sdk-php
of course).
from laravel-zipstream.
Related Issues (20)
- saveTo method has permission denied error on manjaro without webserver HOT 1
- Grant public-read access HOT 1
- Update maennchen/zipstream-php package HOT 2
- Space & Specials Character are being replaced by "%" sign HOT 1
- Compatibility with PHP 8.2 HOT 2
- Always downloading as a html file with incorrect name HOT 4
- Unable to install package. HOT 9
- maennchen/ZipStream-PHP v3 HOT 17
- The name of the file being downloaded is “download” without extension HOT 7
- ZipStream v3 Beta HOT 9
- Unexpected end of Archive HOT 1
- S3File memory leak on calculateFilesize HOT 11
- Cache file size HOT 6
- ErrorException: fopen(): s3:// wrapper is disabled HOT 1
- Filename sanitization HOT 2
- Laravel 10 Support HOT 1
- The package gets http file headers anyway even when filesize prediction is disabled
- Feature request: Check if file exists and/or append $var to filename HOT 3
- Unable to use Zip HOT 1
- Merge zip - source from s3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-zipstream.