sponchcafe / simfs-core Goto Github PK

Focus function base class seems to lack a virtual destructor to overload.

For more finegrained control over memory and cpu time for components:

1. Memory usage is controlled via the envrionment variable buffer control: Settings has to be added to the component constructor in pysimfs
2. CPU time can be adapted via system nice values (0: max priority - 20: min priority), psutil should do the job
3. Reorganization of the subprocess call may be necessary

Migrate test suite to Catch 2, remove heavy googletest dependency.

The photophysics component produces a readerwriter-queue error indicating that one or more queues are note properly emptied, when the process terminates. Since the error only seems to appear when bleaching is enabled, this might be the set_state_if action handling the box-collision reset stream.

After the heartbeat update, ph2 does not jump to infinite time when terminating, to avoid indefinite heartbeats. Therfore pending collision events are not handled until the end of stream when bleaching is enabled.

The data output however should not be compromised by that.

Solution sketch

• explicitely empty pending streams before terminating

Buffer delays can be controlled via environment variables. A global on-off has to be added.

The linear and nearest interpolation algorithm does not handle points out of the grid range properly.

Add documentation for all components including call signature, parameters, input and output streams and a general description.

Memory usage of simfs_img explodes when using many and dim molecules. Check to see if the algorithm can be improved to handle many molecules better.

Heartbeat timestamps are negative. Usage in heartbeat_action.cpp is confusing.

A single test executable simplifies test coverage generation.