smithsonian / supernovas Goto Github PK

A default

 make

told me I needed doxygen. Should there be a default make that just compiles? Of course it worked after I installed it, but I'd like to argue the default should not.

Not a huge issue, but do you have any thought on whether it would make sense to update the value of AU to the one adopted by the IAU? It's not a huge difference...

149597870.7 
149597870.69098932

Will fix in 1.0.

As we are planning to package SuperNOVAS for Debian and RPMFusion, we will probably want to update the build to make it
easier, e.g.:

• Use CFLAGS / LDFLAGS defined externally (without editing config.mk).

• Set CIO locator file location externally (without editing config.mk).

• Add lib/supernovas.so target (with possibly versioned name).

• Add lib/solsys1.so and lib/solsys2.so targets (bundling the related objects together).

• It's strongly encouraged to add a version to SONAME (even if the .so file name does not contain the version itself). Downstream packaging will typically want it.

I easily get confused with times systems but I think there is a typo in this example in the documentation:

// Calculate the Terrestrial Time (TT) based Julian date of observation (in days)
// Let's say on 2024-02-06 at 14:53:06 UTC.
double jd_tt = julian_date(2024, 2, 6, 14.885) + get_utc_to_tt(leap_seconds) / 86400.0; 
 
// We'll also need the TT - UT1 difference, which we can obtain from what we already
// defined above
double ut1_to_tt = get_ut1_to_tt(jd_tt, dut1);

The first argument to get_ut1_to_tt in the example is TT, but I think it should be leap_seconds according to the documentation of the function itself.

I think there is another error related to the time calculation, specifically on this line in cirs_to_itrs. ut1_to_tt should not be subtracted from jd_tt_low.