Comments (4)
Hi @hannorein,
Thanks for finding the bug. The line you pointed to is definitely not right, although for a slightly different reason than what you noted. Notice, that cirs_to_itrs()
takes a TT-based JD as its input, but then needs to call cel2ter()
with a UT1-based JD argument, which is why ut1_to_tt1
must be subtracted. However, there was indeed a bug, since ut1_to_tt
is in seconds, whereas JD is in days. So correctly, it should be:
cel2ter(jd_tt_high, jd_tt_low - ut1_to_tt / DAY, ...);
from supernovas.
The issue affects itrs_to_cirs()
, tod_to_itrs()
, and itrs_to_tod()
also. I committed and pushed a different fix in the commit 63449f6. I hope that resolves it sufficiently, but let me know if you think there is more to be done.
from supernovas.
I noticed the units don’t work out. But your are right about the UT vs TT
from supernovas.
Given the severity of this bug, I also added the fix directly to the main branch.
from supernovas.
Related Issues (9)
- Typo in example HOT 1
- Numerical value of AU HOT 1
- should it need doxygen by default? HOT 5
- Changes to build to make packaging easier
- SUPERNOVAS_VERSION_STRING ill defined in novas.h
- d_light() bug when called with zero position HOT 1
- Invalid results on some platforms (e.g. ARM, PowerPC) HOT 2
- refract_astro() in v0.9 is incorrect.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from supernovas.