slashbunny / gog-galaxy-plugin-downloader Goto Github PK

Hi, I was trying the integration with steam and the Steam pluging doesn't starts:

I'm using MAC OS Catalina
Steam version plugin version "0.51.1" (ca27391f-2675-49b1-92c0-896d43afa4f8

This is from the logs:

2020-06-21 14:11:49,409 - root - ERROR - Plugin exception
Traceback (most recent call last):
  File "/Applications/GOG Galaxy.app/Contents/Resources/plugin_runner.py", line 35, in <module>
    module = importlib.import_module(filename)
  File "/Applications/GOG Galaxy.app/Contents/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/mliradel/Library/Application Support/GOG.com/Galaxy/plugins/installed/steam_ca27391f-2675-49b1-92c0-896d43afa4f8/plugin.py", line 38, in <module>
    from uri_scheme_handler import is_uri_handler_installed
  File "/Users/mliradel/Library/Application Support/GOG.com/Galaxy/plugins/installed/steam_ca27391f-2675-49b1-92c0-896d43afa4f8/uri_scheme_handler.py", line 28, in <module>
    from CoreServices.LaunchServices import LSCopyDefaultHandlerForURLScheme
ModuleNotFoundError: No module named 'CoreServices'

Consider using "https://api.github.com/repos/${repo}/releases/latest", where ${repo}, for example, is "Slashbunny/gog-galaxy-plugin-downloader", to get latest releases of any plugin that is hosted on github. That would remove the necessity of manual updates at the cost of automatic version lock file and some reliability. So far determining right asset seems simple: there is either only one or it has "win" somewhere in file name.

Also: I do not need all the plugins and provided 'batches' are also not suitable which means i have to keep and manually update my own plugins file which is bothersome. Consider adding an ability to specify only plugin names.

https://github.com/nosyn00b/GOG2_Fanatical_Plugin

v0.0.2 was released a couple of days ago. I assumed this plugin was able to detect new releases automatically?

It seems wrong naming issue - it searches for gog-plugins-downloader-stores.exe but probably should for gog-plugins-downloader.exe

PS C:\Users\thisi> scoop install gog-galaxy-plugin-downloader
>>
Installing 'gog-galaxy-plugin-downloader' (0.2.2) [64bit]
gog-plugins-downloader-v0.2.2.zip (6,0 MB) [==================================================================] 100%
Checking hash of gog-plugins-downloader-v0.2.2.zip ... ok.
Extracting gog-plugins-downloader-v0.2.2.zip ... done.
Linking ~\scoop\apps\gog-galaxy-plugin-downloader\current => ~\scoop\apps\gog-galaxy-plugin-downloader\0.2.2
Creating shim for 'gog-plugins-downloader-stores'.
Can't shim 'gog-plugins-downloader-stores.exe': File doesn't exist.```

Is there a way to skip "Process complete! Press the Enter key to exit..."?

I have a bulk command that updates a number of things and it's quite annoying having to remember to hit enter when it's done updating GOG Galaxy plugins.

Python 3.11 is apparently not liking the 5.x builds of PyYAML for some reason, as far as I can tell. (More specifically one of its dependencies isn't handled well, but it's an upstream issue so no need to go into it here.) I changed the requirements and built with 6.x, seemed to have no impact on functionality and works fine with 3.11 (and should work with any Python ver >2.7, according to the developer).

World's shortest PR incoming for this issue.

Hello.

I downloaded the last version of the repository (0ba914e, not the last official release from Nov 2019), and executing with python works fine, but when i tried to build the exe, that exe doesn't work:

>gog-plugins-downloader.exe
Traceback (most recent call last):
  File "download.py", line 9, in <module>
ModuleNotFoundError: No module named 'yaml'
[4648] Failed to execute script download

The requeriments are satisfied (PyYAML==5.*) and there isn't any error or warning compiling:

>build-win.bat

(...)\gog-galaxy-plugin-downloader-master>pip install pyinstaller
Requirement already satisfied: pyinstaller in c:\python\lib\site-packages (4.2)
Requirement already satisfied: altgraph in c:\python\lib\site-packages (from pyinstaller) (0.17)
Requirement already satisfied: pefile>=2017.8.1 in c:\python\lib\site-packages (from pyinstaller) (2019.4.18)
Requirement already satisfied: setuptools in c:\python\lib\site-packages (from pyinstaller) (49.2.1)
Requirement already satisfied: pywin32-ctypes>=0.2.0 in c:\python\lib\site-packages (from pyinstaller) (0.2.0)
Requirement already satisfied: pyinstaller-hooks-contrib>=2020.6 in c:\python\lib\site-packages (from pyinstaller) (2021.1)
Requirement already satisfied: future in c:\python\lib\site-packages (from pefile>=2017.8.1->pyinstaller) (0.18.2)

(...)\gog-galaxy-plugin-downloader-master>pyinstaller download.py -n gog-plugins-downloader --onefile
216 INFO: PyInstaller: 4.2
223 INFO: Python: 3.9.2
223 INFO: Platform: Windows-10-10.0.19041-SP0
223 INFO: wrote (...)\gog-galaxy-plugin-downloader-master\gog-plugins-downloader.spec
223 INFO: UPX is not available.
239 INFO: Extending PYTHONPATH with paths
['(...)\\gog-galaxy-plugin-downloader-master',
 '(...)\\gog-galaxy-plugin-downloader-master']
254 INFO: checking Analysis
317 INFO: checking PYZ
355 INFO: checking PKG
371 INFO: Building because (...)\gog-galaxy-plugin-downloader-master\build\gog-plugins-downloader\gog-plugins-downloader.exe.manifest changed
371 INFO: Building PKG (CArchive) PKG-00.pkg
2816 INFO: Building PKG (CArchive) PKG-00.pkg completed successfully.
2816 INFO: Bootloader c:\python\lib\site-packages\PyInstaller\bootloader\Windows-64bit\run.exe
2816 INFO: checking EXE
2838 INFO: Building because icon changed
2838 INFO: Building EXE from EXE-00.toc
2854 INFO: Copying icons from ['c:\\python\\lib\\site-packages\\PyInstaller\\bootloader\\images\\icon-console.ico']
3001 INFO: Writing RT_GROUP_ICON 0 resource with 104 bytes
3001 INFO: Writing RT_ICON 1 resource with 3752 bytes
3001 INFO: Writing RT_ICON 2 resource with 2216 bytes
3017 INFO: Writing RT_ICON 3 resource with 1384 bytes
3017 INFO: Writing RT_ICON 4 resource with 37019 bytes
3017 INFO: Writing RT_ICON 5 resource with 9640 bytes
3017 INFO: Writing RT_ICON 6 resource with 4264 bytes
3017 INFO: Writing RT_ICON 7 resource with 1128 bytes
3457 INFO: Updating manifest in (...)\gog-galaxy-plugin-downloader-master\build\gog-plugins-downloader\run.exe.f6mzol3_
3473 INFO: Updating resource type 24 name 1 language 0
3504 INFO: Appending archive to EXE (...)\gog-galaxy-plugin-downloader-master\dist\gog-plugins-downloader.exe
3731 INFO: Building EXE from EXE-00.toc completed successfully.

(...)\gog-galaxy-plugin-downloader-master>COPY gog-plugins.bat dist\
        1 archivo(s) copiado(s).

Thanks.

I just attempted to use Scoop to install this using the command in the Readme, and received the error "Couldn't find manifest for 'gog-galaxy-plugin-downloader'."

I copied and pasted the command twice in order to confirm I wasn't adding any extra spaces or the like.

Hello, I use your plugin since the v0.4 and worked fine all time, but when I launch the v2.1 the first time all went very bad.

1.-The v2.1 can't download anything, for example I deleted steam plugin and it doesn't download it again.
2.-The v2.1 can rename the folders but was very difficult, for example it can rename Steam v1 to Steam ABCDEF, after that made a copy called Steam v1 and the program stop to work, it won't do anything else until that I manually delete the folder Steam v1, after that the program process 1 plug at time.
3.-The plugins Rockstar and Origin had a critical fail and don't worked anymore, I have to manually download it and put it manually, now work again.
4.-After the first execution of v2.1 older versions don't work in any way.
5.-Sometimes the program say something about permissions, but i launch it with admin privileges and the plug's folder has all privileges for all users, system, everyone.

Note: I tried to download it again, use the BAT, restart the PC, rename the exe and folder.

I appreciate so much your work and I understand is a hard job and work in progress, I don't complaint about it, I'm only want to report this issues because your tool is awesome and very useful, I don't know if is just me or someone else have this problems.

Thanks. Have a good day.

Since a number of plugins are currently broken and have manual fixes floating around various forums to kludge them into operation, I thought it'd be nice to have a way to check whether I'd done any of those manual fixes on the plugins I had installed. So I put one together -- the --verify option (short opt -t for "test"; didn't want to use -v since that's traditionally for "verbose" mode and I may end up suggesting that be a flag as well/writing up code around it). Just downloads the listed source for any existing plugins, does a diff, lets you know if it finds discrepancies and if so in what file. Nothin' fancy.

PR incoming for that one shortly as well. (Apologies if I'm doing this wrong; we usually use Bitbucket at work and there it's typical that we make an issue for every PR so there's a place to discuss, so that's what I'm doing here as well -- please lmk if I should quit doing that)

Hello, please can you say me what's the code to download the RetroArch Plugin? I tested every name but the updater crashed every time. This is my actual bat config, I think I have all plugins excepting RetroArch [https://github.com/jshackles/RetroGOG]

gog-plugins-downloader.exe -p battlenet,twitch,discord,itch,wargaming,ffxiv,gw2,minecraft,3ds,n64,nds,nes,ngameboy,ncube,nwii,nwiiu,snes,psp,ps2,uplay,steam,rockstar,psn,paradox,origin,epic,bethesda,vision,test,humble,pathofexile,nswitch

Thanks :)