Rule GreaterThan(0) is not work about validation

[eclipxe13]

You are right, a quick workaround is to set the rule with the non-minimal sintax:
Change '0' to 'min=0'.

This is because var_dump((bool) '0'); // bool(false) and the developer use a lot of simple string to boolean comparisons.

[sergiobelya]

@eclipxe13 @adrianmiu Thanks for your work.
There are doubts that ValueValidator::parseRule($ruleAsString) will not process parameter "0".
But I can check up it not earlier than Monday, January 29th.

[eclipxe13]

@sergiobelya You are right. ValueValidator::parseRule has the same problem. I don't know why it has to evaluate to truly. anyhow AbstractRule already know how to handle with this. I think that you can use the same workaround: change "0" to "min=0".

I encourage you to try to fix this. If you want to we can chat about it. If you can't, or don't want to, tell me and I make the tests and a PR with the fix.

[sergiobelya]

@eclipxe13 I can assume that it's enough to correct the line https://github.com/siriusphp/validation/blob/2.2.0/src/ValueValidator.php#L220
as indicated in my first comment.
But I can be wrong.
I can try to fix this and add the tests, but with the tests there may be problems. Nevertheless, I will try.

[eclipxe13]

Inside the tests folder there is a file called ValueValidarorTest.php Your test should be in that file. Add a method to the class with your case and your expected response. See the other methods as example. Would you like to Google hangout to help you with this? El 27 ene. 2018 4:26 AM, "Sergei Belyakov" <[email protected]> escribió: @eclipxe13 <https://github.com/eclipxe13> I can assume that it's enough to correct the line https://github.com/siriusphp/validation/blob/2.2.0/src/ ValueValidator.php#L220 as indicated in my first comment. But I can be wrong. I can try to fix this and add the tests, but with the tests there may be problems. Nevertheless, I will try. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNUpAj9NOB4HccD18t3BBcm6S7Q1Tvjks5tOvnqgaJpZM4PytLQ> .

[adrianmiu]

Fixed. Thank you @sergiobelya

[sergiobelya]

And thank you @eclipxe13 @adrianmiu