Regex pattern containing braces parced incorrectly about validation

[adrianmiu]

Unfortunately, the syntactic sugar implementation makes it impossible to use braces.
http://www.sirius.ro/php/sirius/validation/syntactic_sugar.html shows that besides the validator options you can pass the error message in braces.

A more complex algorithm is needed to make that happen but I am very busy at the moment. I am accepting PRs though :)

[velosipedist]

I understood about string definitioins of validators, but why not to support passing of validator instances?

[adrianmiu]

I haven't read your comment closely enough to see you asked for validator instances. I haven't done it because I haven't thought about it. The value proposition of such feature is very small IMHO. You don't have to use the syntactic sugar to add multiple rules and use the "verbose way".

$validator->add('postal_code', array(
     array('required'),
     array('length', array(4,10)),
     array('regex', array('/[0-9 ]+/'))
));

http://www.sirius.ro/php/sirius/validation/syntactic_sugar.html (point 4.)

[velosipedist]

Yeaah, thanks :) It is absolutely enough.

[velosipedist]

Just checked your solution, it work, but Rule writes passed pattern to options[0] instead of options['pattern']. And therefore, it will never be passed correctly, because it seeks only for options['pattern'].

Here where the bug will happen: https://github.com/siriusphp/validation/blob/master/src/Rule/Regex.php#L20

[dam2k]

this one is wrong !
...

 array('regex', array('/[0-9 ]+/'))

...

Should be like this:

 array('regex', '/[0-9 ]+/')