RequiredWith and extra validation not working as expected about validation

[adrianmiu]

Hi.

Unfortunately this is a bug. I will try to fix it asap but I'm a bit swamped at the moment.
If you have PR i'd be happy to accept it :)

[pachico]

Not sure when I'll have time to look at it during the next 2 weeks. :(

[eclipxe13]

As far I can see the problem is not inside rules. The problem is inside ValueValidator::validate:

The current logic is:

1. determine if the rules set contains a Required rule ($isRequired).
2. if is not required ! $isRequired and value is not set then exit and don't evaluate anything.
3. evaluate each rule
   1. perform rule validation
   2. exit the loop if $isRequired and the rule fail
4. return if there were errors

The problem is that in step 3 it is expected that all the rules validate positive. So, for the set of requiredWith & number, the first evaluate to true but the second evaluates to false.

I think I solve this issue by making a two step evaluation:

1. Evaluate each rule that is an instance of Required.
2. Exit if is not required ! $isRequired and value is not set.
3. Evaluate each rule that is a not an instance of Required.
4. Return if there were errors.

I'm preparing a PR for this... stay tuned.

[eclipxe13]

Final steps of fix are:

1. Evaluate each rule that is an instance of Required, return false on failure.
2. Exit if value is not set (required rules has been evaluated previously).
3. Evaluate each rule that is a not an instance of Required.
4. Return if there were errors.

PR #44 was created

[adrianmiu]

@eclipxe13 Thank you for the PR!