sfmict / mountsjournal_classic Goto Github PK

Environment

• Addon version: v4.4.4
• WoW version: 4.4.0 (Cata Classic)

Steps to reproduce

Login

Expected Behaviour

Actual Behaviour

Debug Output

4x MountsJournal/MountsJournal.toc:41 Error loading MountsJournal/components/filter/Rarity.lua

Screenshots

Environment

• Addon version: v3.4.19
• WoW version: 3.4.0 (build 46248)

Steps to reproduce

1. Attempt to use keybind to mount in an Arena

Expected Behaviour

1. Character casts and is successfully mounted

Actual Behaviour

1. Addon throws an error and character is left unmounted; No cast is ever performed.

Debug Output

72x MountsJournal\Mounts-Mounts.lua:482: Usage: local info = C_Map.GetMapInfo(uiMapID)
[string "=[C]"]: in function `GetMapInfo'
[string "@MountsJournal\Mounts-Mounts.lua"]:482: in function `setMountsList'
[string "@MountsJournal\Mounts-Mounts.lua"]:603: in function `setFlags'
[string "@MountsJournal\mixins/MacroMixin.lua"]:375: in function `getMacro'
[string "@MountsJournal\mixins/MacroMixin.lua"]:454: in function <MountsJournal\mixins/MacroMixin.lua:451>

Locals:
(*temporary) = nil

Screenshots

N/A

Environment
Addon version: v3.4.20
WoW version: 3.4.0 (build 46248)

Steps to reproduce
Pruchasing X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino and using them on Chinese Realms .

Expected Behaviour
X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino should be displayed in the collected list.

Actual Behaviour
X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino are not in the collected list after use them. (see the screenshots below, I have 108 mounts in total but only displayed 105 collected in my list)

Screenshots

Environment

• Addon version: 3.4.27
• WoW version: 3.4.1

Not sure if you can't do this because you are running up against character limits in your generated macros.

It would be great if your macros could handle falling back to a default ground mount for the Dalaran use case.

/castrandom [flyable, nomounted]  Black Proto-Drake
/castrandom [nomounted] Swift White Hawkstrider

This allows a single key press to mount up in any situation (obviously not accounting for the larger complexities you are checking for when building your macros.

Environment

• Addon version: 3.4.33
• WoW version: WotLK 3.4.3.51666

no actual stels. functionality is not working

when indoors or combat and press the macro, hunter does not switch to cheetah but getting error you have no favorite mounts. You cannot do that when moving

Actual Behaviour

no lua errors are given

Hello,

Kalu'ak Whalebone Glider can be used as a ground mount too, but I cannot summon it by the addon.

9x ...rface\AddOns\MountsJournal\mixins/CompanionMixin.lua:64: attempt to index field 'petForMount' (a nil value)
[string "@interface\AddOns\MountsJournal\mixins/CompanionMixin.lua"]:64: in function `refresh'
[string "@interface\AddOns\MountsJournal\mixins/CompanionMixin.lua"]:46: in function <...rface\AddOns\MountsJournal\mixins/CompanionMixin.lua:44>

Locals:
self = {
0 =
journal = MountsJournalFrame {
}
onShow = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:42
onLoad = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:9
infoFrame = {
}
refresh = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:62
event = defined @interface\AddOns\MountsJournal\Util.lua:50
onEvent = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:39
mounts = MountsJournal {
}
off = defined @interface\AddOns\MountsJournal\Util.lua:22
highlight = {
}
arrow = {
}
border = {
}
bg = {
}
onClick = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:53
on = defined @interface\AddOns\MountsJournal\Util.lua:6
}
spellID = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'petForMount' (a nil value)"
petRandomIcon = "MountsJournal/textures/INV_Pet_Achievement_CaptureAPetFromEachFamily_Battle"

After updating the addon, the mounts no longer show up. The macro still seems to summon mounts properly but it doesn't recognize you have mounts. Screen shows information on getting mounts at level 20. Have tried to uninstall and reinstall via CurseForge app. No resolution.

Hello,

Currently if I'm in Ghost Wolf and click Summon1/2 it cast a mount.
But instead I just want to cancel the form on the first click.
And cast mount only the second click (when I'm no longer in form).

I would like to request such a setting.

Environment

• Addon version: v3.4.17
• WoW version: 3.4.0 (46158)

See attached image - highlighted area is showing as "You can't use that here", but manually mounting a ground mount from the pet tab works fine. Using MoutsJournal Summon 1 with a singular ground and flying mount enabled.

MountsJournal successfully uses a ground mount

Error message "You can't use that here"

N/A

Environment

• Addon version: 3.4.27
• WoW version: WotLK Classic 3.4.1 (48340)

Current Functionality

If you enter a flyable area on a ground mount and you want to go on a flying mount, then you need to press macro once to dismount and again to get on flying mount.

Desired functionality

Add an option that lets you do both dismount+mount flyable mount on 1 macro press if it detects you're on a ground mount in a flyable area.

Environment

• Addon version: 4.4.1
• WoW version: 4.4.0 (54525)

Steps to reproduce

1. Be a warlock that is level 20-39 and has mount training
2. Make sure "Dreadsteed" is part of your currently eligible random selection
3. Do "/click MountsJournal_Mount
4. Note that it will try to Summon Dreadsteed

Expected Behaviour

It should not even try to summon Dreadsteed without being level 40+, instead summoning any other viable mount as usual

Actual Behaviour

It attempts to Summon Dreadsteed and fails. Repeated attempts will correctly reroll to another mount or may try Dreadsteed again.

I imagine that this is caused by the fact that Summon Dreadsteed is a spell that requires a specific level to use unlike most other mounts. It is likely that the paladin mount is also affected by this issue but I cannot confirm.

Environment

• Addon version:
• WoW version:

Steps to reproduce

Load WoW Classic Wrath

Expected Behaviour

Mounts index in addon
macro summon mounts

Actual Behaviour

Addon not loading mounts
macro not mounting character gives error about having a fav mount set.

Debug Output

Date: 2023-10-10 17:53:36
ID: 4
Error occured in: Global
Count: 1
Message: Interface/AddOns/MountsJournal/Mounts.lua line 297:
table index is nil
Debug:
[string "=[tsm error check]"]:1: in main chunk
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@Interface/AddOns/MountsJournal/Mounts.lua"]:297: updateIndexBySpellID()
[string "@Interface/AddOns/MountsJournal/Mounts.lua"]:178: ?()
[string "@Interface/AddOns/MountsJournal/Mounts.lua"]:8:
Interface/AddOns/MountsJournal/Mounts.lua:8
Locals:

AddOns:
Swatter, v3.4.6977 (SwimmingSeadragon)
WowheadLooter, v30403
342Fix, v3.4.2
AllTheThings, vDF-3.6.7
AtlasLootClassic, vv3.1.3
AtlasLootClassicData, vv3.1.3
AtlasLootClassicDungeonsAndRaids, vv3.1.3
AucAdvanced, v3.4.6952 (SwimmingSeadragon)
AucFilterBasic, v3.4.6941 (SwimmingSeadragon)
AucStatHistogram, v3.4.6928 (SwimmingSeadragon)
AucStatiLevel, v3.4.6913 (SwimmingSeadragon)
AucStatPurchased, v3.4.6910 (SwimmingSeadragon)
AucStatSimple, v3.4.6911 (SwimmingSeadragon)
AucStatStdDev, v3.4.6912 (SwimmingSeadragon)
AucUtilFixAH, v3.4.6914 (SwimmingSeadragon)
AutoBarWrath, v3.04.1.01
AutoCombatLogger, v10.1.1
BagBrother, v
Bagnon, v10.1.13
BeanCounter, v3.4.6983 (SwimmingSeadragon)
BetterFishing, v1.1.18
BuffomatClassic, v2023.8.1-955e9415
DBMCore, vd87d92f
DBMStatusBarTimers, vd87d92f
DejaClassicStats, v30402r1
Details, v#Details.20230913.11914.155
DetailsCompare2, v
DetailsEncounterDetails, v
DetailsRaidCheck, v
DetailsTinyThreat, v
DetailsVanguard, v
ElvUI, v13.42
ElvUILibraries, v13.42
Enchantrix, v3.4.6979 (SwimmingSeadragon)
FojjiCore, v
Gargul, v6.2.6
GatherMate2, v1.47.2-classic
GatherMate2GasClouds, v1.8
GuildRosterManager, v1.989
Informant, v3.4.6980 (SwimmingSeadragon)
ItemRack, v3.75
LeatrixMaps, v3.0.153.alpha.1
LeatrixPlus, v3.0.152
MountsJournal, vv3.4.31
OmniCC, v10.1.2
Questie, v8.10.5
RatingBuster, v
RCLootCouncilClassic, v0.19.0
SharedMedia, v3.1.1-199
SharedMediaMyMedia, v
SlideBar, v3.4.6919 (SwimmingSeadragon)
Stubby, v3.4.6920 (SwimmingSeadragon)
TidyPlatesThreatPlates, v11.1.29
TomTom, vv3.5.2-release
TradeSkillMaster, vv4.13.14
TradeSkillMasterAppHelper, vv4.13
VuhDo, v3.153-wotlkc
VuhDoOptions, v3.153-wotlkc
WeakAuras, v5.8.1
BlizRuntimeLib v3.4.3.51666(US)
(ck=72b)

Screenshots

Environment

• Addon version: 4.4.7
• WoW version: 4.4.0

Steps to reproduce

1. Mark the Abyssal Seahorse as an aquatic mount so it gets used by default in Vash'jir
2. Try to mount while swimming in any water that is not Vash'jir

Expected Behavior

Expected maybe not, but desirable yes 😅
Aquatic mount used in Vash'jir.
Default behavior when swimming or submerged in other zones.

Actual Behavior

Seahorse set as an aquatic mount:

• Correct behavior in Vash'jir,
• Wrong behavior in other waters (makes it impossible to use Mounts Journal Classic keybinds / macros to mount in water and ride or fly out of it)

Seahorse not set as an aquatic mount:

• Correct behavior in non-Vash'jir waters.
• Wrong behavior in Vash'jir (generic flyable/non-flyable status applies)

Debug Output

This is a logic "bug" there are no Lua errors

Screenshots

Environment

• Addon version: 3.4.23
• WoW version: 3.4.0.46248

Desired functionality

Still having issues with my Druid and the following use case:

• My Flying mount is Swift Flight Form, no other Flying Mount

• I have 100% ground mounts learned and need to be able to use them in various places (Dalaran, Azeroth, BGs, etc)

It seems it's one or the other for me. I've tried a bunch of options in Class Settings > Druid with the "Use this macros instead of mounts" option, as well as Enabling one or both of the Macros but am never to able to get things to quite work as expected.

The closest I can get is when I am moving I can get that one macro to work and cast Swift Flight Form when I am moving, but I'd say that's not exactly ideal in my opinion. I'd like an option for Druids where it works just like regular MountsJournal would on other classes, except I can treat my Swift Flight Form (or Flight Form in general) as a mount according to MountsJournal and cast it appropriately when possible.

Really I cannot thank you enough for this Addon. It's just part of Wrath Classic for me now, it feels like what we should have in the game. As I'm getting more time to go through different Alts of mine now in Wrath, this issue is becoming a bit more problematic so I wanted to throw something out there. Please let me know if there's more information you need from me here!

(Note: Comment posted to Curseforge as well, decided it may be better to open Feature Request here instead/as well for your own tracking purposes - https://www.curseforge.com/wow/addons/mountsjournal_classic?comment=47 )

Environment

• Addon version: 3.4.35
• WoW version: 3.4.3

Steps to reproduce

Load the game and show the Collections Interface.

Expected Behaviour

Actual Behaviour

Debug Output

1x MountsJournal/templates.xml:861 Couldn't find inherited node: MJCalendarPrev

1x MountsJournal/templates.xml:871 Couldn't find inherited node: MJCalendarNext

Screenshots

The current version of MountsJournal_Classic - v4.4.17 as per CurseForge - apparently references LUA files which only exist in the retail version of MountsJournal. On starting Cataclysm Classic and entering the world, I get these LUA errors:

MountsJournal/components/components.xml:7 Error loading MountsJournal/Help.lua
MountsJournal/components/components.xml:13 Error loading MountsJournal/SummonPanel.lua
MountsJournal/components/filter/filter.xml:11 Error loading MountsJournal/Rarity.lua

Environment

• Addon version: 3.4.32
• WoW version: 3.4.3

Level 80 character (Warlock), 38 mounts collected. Addon macro says no valid favorite mounts, /mj shows "You can learn riding..."

Have the ability to select favorite mounts.

No mounts shown, No favorite mounts

No debug output

settings are not stored per-character. when you select mounts on one character it affects all characters.