Coder Social home page Coder Social logo

sfmict / mountsjournal_classic Goto Github PK

View Code? Open in Web Editor NEW
1.0 1.0 1.0 613 KB

Addon makes it possible to sort mounts on waterfowl, flying, ground and allows to use in suitable conditions (random mount summoning).

License: Apache License 2.0

Lua 100.00%
world-of-warcraft world-of-warcraft-addon wow wow-addon wow-classic

mountsjournal_classic's People

Contributors

sfmict avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

adamk33n3r

mountsjournal_classic's Issues

Mounts not showing up

After updating the addon, the mounts no longer show up. The macro still seems to summon mounts properly but it doesn't recognize you have mounts. Screen shows information on getting mounts at level 20. Have tried to uninstall and reinstall via CurseForge app. No resolution.

Don't cast mount if in Ghost Wolf

Hello,

Currently if I'm in Ghost Wolf and click Summon1/2 it cast a mount.
But instead I just want to cancel the form on the first click.
And cast mount only the second click (when I'm no longer in form).

I would like to request such a setting.

X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino issue on Chinese Realms

Environment
Addon version: v3.4.20
WoW version: 3.4.0 (build 46248)

Steps to reproduce
Pruchasing X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino and using them on Chinese Realms .

Expected Behaviour
X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino should be displayed in the collected list.

Actual Behaviour
X-51 Nether-Rocket X-TREME, Magic Rooster Egg and Wooly White Rhino are not in the collected list after use them. (see the screenshots below, I have 108 mounts in total but only displayed 105 collected in my list)

Screenshots
image
image
image
image
image
image
image

Druids may treat Swift Flight Form as a Mount

Environment

  • Addon version: 3.4.23
  • WoW version: 3.4.0.46248

Desired functionality

Still having issues with my Druid and the following use case:

  • My Flying mount is Swift Flight Form, no other Flying Mount

  • I have 100% ground mounts learned and need to be able to use them in various places (Dalaran, Azeroth, BGs, etc)

It seems it's one or the other for me. I've tried a bunch of options in Class Settings > Druid with the "Use this macros instead of mounts" option, as well as Enabling one or both of the Macros but am never to able to get things to quite work as expected.

The closest I can get is when I am moving I can get that one macro to work and cast Swift Flight Form when I am moving, but I'd say that's not exactly ideal in my opinion. I'd like an option for Druids where it works just like regular MountsJournal would on other classes, except I can treat my Swift Flight Form (or Flight Form in general) as a mount according to MountsJournal and cast it appropriately when possible.

Really I cannot thank you enough for this Addon. It's just part of Wrath Classic for me now, it feels like what we should have in the game. As I'm getting more time to go through different Alts of mine now in Wrath, this issue is becoming a bit more problematic so I wanted to throw something out there. Please let me know if there's more information you need from me here!

(Note: Comment posted to Curseforge as well, decided it may be better to open Feature Request here instead/as well for your own tracking purposes - https://www.curseforge.com/wow/addons/mountsjournal_classic?comment=47 )

[Feature Request] Add option for dismount+flight mount cast if on ground mount in flyable area

Environment

  • Addon version: 3.4.27
  • WoW version: WotLK Classic 3.4.1 (48340)

Current Functionality

If you enter a flyable area on a ground mount and you want to go on a flying mount, then you need to press macro once to dismount and again to get on flying mount.

Desired functionality

Add an option that lets you do both dismount+mount flyable mount on 1 macro press if it detects you're on a ground mount in a flyable area.

Section of Underbelly Unable to Mount

Environment

  • Addon version: v3.4.17
  • WoW version: 3.4.0 (46158)

See attached image - highlighted area is showing as "You can't use that here", but manually mounting a ground mount from the pet tab works fine. Using MoutsJournal Summon 1 with a singular ground and flying mount enabled.

MountsJournal successfully uses a ground mount

Error message "You can't use that here"

N/A

Untitled

Update generated macros to fallback to ground mount in Dalaran.

Environment

  • Addon version: 3.4.27
  • WoW version: 3.4.1

Not sure if you can't do this because you are running up against character limits in your generated macros.

It would be great if your macros could handle falling back to a default ground mount for the Dalaran use case.

/castrandom [flyable, nomounted]  Black Proto-Drake
/castrandom [nomounted] Swift White Hawkstrider

This allows a single key press to mount up in any situation (obviously not accounting for the larger complexities you are checking for when building your macros.

Cannot mount in Arenas

Environment

  • Addon version: v3.4.19
  • WoW version: 3.4.0 (build 46248)

Steps to reproduce

  1. Attempt to use keybind to mount in an Arena

Expected Behaviour

  1. Character casts and is successfully mounted

Actual Behaviour

  1. Addon throws an error and character is left unmounted; No cast is ever performed.

Debug Output

72x MountsJournal\Mounts-Mounts.lua:482: Usage: local info = C_Map.GetMapInfo(uiMapID)
[string "=[C]"]: in function `GetMapInfo'
[string "@MountsJournal\Mounts-Mounts.lua"]:482: in function `setMountsList'
[string "@MountsJournal\Mounts-Mounts.lua"]:603: in function `setFlags'
[string "@MountsJournal\mixins/MacroMixin.lua"]:375: in function `getMacro'
[string "@MountsJournal\mixins/MacroMixin.lua"]:454: in function <MountsJournal\mixins/MacroMixin.lua:451>

Locals:
(*temporary) = nil

Screenshots

N/A

Bug Sack - Addon Error

9x ...rface\AddOns\MountsJournal\mixins/CompanionMixin.lua:64: attempt to index field 'petForMount' (a nil value)
[string "@interface\AddOns\MountsJournal\mixins/CompanionMixin.lua"]:64: in function `refresh'
[string "@interface\AddOns\MountsJournal\mixins/CompanionMixin.lua"]:46: in function <...rface\AddOns\MountsJournal\mixins/CompanionMixin.lua:44>

Locals:
self = {
0 =
journal = MountsJournalFrame {
}
onShow = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:42
onLoad = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:9
infoFrame = {
}
refresh = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:62
event = defined @interface\AddOns\MountsJournal\Util.lua:50
onEvent = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:39
mounts = MountsJournal {
}
off = defined @interface\AddOns\MountsJournal\Util.lua:22
highlight = {
}
arrow = {
}
border = {
}
bg = {
}
onClick = defined @interface\AddOns\MountsJournal\mixins/CompanionMixin.lua:53
on = defined @interface\AddOns\MountsJournal\Util.lua:6
}
spellID = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'petForMount' (a nil value)"
petRandomIcon = "MountsJournal/textures/INV_Pet_Achievement_CaptureAPetFromEachFamily_Battle"

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.