Coder Social home page Coder Social logo

Comments (4)

ator-dev avatar ator-dev commented on June 1, 2024 1

Thanks for letting me know, and well done for finding and testing a bug. This is definitely related to a fundamental issue with 'search highlighter' extensions, including MMS: it works by essentially breaking apart bits of text inside webpages to insert highlight tags, so any webpage script which requires the structure to be exactly as expected will probably break something.

Unfortunately this even happens on DuckDuckGo - hovering over or focusing a result makes the URL look mixed up if it was highlighted. There's another site I know of which looks vile after highlighting, because the highlight elements end up inserted into code previews. The good news is I'm working on a new algorithm based on the brand new 'Houdini' paint APIs, which works without changing any elements - you can see my progress in this branch, but sadly it will take some time for Firefox to implement the APIs.

Could you link the website domain please? I can't find one that does this, and would be interested to know how it's happening to what looks like a <textarea>.

from mark-my-search.

vatterspun avatar vatterspun commented on June 1, 2024

Could you link the website domain please? I can't find one that does this, and would be interested to know how it's happening to what looks like a <textarea>.

Sent an email to the one listed on your main page.

from mark-my-search.

ator-dev avatar ator-dev commented on June 1, 2024

I have now tested it and discovered that adding text inside a <textarea> element is a valid way to set its default value. This is the method used by the website you linked. Mark My Search was adding an element to the text, causing it not to be processed.

I have added <textarea> to the blocked elements for 1.10.3 and confirmed that this fixes the problem. There is no disadvantage since HTML is ignored for them anyway. Thanks for the report!

from mark-my-search.

ator-dev avatar ator-dev commented on June 1, 2024

Following up on my comment about how Mark My Search operates (breaking apart websites): Progress on the "paint" branch is now nearing completion. Progress and information can be viewed in #71, which will be merged once acceptably stable.

Performance gains range from mediocre to vast, and essentially make Mark My Search usable even for tasks such as highlighting the letters of the alphabet. As far as I know no other search highlighter is capable of this, and certainly none can highlight webpages with no damage or data loss.

Needless to say, I am very happy with this progress and will probably make a Product Hunt announcement to raise awareness (:

from mark-my-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.