Comments (4)
Thanks for letting me know, and well done for finding and testing a bug. This is definitely related to a fundamental issue with 'search highlighter' extensions, including MMS: it works by essentially breaking apart bits of text inside webpages to insert highlight tags, so any webpage script which requires the structure to be exactly as expected will probably break something.
Unfortunately this even happens on DuckDuckGo - hovering over or focusing a result makes the URL look mixed up if it was highlighted. There's another site I know of which looks vile after highlighting, because the highlight elements end up inserted into code previews. The good news is I'm working on a new algorithm based on the brand new 'Houdini' paint APIs, which works without changing any elements - you can see my progress in this branch, but sadly it will take some time for Firefox to implement the APIs.
Could you link the website domain please? I can't find one that does this, and would be interested to know how it's happening to what looks like a <textarea>.
from mark-my-search.
Could you link the website domain please? I can't find one that does this, and would be interested to know how it's happening to what looks like a <textarea>.
Sent an email to the one listed on your main page.
from mark-my-search.
I have now tested it and discovered that adding text inside a <textarea> element is a valid way to set its default value. This is the method used by the website you linked. Mark My Search was adding an element to the text, causing it not to be processed.
I have added <textarea> to the blocked elements for 1.10.3 and confirmed that this fixes the problem. There is no disadvantage since HTML is ignored for them anyway. Thanks for the report!
from mark-my-search.
Following up on my comment about how Mark My Search operates (breaking apart websites): Progress on the "paint" branch is now nearing completion. Progress and information can be viewed in #71, which will be merged once acceptably stable.
Performance gains range from mediocre to vast, and essentially make Mark My Search usable even for tasks such as highlighting the letters of the alphabet. As far as I know no other search highlighter is capable of this, and certainly none can highlight webpages with no damage or data loss.
Needless to say, I am very happy with this progress and will probably make a Product Hunt announcement to raise awareness (:
from mark-my-search.
Related Issues (20)
- [Feature Request] PDF highlighting
- [Feature Request] Search results menu HOT 1
- Not working nicely with Notion HOT 9
- Scrolling to the wrong position HOT 1
- As a user I want highlight parity across text/image/video search pages ENHANCEMENT HOT 8
- Restore keywords when restoring last browser session
- [Feature Request] Go to previous match when Shift clicking word HOT 2
- [Bug] lag on some pages? HOT 10
- [Feature Request] Do not inherit searchs on some pages HOT 1
- [Bug] Auto remove _ from highlight candidate HOT 2
- [Feature Request] Add new search candidate to current highlight one? HOT 4
- It breaks LinkedIn search page. HOT 4
- Not working on Chrome and Brave HOT 7
- QOL Suggestions HOT 4
- Background removed with painter
- Do these lines have their parameters crossed? HOT 1
- New highlight method HOT 6
- Do not separate words and reset default options? HOT 2
- [Features] Customization of UI, synonyms, disabling on certain sites and disable automatic on HOT 3
- Automatically turns on on Google Translate HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mark-my-search.