As a user I want highlight parity across text/image/video search pages ENHANCEMENT about mark-my-search

[ldexterldesign]

👏

After testing, for image results seems to function fully in google.com/search but not in search.brave.com..?:

Hope this helps

Sincerely

PS Unsure of the search engine support - be interested to know or have something in the README..?

[ldexterldesign]

Glad to help 🙂

Ya, having a checklist of supported websites should help manage user expectation and encourage them to a) submit new websites and/or b) report issues for the supported websites

You're brave to go beyond search engines (e.g. amazon, ebay, reddit, netflix) as it could be opening a can of worms 😱 - perhaps add a README submission instruction or create a dedicated issue to gauge interest or both..?

Cheers

[ator-dev]

Hi, no worries about the brevity! Thank you for reporting this issue, it has come to my attention before but I finally managed to solve it*. The fix will be published in version 1.13.4.

Fixed by #114

*Note that no highlighting model can be perfect; however, Mark My Search now does extremely well at responding to interference with its highlighting.

[ldexterldesign]

👍👍

[ator-dev]

Shipped with 1.13.4, now available in the Chrome Web Store and pending for Edge (Firefox version to be updated when ported).

[ator-dev]

Hey,

I have some good news! I looked into your new issue (this 'Brave images' problem is different but related to the original one you reported), and determined it was another programming flaw in the CLASSIC highlighter.

I was not only able to fix the problem - making the highlighter work as intended everywhere - but also massively optimised it, and in the process made scroll markers able to update much more quickly. You should see improvements in many areas of use when this update ships (in 1.13.5).

---

As for search engine support, the idea has always been that every search engine is supported. That's how I explain MMS to people, and it's important to me that we don't rely on 'special cases'. However, it is becoming clear that in practice, some sites just don't work as intended.

What do you think about having a list of search engines which are officially supported? "Officially" meaning it may work in other places, but it is guaranteed to be tested and designed for those ones.

Examples (I know these to work reasonably well):

• DuckDuckGo
• Brave
• Ecosia
• Google
• Bing
• Yahoo!
• Yandex
• Reddit search
• eBay search
• Amazon search
• Netflix search
• (would probably add more)

[ator-dev]

Oops, automatically closed. I won't reopen for now because I think the issue was solved, but please let me know if it persists after upgrading to 1.13.5 or later (currently pending review on Chrome Web Store).

Thanks very much for your input, I like the idea of maintaining a list of "supported" search engines and will certainly look into presenting one here! I will also weigh up the benefits of including site searches (like reddit).

[ator-dev]

Note: unfortunately I made a critical mistake in #116, and will need to wait for it to finish review in CWS before I can push 1.13.6 which will bring the improvements along with a fix for the mistake (#117).