Coder Social home page Coder Social logo

Comments (4)

ator-dev avatar ator-dev commented on June 14, 2024 1

I know what you mean, but I'm not keen on adding an extra item to the context menu. Unfortunately, if you have more than one item they get pushed into a sub-menu, so every time you wanted to use one you'd have to:

right click > Mark My Search > Highlight Selection

This would also prevent being able to press H after right-clicking as a shortcut.

Maybe we could have two settings? One option to enable Highlight Selection, another to enable Highlight Only Selection.

from mark-my-search.

tmpm697 avatar tmpm697 commented on June 14, 2024 1

Maybe we could have two settings? One option to enable Highlight Selection, another to enable Highlight Only Selection.

yes, that's sound good, same convenience, require user to press keys to enable the function could kill the purpose, and user's preference can be different.

from mark-my-search.

ator-dev avatar ator-dev commented on June 14, 2024

I agree, the current system is inconvenient. Currently we have two ways of taking keywords from the user selection:

  • Configured activation shortcut (e.g. Alt+M) replaces keywords with selected keywords, if there is a selection.
  • Context menu item (Highlight Selection) replaces keywords with selected keywords, if there is a selection.

As you can see, they do the same thing. Perhaps it would make more sense for Highlight Selection to behave differently, as you suggest, and for Alt+M to be the way of replacing keywords entirely.

If the user does not know about Alt+M however, this would make it difficult to replace keywords. Maybe the search-keywords-replace button could be made to show up on other pages too, except offering to delete all keywords?

image

When instead of deleting it would be replacing with search keywords (like here), the button could indicate this with a ...

from mark-my-search.

tmpm697 avatar tmpm697 commented on June 14, 2024

We can have two options in right mouse context menu:

1. Highlight Selection
2. Reset & Highlight Selection
  1. Will just append/add/plus the candidate to current marks array.
  2. Reset the marks array then add the candidate.

from mark-my-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.