Do Not Merge WIP for GitHub
License: MIT License
Do not merge WIP pull request!
Disables "Merge pull request" button while ANY of the following is true:
[wip] or [WIP] or [Do Not Merge] or [DNM] in the title of the pull request
orwip, Do Not Merge or DNM (Case insensitive) as a tag to your pull requestCopyright (c) 2014 sanemat. Licensed under the MIT license.
CC BY-ND 3.0 icons8
![dependabot-preview[bot] avatar](https://avatars.githubusercontent.com/in/2141?v=4 "dependabot-preview[bot]")
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
This extension's icon is default icon of generator-chrome-extension.
So, I want unique icon for distinction.
Thank you.
before:
$ tree dist/
dist/
├── _locales
│ └── en
│ └── messages.json
├── bower_components
│ └── jQuery
│ └── dist
│ └── jquery.min.js
├── images
│ ├── icon-128.png
│ └── icon-16.png
├── manifest.json
├── options.html
├── scripts
│ ├── background.js
│ ├── contentscript.js
│ └── options.js
└── styles
└── main.css
after(I plan) (modified 2014-07-05 14:29)
dist/
├── _locales
│ └── en
│ └── messages.json
├── bower_components
│ └── jQuery
│ └── dist
│ └── jquery.min.js
├── images
│ ├── icon-128.png
│ └── icon-16.png
├── manifest.json
├── options.html
├── scripts
│ ├── background.js
│ ├── contentscript.js
│ └── options.js
└── styles
├── main.css
├── background.css
├── contentscript.css
└── options.css
Does not disable button.
- 2014-2015
+ 2014Check files whether exists or not.
I reload page, then I can't hit merge button.
Hello,
Would you mind adding a license to your project? Thanks!
I noticed that this is taking ~80mb of ram.
I think I've seen it take over 100mb.
It is the extension that takes up the most ram on my machine.
Haven't had the chance to look into extensions that also manipulate the screen (e.g.: "avatars for github" which takes 11mb)
Have you gone into process monitor and noticed a high memory footprint for this extension?
Thanks,
Keenan
Have you considered making this into a Github App? I'm looking for something like this (don't merge if there is a WIP label on the PR), but it's not reasonable to ask my team to all download an extension. If this could go in a status check, we would use it extensively.
Use http.STATUS_CODES instead of node-status-codes
Context
#233
Stack Trace
scripts/contentscript.js:12 (anonymous function)
chrome.runtime.sendMessage({from: 'content', subject: 'localStorage'}, function(response){
Remove coffee
Remove bower
Does the fixup keyword detection on work on the commit messages? It would be extremely useful
ci
⚡
Remove grunt
Could we please also get this addon for Firefox? 😃
Hello there 🙂
This is not really an issue or a question, I just wanted to let you know that I recently made an extension called No Merge Today. I used Do Not Merge WIP as a starting point since I've never built a Chrome extension before. So, thank you for that!
I also was able to solve a couple of scenarios that Do Not Merge WIP does not handle. Most notably the case where you reach the pull request page by client-side navigation, instead of a full-page reload (Do Not Merge WIP won't trigger in this case, No Merge Today will). A simple way of testing this scenario is to, having Do Not Merge WIP enabled, navigate to https://github.com/rafaeleyng/no-merge-today/pulls and then click on the PR 2 there. It shouldn't trigger the content script that blocks the button. But after a reload while being on the PR page, it triggers.
I also used mutation observer to react more quickly to DOM changes (instead of relying on a setInterval), and message passing to react immediately to configuration changes in the action popup.
I hope this can be useful 👋
In this example
merge is blocked even though there is no "wip" in the title?
https://github.com/search?q=wip&type=Issues
Looking over a few pages, you'll see "WIP" isn't always wrapped with square brackets: there are bunch of "WIP:"s or even PRs just titled "WIP". Same can say to DNM or Do Not Merge.
Currently the regex says those keywords need to be wrapped in square brackets.
Do we really need the square brackets to be present in the PR title?
It seems the extension is now unpublished from the Chrome Web Store.
Could you clarify? Could you re-publish it? Thank you! ❤️
We wanted to let you know that your item is at risk of being removed from the Chrome Web Store. Please find the details below.
Item name: Do Not Merge WIP for GitHub
Item ID: nimelepbpejjlbmoobocpfnjhihnpked
Violation(s):
Use of Permissions:
Violation reference ID: Purple Potassium
Violation: Requesting but not using the following permission(s):
storage
How to rectify: Remove the above permission(s)
Relevant section of the program policy:
Request access to the narrowest permissions necessary to implement your Product's features or services. Don't attempt to "future proof" your Product by requesting a permission that might benefit services or features that have not yet been implemented. (learn more)Important information about resubmission:
Please make the necessary changes within 14 days in order to avoid removal.
Remove compass
grunt-contrib-cssmin removes empty css file, so remove css file from package temporally.
gruntjs - Write file even if output css is empty - Stack Overflow
#11
#12 is quick fix, I remove css from package(manifest.json), but touch styles/main.css is better solution I think.
Does not disable button.
Uncaught TypeError: Cannot read properties of null (reading 'textContent')
Context
https://github.com/sanemat/do-not-merge-wip-for-github
Stack Trace
scripts/contentscript.js:6 (anonymous function)
let issueTitle = container.querySelector('.js-issue-title').textContent;
Remove meaningless tests
Please use the feature of GitHub itself.
Remove jquery
Would be interesting to introduce the same behavior that the WIP prefix provides with labels as well, so that labelling a PR with a WIP label will have the same effect.
😣
Hi sanemat,
I tried to install this extension from Chrome Web Store, but an error occurred and couldn't install it.
I think this extension is super useful, so could you check this issue and fix it if possible?
Does not disable button.
Current extension name is 'github merge caution', but this is ambiguous.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.