ruby-grape / danger Goto Github PK
View Code? Open in Web Editor NEWAutomate common code review chores with http://danger.systems.
License: MIT License
Automate common code review chores with http://danger.systems.
License: MIT License
@orta says:
you generally need this: https://github.com/orta/danger-junit/blob/master/spec/spec_helper.rb#L38-L52
then tests can look like this: https://github.com/orta/danger-junit/blob/master/spec/junit_spec.rb#L10-L23
Danger complained that I was missing a changelog and presented me the following suggestion to add:
* [#1486](https://github.com/ruby-grape/grape/pull/1486): implemented except in values validator - [@jonmchan](https://github.com/jonmchan).
I copied and pasted it verbatim and danger still complained stating that it did not follow the format of the rest of the changelog.
Apparently, the first character after the PR # was supposed to be capitalized.
This is the properly formatted changelog:
* [#1486](https://github.com/ruby-grape/grape/pull/1486): Implemented except in values validator - [@jonmchan](https://github.com/jonmchan).
It would be good if danger would suggest a properly formatted changelog addition instead of suggesting something that still breaks the danger rules.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.