Coder Social home page Coder Social logo

Comments (5)

fmauch avatar fmauch commented on June 14, 2024

I was asking myself the same thing recently, also given that the rqt plugin shows all of them.

from ros2_control.

saikishor avatar saikishor commented on June 14, 2024

I think the rqt_plugin uses the info from the list_controllers topic

def _update_controllers(self):
if not self._cm_name:
return
# Find controllers associated to the selected controller manager
controllers = self._list_controllers()
# Update controller display, if necessary
if self._controllers != controllers:
self._controllers = controllers
self._show_controllers() # NOTE: Model is recomputed from scratch

I'm not sure if there is a way to read it and display it, I'm not sure if this feature is necessary, as in the future we might want to move the definition of the controller types from the original yaml that is parsed to the controller_manager node (ros-controls/ros2_control_demos#502), in that case, it would be hard to read the all available controller. However, what can be seen is the available controller types.

from ros2_control.

firesurfer avatar firesurfer commented on June 14, 2024

As far as I can tell the list_controllers topic only lists loaded controllers but not defined controllers.

I'm not sure if there is a way to read it and display it, I'm not sure if this feature is necessary, as in the future we might want to move the definition of the controller types from the original yaml that is parsed to the controller_manager node (ros-controls/ros2_control_demos#502), in that case, it would be hard to read the all available controller. However, what can be seen is the available controller types.

Well at some point the controller manager has to know about available controllers, otherwise it would not be possible to load them. So it should also be possible to expose them to the user.

The reason I want to access them is that I define a list of controllers in our application framework which then can be used by users for certain operations. At startup I would like to check if that list matches with the controllers known to the controllers manager.

from ros2_control.

saikishor avatar saikishor commented on June 14, 2024

Well at some point the controller manager has to know about available controllers, otherwise it would not be possible to load them. So it should also be possible to expose them to the user.

Well not necessarily, it is indeed possible to load them dynamically(#1502 and #1293). I have added this feature very recently. The controller manager doesn't have to know the name of the controller, the user should be able to load any type of controller with whatever name he wants.

If you want to verify the list, why don't you spawn all the controllers with --load-only option and then just validate the list, and you could be able to activate and deactivate from there on.

from ros2_control.

firesurfer avatar firesurfer commented on June 14, 2024

Okey it somehow makes sense if it is possible to load controller at runtime. Even though from the description I would expect it still to be possible to determine loadable controllers at a certain point of time (as we can only load controllers we know the configuration of)

(Btw. does this mean: #982 is solved now?)

from ros2_control.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.