Coder Social home page Coder Social logo

samplv1's People

Contributors

anclark avatar asmuth avatar jelly avatar ngeiswei avatar rncbc avatar trebmuh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

samplv1's Issues

"undefined reference to" errors when compiling with Qt5 (Qt4 disabled)

I get the error as shown below when I configure samplv1 0.8.4 like this. I didn't have this error on 0.8.3

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --docdir=/usr/share/doc/samplv1-0.8.4 --htmldir=/usr/share/doc/samplv1-0.8.4/html --libdir=/usr/lib64 --disable-debug --disable-qt4 --enable-jack --disable-alsa-midi --enable-lv2 --disable-liblo
.obj_jack/samplv1widget_config.o: In function `samplv1widget_config::controlsEnabled(bool)':
samplv1widget_config.cpp:(.text+0x30b): undefined reference to `samplv1_ui::isPlugin() const'
.obj_jack/samplv1widget_config.o: In function `samplv1widget_config::programsEnabled(bool)':
samplv1widget_config.cpp:(.text+0x42b): undefined reference to `samplv1_ui::isPlugin() const'
.obj_jack/samplv1widget_config.o: In function `samplv1widget_config::samplv1widget_config(samplv1_ui*, QWidget*, QFlags<Qt::WindowType>)':
samplv1widget_config.cpp:(.text+0x18ae): undefined reference to `samplv1_ui::isPlugin() const'
.obj_jack/samplv1widget_jack.o: In function `samplv1widget_jack::samplv1widget_jack(samplv1_jack*)':
samplv1widget_jack.cpp:(.text+0x1e7): undefined reference to `samplv1_ui::samplv1_ui(samplv1*, bool)'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile.src_jack:258: samplv1_jack] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-sound/samplv1-0.8.4/work/samplv1-0.8.4/src'
make[1]: *** [samplv1_jack.mak:43: sub-src-src_jack-pro-make_first] Error 2
make[1]: Leaving directory '/var/tmp/portage/media-sound/samplv1-0.8.4/work/samplv1-0.8.4'
make: *** [Makefile:119: jack] Error 2
make: *** Waiting for unfinished jobs....

Any idea what could be causing this?

unstable playback

Still running Samplv1 in debug mode, i found that the notes played back with the sampler are not stable. There is some kind of flutter.

I hope you can replicate this issue. Here is the saw wave i used:
zaag.wav.zip
and i made a video about the issue:
unstable_notes-2018-03-26_18.15.53.mp4.zip

First i play the notes with the Tuning Tab ticked, then unticked. Both examples are made with the standard 12 notes in an octave.

We did not notice this behavior before as we are using ambient and complex rhythmic patterns with Samplv1.

Pitch as phase vocoder

Hey Rui, hope you're doing fine,

I was wondering about the possibility to add a second algorithm (or replace the current implementation) for pitch shifting that would use a phase vocoder instead of playback rate. I heard of soundtouch LGPL and rubberband GPL The user would have the possibility to choose what the midi notes will modify between :

  • speed
  • pitch
  • playback rate (speed & pitch)
    The main goal is to be able to preserve the bpm of the rhythmic elements in the samples but I think this could lead to a lot of happy accidents/experimentation too.
    Tell me what you think about that idea and how realistic it is,

Take care,

Ardour5/LV2 - No GUI

Hallo,
when opening the samplv1 gui in Ardour there are no GUI elements. The Ardour plugin host shows up with the Ardour standard top bar elements but the main section (provided by LV2) is empty. The alternative GUI provided by Ardour (generic controls) is more like a "text-only" emergency solution and is not working 100% either. The options 'GEN1 loop start' and 'GEN1 loop end' just sit at the end of all elements without any control or input fields. So even that is not an option atm.

In external 'samplv1-jack' binary the button 'help/configure/use desktop environment native dialogs' doesn't change anything in Ardour.

Neither stdout or any other log shows any evidence of an error (like ppl reported for previous samplv1 versions) and nothing really crashes.

Any idea what's wrong here? Still a qt library mismatch or something?

Is there a documentation for samplv1 anywhere? I have no clue what's 'swap a' and 'swap b' are for or how that 'Add bank/Add programm' feature works. I need 12 different samples and i don't know to set this up (without starting 12 external samplv1 instances).

Arch 4.15.8
XFCE
Ardour v5.12
samplv1 v0.9.0

Unable to connect to playback

Hello there,

Samplv1 0.8.0
When running with the terminal :

samplv1_jack 
SuspendRefNum error
JackClient::Execute error name = samplv1-01
Server is not running
Server is not running
Server is not running
Server is not running

Jack log :

Tue Jan 17 16:26:58 2017: New client 'samplv1-01' with PID 5414
Tue Jan 17 16:26:58 2017: port 'a2j:samplv1 [130] (playback): in' created
Tue Jan 17 16:26:58 2017: port 'samplv1-01:in_1' created
Tue Jan 17 16:26:58 2017: port 'samplv1-01:in_2' created
Tue Jan 17 16:26:58 2017: port 'samplv1-01:in' created
Tue Jan 17 16:26:58 2017: port 'samplv1-01:out_1' created
Tue Jan 17 16:26:58 2017: port 'samplv1-01:out_2' created
Tue Jan 17 16:28:05 2017: ERROR: Failed to find port 'samplv1:in_1' to destroy
Tue Jan 17 16:28:05 2017: ERROR: Failed to find port 'samplv1:in_2' to destroy
Tue Jan 17 16:28:05 2017: ERROR: Failed to find port 'samplv1:in' to destroy
Tue Jan 17 16:28:05 2017: ERROR: Failed to find port 'samplv1:out_1' to destroy
Tue Jan 17 16:28:05 2017: ERROR: Failed to find port 'samplv1:out_2' to destroy

I cannot connect samplv1 to the system playback in standalone. Seems to work in lv2 tho.

Cheers,

Automating Loop points is broken

I've tried automating loop points in Ardour - however the control port ranges seem to be close to [0..1] - so using any automation will make the loop use only 1 sample of the loaded soundfile at best.

image

Loop Start/Stop automation in Ardour5 only value 0 and 1

I don't know if this belongs here or into ardour, but when I load samplv1 as lv2 plugin in ardour5 and want to automate the Loop Start/End parameters, all I can do in ardour is set them to either 0 or 1.

I'm using both from official Arch linux repo:

  • Ardour 5.12
  • amplv1 Version 0.9.0 (Qt Version 5.10.1 but i doubt that matters)

I'm also using the external GUI workaround described in #13 if that matters.

Notes starting at beginning of project in REAPER cause beginning of sample to also be played in render, ignoring offset

I have a bit of a weird bug that might be REAPER's fault, but I thought I'd bring it up here just in case. If you have a note at the start of a midi track that's at the start of your project, and samplv1 has an "offset" set to remove the beginning of the audio file, the start of that audio file plays at the start in addition to the actual sample. It functions correctly when previewing from the DAW but when rendering it out it has the issue. I've also noticed some odd behavior with offsets on all notes (it seems like the start of my sample is always getting cut off in the render) but not sure if it's related.

lv2 plugin crashes when trying to load a sample

When trying to load a sample in the lv2 samplv1 plugin the GUI crashes. After unchecking "Use desktop environment native dialogs" it doesn't crash anymore.

This issue applies to 0.8.0, 0.7.5 and 0.7.4. I didn't try this with other versions.

I am using Gnome shell.

I could create a gdb dump if you want.

Manual

Hey,

What do you think of making a manual for the vee-one suite ?
I don't know if it's useful/worth the time but if it is I'm up to help.

Allow selecting In and Out points in a sample

I'd like to load up a long sample and select just a short part from it to be played back.
I tried using the loop markers but they do a different thing. I first thought the are just for that.

I think it'd be great to have a separate "In/Out" range markers to select a part in the sample to be used.

Also being able to zoom in/out in the sample waveform preview could be a great help to precisely select the In/Out points.

I know I could prepare precisely cut samples to be loaded into Samplv1, but being able to do this live is adding much versatility to the plugin, also be cause one could automate the In/Out point positions to effectively change the sound between each played note.

NSM error

Working on the manual for Samplv1 (https://github.com/rncbc/samplv1/wiki/User-Manual), i try to open Samplv1 in NSM. I tried it twice.
i get this error:
13:41:13 Listing sessions
13:41:16 Opening session ggg
13:41:16 Waiting for announce messages from clients
13:41:16 Launching samplv1
13:41:17 Client samplv1 died unexpectedly.
13:41:21 Done. 0 out of 1 clients announced within the initialization grace period
13:41:21 Waiting for clients to reply to commands
13:41:22 Done waiting
13:41:22 Loaded.
13:41:48 Launching samplv1
13:41:49 Client samplv1 died unexpectedly.

Personally i do not use and care too much for NSM, but i'd thought i'd mention it to you.

Unable to use samplv1 in synthpod after upgrading from 0.9.9 -> 0.9.11

I could always use samplv1 in synthpod just fine, but after the last update, synthpod will not load samplv1 reporting:

(DSP) [Error] _sp_app_mod_is_supported: <http://samplv1.sourceforge.net/lv2> NOT supported: mixes DSP and UI code in same binary.                                                                                                                                   
(DSP) [Error] _sp_app_mod_add: plugin is not supported                                                                                   

I know that i can force synthpod to load samplv1 using the "bad plugins" flag, but it seems to me that samplv1 should not be a "bad plugin"?

Cannot resize oversized samplv1 window

I have install samplv1 0.9.25.5git.5154d8-66.1 from this ppa on Ubuntu 21.10

I'm attempting to load the plugin in Carla (2.4.3). The plugin appears to load fine but when I then try to load the gui it is oversized and glitches a lot. When I try to resize the window it goes back to its original size and then eventually crashes Carla. I've provided a video below

simplescreenrecorder-2022-04-26_16.06.20.mp4

Use absolute rather than relative paths for samples

When I load saved presets in samplv1, the application and my DAW crash. I looked at the saved preset file and noticed that the tag used a path relative to the current directory rather than an absolute path. Changing this to an absolute path (starting from the root directory) fixed the crash. However, after making changes and overwriting the preset, the relative path returns.
Could we have an option to use absolute paths when saving presets? I understand that for users with project-local samples, relative paths may be more useful so that the project itself can be moved without breaking the sampler. However, for people who use sample packs and do not duplicate samples into their projects, using absolute paths would be better.
Also, using absolute paths means that we don't have to rely on the current directory, which can change between instances.

This is an extreme example of what I'm describing

<filename>../../../../../home/username/Music/Samples/Hi Hat.wav</filename>

vs.

<filename>/home/username/Music/Samples/Hi Hat.wav</filename>

Make the UI work without instance-access

Hello again :)

This is a feature request, for which we at MOD Devices are willing to submit a PR to.
We have been looking into samplv1 and the steps to make it all work without instance-access are within small reach:
1 - properly save and restore lv2 parameter data as part of the plugin state, see #33
2 - notify the UI when these parameters are changed by the host (as part of state restore)
3 - when loading a sample, make an atom float-vector of its peaks to send to UI

That should do it. It is already quite close since you are using the lv2 parameter APIs for file management.

I don't expect you to do any work here, just wanted to start the conversation about this.
We (at MOD) will be pushing a PR soon that achieves this, just wanted to mention this, as perhaps you have any important things to note or even objections.
Thanks

no Xfade in LV2

The standalone version of the Early Summer'18 release does have the new Xfade option, but this has not been implemented yet in the LV2 version.

Looping forwards and backwards

Hello!

I've just discovered samplv1 today and it seems excellent. One feature request: Is there any chance you could add the ability to loop forwards and backwards through the selected loop points? This can result in a much more natural sound when looping sustained samples such as wind instruments, synth pad sounds, etc.

To clarify: The current loop algorithm starts looping at point P0 and continues through the sample until it reaches point P1. Then, it restarts at P0 and repeats this process endlessly. I'd love it if you could add a looping mode that starts looping at point P0, continues through the sample until it reaches P1, and then reverses direction and travels backwards through the sample until it reaches P0 again. When it reaches P0, the process repeats.

harmonics appear

3th, 5th, 7th harmonics appear when i play a clean sine sample at the rootkey (and others).

What i did:

  1. generated a 3 second sine with Audacity. This looks totally clean in Baudline.
    sine_audacity
  2. imported the sine into Samplv1 with settings that should not add harmonics.
    samplv1
  3. played Samplev1 at its rootkey but get all those harmonics.
    sine_samplv1
    This shows the 220 Hz sine as generated by Audacity, but also a 3 x 220Hz, 5 x 220Hz, 7 x 220Hz. They do have less amplitude, but are still very present.

I wonder if Samplv1 can be improved so that it reproduces the 220Hz sinewave without distortion?
However, if this is "normal" behavior for a sampler, could you please provide a small explanatiion?

The sine wave of 3 seconds is attached.
sine.wav.zip

Ubuntu, Ardour, KXStudios: old problem, new flavour

I'm one of the Ubuntu 18.04 / KxStudios / Ardour 5.12 users who can't get the VeeOne plugins running in their DAW.

I just updated from 0.9.2 where the GUI didn't work to 0.9.11.

In 0.9.2 I got the message:
suil error: Unable to open UI library /usr/lib/lv2/samplv1.lv2/samplv1_ui.so (/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5: undefined symbol: hb_font_funcs_set_nominal_glyph_func)

In 0.9.11 I get the same message now from lilv:
lilv_lib_open(): error: Failed to open library /usr/lib/lv2/samplv1.lv2/samplv1.so (/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5: undefined symbol: hb_font_funcs_set_nominal_glyph_func)

And this prevents Ardour even to start the plugin DSP.

In jalv everything is fine. With the notable exception of a segfault I observed.

LV2 parameter state not handled properly

Hello.

As I am investing some time on proper lv2 parameter support in Carla and mod-host, I have seen a LOT of stuff that simply does not work all around the LV2 plugins.
I think the fault was the incomplete plugin support, beginning with the actual official LV2 example plugins.
Been trying to fix the situation, eg-sampler is fixed at lv2/lv2#51
This helped to use as working example plugin (plus I found openmusickontroller plugins like sherlock also work well).

On samplv1 side, the issue is that all the lv2 parameters values are not saved, only the filename for the sample.
(Maybe, like me, you expected the host to be the one having to save such values, but this is incorrect)

The value for these non-control-port properties needs to be saved by the plugin as part of the state. Otherwise LV2 presets will be broken, if you think about it.

Me and Bram (from MOD) are looking into using this plugin, so we can submit a PR for review.
If you rather take care of this yourself, please let us know, thanks!

Play the rest of the sample after the loop

It would be nice to have an option to play the "rest" of a sample after note-off with loop enabled, for example, if I have a voice sample with word "boy", I can loop on "o" but I want to have "y" played at the end of the note.

Clicking even when looping between zero crossings

Greetings, Rui and lurkers!

Investigating samplv1, I am not able to produce a click-less looping sound, based on a simple sample. I created the sample using qtractor and a simple amsynth patch. Using audacity I selected a nice region at zero crossings, which I believed should yield a click-less sound when looping over (please tell me in case I have totally misunderstood something, since I have just started playing with sampling). I then loaded the sample to samplv1, using the at-zero-crossings sample numbers as start and end, and recorded a single note using qtractor. I finally exported the audio. The input sample and exported audio are here: sample-and-export.zip. Clicks are audible in the exported audio.

This is the waveform of the input sample and the selected at-zero-crossings region (I selected ten periods):

sample-c4-stereo

This is the configuration of samplv1:

samplv1

These are parts of the exported audio (normalized). I have marked what I believe are anomalies:

export-anomaly

export-anomaly-period

Is there an error on my part or is this a bug?

samplv1 lv2 hangs reaper when loading

Hello

I am having a very strange issue with samplv1 in Ubuntu 22.04 and Reaper. Earlier today I opened and loaded the sampler with no issue, however during usage, it suddenly delayed all midi messages and playback was done after several seconds... (10 or maybe 20), then it crashed Reaper. Now when I open Reaper and try to load the sampler it hangs Reaper and all the UI. attached a screenshot. After this, Reaper, the sampler, and everything related just freezes.
sampler-freeze

p.s. Running Reaper in the terminal does not spit out any information

any help will be appreciated

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.