rm5248 / cserial Goto Github PK

Fix: L28 c_serial.c

#define GET_SPEED_SWITCH(SPD,io) case B##SPD: baud_return = SPD;

by

#define GET_SPEED_SWITCH(SPD,io) case B##SPD: baud_return = SPD; break;

cserial_read is a blocking call, with no way to only read when there is data. What should be done is the Event handle from the OVERLAPPED structure should be given back to the user some how in order for them to use a platform-specific function(on Linux, poll(), on Windows, WaitForSingleObjects/MsgWaitForMultipleObjectsEx).

It looks like what Qt does for serial ports is to pass back the event handle from the OVERLAPPED structure, and in the main loop it has a call to MsgWaitForMultipleObjectsEx() to wait for events on any HANDLE.

Increase the amount of memory that is freed, should be a max of 512.

Should the library support RS-485? On Linux, this means setting the TIOCSRS485 on the serial port. Otherwise we would have to set the RTS line ourselves.

How widely used is this? It can definitely be worked around by setting it manually.

c_serial_get_stop_btis should be declared obsolete and add c_serial_get_stop_bits