rinvex / countries Goto Github PK

Hello,

It would be nice to have the translations demonyms :).

Can I change the size of the flag cause it's very large 750 widths and 500 height?

السلام عليكم
ياليت يتم إضافة جنسية الدولة مثل مصر تكون مصري

$egypt->getNativeNationalityName();
output : مصري

$egypt->getNationalityName();
output : Egyptian

Hi, i just noticed that there's still Distrito Federal/DIF in the Mexico divisions json, but since 2016 it ceased to be called like that; Now it's Ciudad de México/CMX.

Just to let you know, hope you can update it soon 👍.

CountryLoaderException exception currently located under the Rinvex\Country while it's placed inside the src/Exceptions directory, so it's namespace must be fixed to be Rinvex\Country\Exceptions

Hey,

I was just wondering if rinvex/country is still being actively maintained? If not, would you be interested in handing off maintenance to someone else?

I want to add an Arabic translation name for all countries. Where is the right file to put it?

It would be nice to have something like the following data for each country:

{
    "DefaultLanguageCode": "en",
    "TimeZones": [
        "America/New_York",
        "America/Chicago",
        "America/Denver",
        "America/Phoenix",
        "America/Los_Angeles"
    ],
    "Locales": [
        "en_US"
    ]
}

Hi
Found a case where getTld() throws an error:

[Symfony\Component\Debug\Exception\FatalThrowableError]
Type error: current() expects parameter 1 to be array, null given

[2017-09-12 07:40:18] local.ERROR: Type error: current() expects parameter 1 to be array, null given {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Type error: current() expects parameter 1 to be array, null given at /var/www/projects/translations/vendor/rinvex/country/src/Country.php:249)

Case 1 - Works OK

$country = country('XK');
dd($country->getTld());

Case 2 - Works OK

$country = country('XK', false);
dd($country['tld']);

Case 3 - Works OK

$countries = countries(true);
foreach ($countries as $country) {
    dump($country['tld']);
}

Case 4 - Throws the error

$countries = countries(true, true);
foreach ($countries as $country) {
    dump($country->getTld());
}

The error only occurs for XK - Kosovo, BQ - Caribbean Netherlands and SH - Saint Helena because the get() method returns null.

Replacing return current($this->get('tld', [])) ?: null; with return $this->get('tld', []) ?: null; seems to fix the error.

Cheers

Reference: https://www.reddit.com/r/PHP/comments/51do0f/php_package_for_retrieving_country_details_with/

For the past year or two, I've been using a custom countries database table, so that my users can be associated with a country_id. However, I'm becoming more and more fond of this library, and am finding that more and more I'm using this instead of my own table for things other than long-term database storage.

Now; my question has to do with the long-term usage of this library. If I were to slowly migrate away from having a countries table and using this library instead (via a custom wrapper), what would be the most reasonable 'key' to identify a country? Should users have a country_code that contains the ISO 3166 Alpha-2 instead? Or the ISO 3166 Numeric? Or something else? What would be the most reasonable long-term 'key' here?

Just like 'address_format', just one for numbers.

Example:
+352 691 123 4567
// {{callingcode}} {{initial}} {{range1}} {{range2}}

I don't know the actual names, but basically that.

:flag_eg:
:flag_us:
:flag_fr:

Could be cool to have this as a migration / seed.

Hi,

Why does england has 4 fifa codes and not just ENG? according to wikipedia it should only be ENG.

Some countries has multiple currencies, but mostly only one is used or at least there's a default currency, but this package returns the first currency regardless, which make it weird.

We need to sort currencies and change the default behavior to return the official/default currency of the country, and if needed all other currencies will be returned optionally. Related issue #52

Reference

• Either consider caching results; OR
• Separate country data into individual files for each country; OR
• Maybe both

There's still missing divisions for the following countries:

• ai: Anguilla
• aq: Antarctica
• as: American Samoa
• aw: Aruba
• ax: Åland Islands
• bl: Saint Barthélemy
• bm: Bermuda
• bv: Bouvet Island
• cc: Cocos (Keeling) Islands
• ck: Cook Islands
• cw: Curaçao
• cx: Christmas Island
• fk: Falkland Islands
• fo: Faroe Islands
• gf: French Guiana
• gg: Guernsey
• gi: Gibraltar
• gl: Greenland
• gp: Guadeloupe
• gs: South Georgia
• gu: Guam
• hk: Hong Kong
• hm: Heard Island and McDonald Islands
• im: Isle of Man
• io: British Indian Ocean Territory
• je: Jersey
• lc: Saint Lucia
• mc: Monaco
• mf: Saint Martin
• mo: Macau
• mp: Northern Mariana Islands
• mq: Martinique
• ms: Montserrat
• nc: New Caledonia
• nf: Norfolk Island
• nu: Niue
• pf: French Polynesia
• pm: Saint Pierre and Miquelon
• pn: Pitcairn Islands
• pr: Puerto Rico
• ps: Palestine
• re: Réunion
• sj: Svalbard and Jan Mayen
• ss: South Sudan
• sx: Sint Maarten
• tc: Turks and Caicos Islands
• tk: Tokelau
• va: Vatican City
• vg: British Virgin Islands
• vi: United States Virgin Islands
• wf: Wallis and Futuna
• xk: Kosovo
• yt: Mayotte

i try to do this
\Rinvex\Country\CountryLoader::where('languages', 'Arabic');

but its not working
even i try with passing an array ['value' => 'Arabic']
but also same issue

can anyone help me with this

thank you.

🇪🇬🇺🇸🇯🇵

GB has multiple division levels, and currently the dataset has all divisions levels combined into one.
Eg. Derby and Derbyshire exist in the one list.

This seems to be an issue that has stemmed from https://github.com/hexorx/countries
Would be nice if this could be fixed, other countries may be affected as well.

If my need becomes more pressing, I will make a pull request to fix GB divisions.
But this will need to be properly looked into for all countries.

The 2.0 tag is php 5.6 compatible but has a broken namespace, 3.0 is 7.0+ only?

When trying getCallingCode() on a country instance:

TypeError: current() expects parameter 1 to be array, null given in /var/www/html/myproject/vendor/rinvex/country/src/Country.php:560
Stack trace:

Any way of getting all countries as Country objects instead of an array?

This popped up in production for us:

Some japanese users type their adresses using latin characters instead of katakana, and per the recommendations (https://www.post.japanpost.jp/int/use/writing/ems_en.html) such addressing should be reversed (ie the traditional "western" addressing system, ie name, followed by street, followed by zip and city etc).

It also gets quite confusing when westernized addresses are used since the JP format looks like this:
〒{{postalcode}}\n{{region_short}}{{city}}{{street}}\n{{recipient}}\n{{country}}
ie, no separator between region, city and street.

So maybe we need a jp-westernized.json file, with a format something along the lines of
{{recipient}}\n{{street}}\n{{postalcode}}{{city}}\n{{region_short}}\n{{country}}

As to how we would select that format instead of the official JP one I'm not sure. A helper function to analyze if the address contains mostly latin characters or not maybe? Or just a flag to pass (westernized=true)?

Are there any plans in making the alternative names of the division as translations, where i can map the alternative name to a language? I think the default name of a divison is in the native language, but how do i know which alternative name is for what language?

.PHP Fatal error:  Class 'Rinvex\Country\CountryLoaderException' not found in E:\www\labs\shipment-tracking\vendor\rinvex\country\src\Loader.php on line 219

Version: 2.0.0

I know its has been fixed in v3; because of my php version, i can only use v2; will you relase a fix version for v2?

There are 4 countries returns incorrect Currency.

>>> country('us')->getCurrency()
=> [
     "iso_4217_code" => "USN",
     "iso_4217_numeric" => 997,
     "iso_4217_name" => "United States dollar (next day) (funds code)",
     "iso_4217_minor_unit" => 2,
   ]
>>> country('us')->getCurrencies()
=> [
     "USN" => [
       "iso_4217_code" => "USN",
       "iso_4217_numeric" => 997,
       "iso_4217_name" => "United States dollar (next day) (funds code)",
       "iso_4217_minor_unit" => 2,
     ],
     "USS" => [
       "iso_4217_code" => "USS",
       "iso_4217_numeric" => 998,
       "iso_4217_name" => "United States dollar (same day) (funds code)",
       "iso_4217_minor_unit" => 2,
     ],
     "USD" => [
       "iso_4217_code" => "USD",
       "iso_4217_numeric" => 840,
       "iso_4217_name" => "US Dollar",
       "iso_4217_minor_unit" => 2,
     ],
   ]

Should return USD, but first one USN returned.

country('us')->getCurrency()
country('cl')->getCurrency()
country('uy')->getCurrency()
country('bo')->getCurrency()

there are 4 countries return incorrect currency.

New validation rule: make sure input value is valid currency

Since PHP 5.5 already out of date and no longer supported, and 5.6's EOL is just in few days, we've to require PHP 7.0 as the minimum requirement for this package, we're aware this is a a breaking change for some, so we plan to bump package's version to next major release for that update v3.0.0. If you don't plan to update to PHP 7+ soon, then keep using the v2 version of this package.

Reference: Fahed Bizzari

Thanks for developing the country library. We're about to replace lots of our code with it.

However, there are a couple of issues:

1. Caribbean Netherlands (BQ) should have a dialling code of +599 (see here)
2. Curaçao (CW) should have a dialling code +599 not +5999.

Any way for you guys to get these updated?

$egypt = Country::find('EG');

Is much better than:

$egypt = (new Country)->find('EG');

Any chance of implementing ISO 639-1 codes instead of ISO 639-2 codes?
PHP plays better with ISO 639-1 codes: http://php.net/manual/en/locale.getdisplaylanguage.php

At the moment I'm resorting to a helper class just to convert ISO 639-2 to ISO 639-1.

$languages = [
    ['ab', 'abk'],
    ['aa', 'aar'],
    ['af', 'afr'],
    ['ak', 'aka'],
    ['sq', 'sqi'],
    ...
];

Hi all,

It would be useful to return the currency symbol in Hex and/or Dec format - I'm not sure if there's an automated source/way of integration into the existing json files. My thoughts were for the currency object to look something like;

{
	"GBP": {
		"iso_4217_code": "GBP",
		"iso_4217_numeric": 826,
		"iso_4217_name": "Pound sterling",
		"iso_4217_minor_unit": 2,
		"symbols": {
			"hex": "xa3",
			"dec": 163
		}
	}
}

I see that you support Word Regions (which seems to be similar) but not Business Regions.

It would be great if the additional regions could be added to World Regions, or a new 'Business Region' parameter be added, with getBusinessRegion() method.

Business Region reference: https://en.wikipedia.org/wiki/List_of_business_region_acronyms

New validation rule: make sure input value is valid country

Can you please consider adding electricity voltage types a country have?

Currently all JSON files are compressed, which make it difficult to review PRs and check differences between revisions or even read source files humanly, it's compressed for the sake of size saving on production, but we can do better.

We'll convert all JSON files into well formatted source files, and will add command line tool to compile these files for production usage (optional).

Would it be possible to add which separators are used for decimal and thousands?