Comments (6)
Yes, I agree. We may have to change getCurrency
behavior and omit or separate the details currencies into different attribute for all countries. I'll keep this issue opened until further review.
from countries.
@khsing Check this please & tell me what do you think http://forexesteem.blogspot.com.eg/2009/03/explanation-of-usdussusn.html
from countries.
@Omranic In general the currency of USA is USD, although USN and USS are more detailed currency code, but not normal.
I think getCurrency
should return the Currency which people used to use.
from countries.
I had the same problem. I've fixed it by adding an optional key 'default_currency' to the country data, and a new Country::getDefaultCurrency method. If default_currency is not set, Country::getDefaultCurrency returns the same as Country::getCurrency. (I could have just altered the order of currencies in the json files, but explicitly defining it seems more secure)
My code's here, if it's ok I can send a PR for this
from countries.
+1 for USD instead of USN
from countries.
Thank you for your patience, this is now fixed fundamentaly for all countries in 1cf372b, here's what's been done:
Update country currencies to include only the official currency (fix #52 #55 #72)
- Removed fund, complementary and secondary currencies as it's not relevant to the countries package, and caused confusion before
- This change affected 15 countries: Bolivia, Bhutan, Belarus, Switzerland, Chile, Cuba, Western Sahara, Haiti, British Indian Ocean Territory, Lesotho, Namibia, Panama, El Salvador, United States, Uruguay
from countries.
Related Issues (20)
- Array access on bool when retrieving short list of countries on PHP 7.4 HOT 2
- Guinea-Bissau Flag & official name of Portugal HOT 5
- PHP 7.4 as minimum? HOT 2
- IOC code for Singapore is `SGP` instead of `SIN` HOT 2
- Regions and cities HOT 1
- States for HongKong are missing? HOT 1
- Countries Affected by GDPR HOT 5
- php 8 support HOT 4
- Vietnam's flag seems broken HOT 1
- Wrong bounding box for China HOT 9
- [proposal] add population data HOT 5
- Divisions ISO2 codes are not updated. HOT 1
- Italy detail in shortlist.json is incorrect. HOT 1
- Please update Belarus for German (deu) HOT 1
- Wrong boundary box for China HOT 1
- Italy native name and main language HOT 1
- Oddity with Bonaire translations HOT 1
- Get country codes by region HOT 1
- List all regions HOT 1
- Spain native_name and native_official_name in shortlist.json is incorrect. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from countries.