renzibei / fph-table Goto Github PK

There is no usage example for insert(input_iterator, end_iterator). Can you supplement it? what type should input_iterator and end_iterator be? When I set them to iterator of std:: vector<std:: pair<int, int>>, there will be compile errors. Thanks in advance.

Hi,

I am developing production application which depend on this library. We have configuration where we enable and disable exceptions. I am able to compile with exceptions but without exception, compilation break. Please support disabling exceptions as well.

Thanks for this library. It's really helpful. :)

Hi,

After updating to latest commit, I am getting following exceptions.

/opt/rh/gcc-toolset-11/root/usr/bin/ld: empty/CMakeFiles/empty.dir/empty/empty_strategy.cpp.o (symbol from plugin): in function `fph::dynamic::detail::ThrowInvalidArgument(char const*)':
(.text+0x0): multiple definition of `fph::dynamic::detail::ThrowInvalidArgument(char const*)'; empty/CMakeFiles/empty.dir/empty/main.cpp.o (symbol from plugin):(.text+0x0): first defined here
/opt/rh/gcc-toolset-11/root/usr/bin/ld: empty/CMakeFiles/empty.dir/empty/empty_strategy.cpp.o (symbol from plugin): in function `fph::dynamic::detail::ThrowInvalidArgument(char const*)':

can you add my emhash into your benchmark ？
https://github.com/ktprime/emhash/blob/master/hash_table7.hpp
https://github.com/ktprime/emhash/blob/master/hash_table8.hpp
https://github.com/ktprime/emhash/blob/master/thirdparty/emilib/emilib2.hpp

I have add your hashmap into my bench
https://github.com/ktprime/emhash/blob/master/bench/ebench.cpp
https://github.com/ktprime/emhash/blob/master/bench/qbench.cpp
https://github.com/ktprime/emhash/blob/master/bench/martin_bench.cpp
....

I got a compile error in martinus/map_benchmark:

/home/martinus/git/map_benchmark/external/fph__noseed_fph_map/include/fph/dynamic_fph_table.h:1509:33: error: no member named 'exchange' in namespace 'std'; did you mean '__exchange'?
                    seed1_(std::exchange(other.seed1_, 0x123456797291071ULL)),
                           ~~~~~^~~~~~~~
                                __exchange

It appears #include <utility> is missing: https://en.cppreference.com/w/cpp/utility/exchange, when I add the include it compiles