Coder Social home page Coder Social logo

Comments (4)

krajek avatar krajek commented on May 30, 2024 1

Open questions:
A) Should we make WithExceptionDetails(destructurers) obsolete and direct users to new fluent API? I think that we should.
B) Should we make the WithIgnoreStackTraceAndTargetIdExceptionFilter a default? I think yes, seems like users do not need StackTrace to be duplicated. I am open for discussion.
C) Why this method extension method exists? It does not seem to contain anything specific to Serilog.Exceptions

public static Serilog.LoggerConfiguration WithProperties(
            this LoggerEnrichmentConfiguration loggerEnrichmentConfiguration,
            IDictionary<string, object> properties)

@RehanSaeed what do you think about each topic?

from serilog.exceptions.

RehanSaeed avatar RehanSaeed commented on May 30, 2024

That would be excellent. I tend to use GhostDoc in combination with turning on the documentation file in the csproj and the StyleCop documentation rules.

from serilog.exceptions.

RehanSaeed avatar RehanSaeed commented on May 30, 2024

a. Yes
b. Yes
c. I added this at the time because it was useful to me but yes I agree that it does not fit in with this project.

from serilog.exceptions.

RehanSaeed avatar RehanSaeed commented on May 30, 2024

Consider removing the lines related to comments here

from serilog.exceptions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.