Same Key Added Exception in ExceptionPropertiesBag about serilog.exceptions

[krajek]

From a quick look, it may be the case that we actually handle duplicate names incorrectly in this scenario.
Thanks for the report I will try to take a look at this in terms of code in the evening.
I don't think it has anything to do with the thread-safety, within one ExceptionPropertiesBag there is no concurrency.

[krajek]

@jaytilly on the second look, I change my mind, I don't know how to reproduce this one. Why do you think this involves some threading issue?

[jtillyt]

@krajek, I don't (yet) have exact repro steps that can be followed or a code-base that I can share freely but I arrived at the possibility of threading due to the places in code that the error tends to occur around. It seems to be in areas where there is a lot of concurrency with the same exception(s) being thrown on different threads. I'll dig in to try and narrow down the cause a bit later in the day.

I appreciate the quick reply.

[RehanSaeed]

The ConcurrentDictionary would be the best approach if this is indeed a concurrency issue (I've not looked deeply).

[RehanSaeed]

Anyone had a chance to look at resolving this?