Coder Social home page Coder Social logo

Comments (3)

krajek avatar krajek commented on June 12, 2024

Hey @Igor-Zlatomrezhev,
for us to work on that we need a small example.
https://stackoverflow.com/help/minimal-reproducible-example

I have no idea how your problem relates to our library from the description.
On the contrary, it looks, like the output from Serilog.Exceptions is fine and it is 100% related to your sink.

Maybe a tip:
You can control the destructuring process by providing your own destructurers for specific types of exceptions.
Consult README for details.

from serilog.exceptions.

Igor-Zlatomrezhev avatar Igor-Zlatomrezhev commented on June 12, 2024

@krajek Maybe you are right and I am writing to the wrong team :)
Please take a look at the problem from my point of view: problem only exists when I add "WithExceptionDetails" to configuration file. And "WithExceptionDetails" is implemented in your libarary, right?

So I take Exception's Details provided by your library, convert it to specific json format using ElasticsearchJsonFormatter (also provided by Serilog) and try to feed it to Elasticsearch.
It works perfect for most of exceptions. It just does not seem to work for some of Postgres exceptions.

I really want to keep Exception's Details in my logs. But right now I cannot do it because I end up loosing whole exception because it cannot be imported!!!

Maybe I just need to wait for destructurer of Prostgres exceptions to appear? :)

from serilog.exceptions.

krajek avatar krajek commented on June 12, 2024

@Igor-Zlatomrezhev I think I understand you point of view, you made it clear why you started with our library in your investigation.

Notice, that Serilog.Exceptions is responsible only for destructuring your exceptions.
In your case this is everything inside fields.ExceptionDetails.
If you think, that the contents of this property is incorrect, please point out where exactly and why you think so.

Serilog.Exceptions is not responsible for anything that happens with destructured exception afterwards. If for example your elastic instance is configured incorrectly and refuses to accept this log entry for whatever reason, that's not what we will work on.

However, make sure you understand our extensibility points.
Please go through README and learn about custom destructurers.
Maybe you need one for your case, to change the default behavior.

I will close the issue, because there is nothing for us to do.
I hope you will appreciate honest response.

Feel free to open if you can point out the flaw in the destructuring process I mentioned.

from serilog.exceptions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.