reactioncommerce / api-plugin-tags Goto Github PK

Prerequisites

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue? Search issues

Issue Description

The problem is that Tag's slug is unique across the whole system. For system where there can be multiple shops it doesn't look like a good solution since it's a very common case to have same tags in different shops

Steps to Reproduce

1. Start Reaction Development Platform
2. Log in to reaction-admin
3. Create a shop
4. Create a tag with name 'food'
5. Create one more shop
6. Create a tag with name 'food' in new shop

Expected result: Tag 'food' can be created since there are no more tags with name 'food' in this shop
Received result: Tag 'food' can't be created because of error GraphQL error: Slug food is already in use

Possible Solution

a) Slugs can be unique per shop.
b) Automatic slug resolution when there are duplicates like the one made for products (as I can see it doesn't throw but generate a new unique slug)

Versions

Reaction: 3.10.0

Thanks in advance!