reactioncommerce / api-plugin-tags

Tags plugin for the Reaction API

This repository is deprecated

This code is now located in our monorepo here

api-plugin-tags

Summary

Tags plugin for the Reaction API

Developer Certificate of Origin

We use the Developer Certificate of Origin (DCO) in lieu of a Contributor License Agreement for all contributions to Reaction Commerce open source projects. We request that contributors agree to the terms of the DCO and indicate that agreement by signing all commits made to Reaction Commerce projects by adding a line with your name and email address to every Git commit message contributed:

Signed-off-by: Jane Doe <[email protected]>

You can sign your commit automatically with Git by using git commit -s if you have your user.name and user.email set as part of your Git configuration.

We ask that you use your real name (please no anonymous contributions or pseudonyms). By signing your commit you are certifying that you have the right have the right to submit it under the open source license used by that particular Reaction Commerce project. You must use your real name (no pseudonyms or anonymous contributions are allowed.)

We use the Probot DCO GitHub app to check for DCO signoffs of every commit.

If you forget to sign your commits, the DCO bot will remind you and give you detailed instructions for how to amend your commits to add a signature.

License

This Reaction plugin is GNU GPLv3 Licensed.

api-plugin-tags's Issues

It's impossible to create tags with same names in different shops

Prerequisites

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue? Search issues

Issue Description

The problem is that Tag's slug is unique across the whole system. For system where there can be multiple shops it doesn't look like a good solution since it's a very common case to have same tags in different shops

Steps to Reproduce

1. Start Reaction Development Platform
2. Log in to reaction-admin
3. Create a shop
4. Create a tag with name 'food'
5. Create one more shop
6. Create a tag with name 'food' in new shop

Expected result: Tag 'food' can be created since there are no more tags with name 'food' in this shop
Received result: Tag 'food' can't be created because of error GraphQL error: Slug food is already in use

Possible Solution

a) Slugs can be unique per shop.
b) Automatic slug resolution when there are duplicates like the one made for products (as I can see it doesn't throw but generate a new unique slug)

Versions

Reaction: 3.10.0

Thanks in advance!