rar1741 / ra18_robotcode

Red Alert's 2018 Robot Code

RA18_RobotCode

Robot code for 2018 FRC competition for team 1741

Dependencies

Requires ctrlib installed on computer

Links

• Game Animation
• Game Manual
• ctrlib

---

ra18_robotcode's Issues

Too few issues

Code doesn’t have any issues.

Test ticket from Code Climate

Add Testing to robotbase.auto

may be a bit much for anything non-trival

Remove tabs from the codebase

Tabs are bad and we should feel bad.

Test ticket from Code Climate

Test ticket from Code Climate

manipulation should not use a spark

that needs to be a TalonSRX

Make Manipulation happen

whenever we know what to do

drivetrain should use a single solenoid

oops those aren't

Make motor spin

(using TalonSRX and phoenix framework)

Auto async

some stuff is there to tag moves as async, but its currently ignored.

Drivetrain will have pneumatic shifter

probably add to tankdrive.java

logging may not actually networktables

probably check that

GradleRIO

probably would be better than what we're doing

We don't have an issue or PR template

This makes me sad. 😭

Scoring has a motor and some pneumatics

hopefully some end of travel sensors as well

Add Testing to robotbase.config

parse a config file

Add cobertura for test coverage

Test ticket from Code Climate

another motor for manip

follow the already there motor for final stage

TankDrive needs logging

just all of the voltage/current/setpoint

Setup Tank Drive

likely to be the drive train we're going with

Some NetworkTables stuff is deprecated

new stuff may be on screensteps

Use TalonSRX follow mode in drivetrain

back motors (without encodes) should follow front motors (with encoders).

Add Testing to robotbase.input

Just make sure that edge detect edge detects

Make Scoring happen

first to figure out what they're doing

Add Testing to robotbase.logging

Log some things, make sure its right.

Scoring needs another DoubleSolenoid

that also needs to be logged

add logging to doublesolenoid

master doesn't run tests on commit

This makes me sad. 😢

Make the code smell less

Code smells

get position in TalonSrxWrapper

Make Config.java better

code climate really hates it for some reason

Manipulation has a brake

another Solenoid
part of #17

Use Naming Conventions

some functions and variables don't follow naming conventions, such as EdgeDetect.Check()

Logger crashes robot

********** Robot program starting **********
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console. Set system property 'log4j2.debug' to show Log4j
2 internal initialization logging.
Error at java.net.URLClassLoader$1.run(URLClassLoader.java:372): Unhandled exception instantiating robot org.redalert1741.powerup.Robot java.lang.ClassNotFoundException
: java.beans.PropertyChangeEvent
        at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        at org.apache.logging.log4j.core.LoggerContext.updateLoggers(LoggerContext.java:654)
        at org.apache.logging.log4j.core.LoggerContext.updateLoggers(LoggerContext.java:641)
        at org.apache.logging.log4j.core.LoggerContext.setConfiguration(LoggerContext.java:547)
        at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:617)
        at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:634)
        at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:229)
        at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:153)
        at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:45)
        at org.apache.logging.log4j.LogManager.getContext(LogManager.java:194)
        at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:581)
        at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:567)
        at org.redalert1741.powerup.Robot.<clinit>(Robot.java:9)
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:259)
        at edu.wpi.first.wpilibj.RobotBase.main(RobotBase.java:216)

Warning at edu.wpi.first.wpilibj.RobotBase.main(RobotBase.java:224): Robots should not quit, but yours did!
Error at edu.wpi.first.wpilibj.RobotBase.main(RobotBase.java:225): Could not instantiate robot org.redalert1741.powerup.Robot!

Make the code duplicate less

Code duplication

add logging to solenoid